2 Suggestions

[Shadowsuite]

Maybe this can come with RC3.

1. When the user clicks on the thumbnail from the index they'll go the "image" but from there they can click on the image again to see the "original" version. Now, what I want is that when the user clicks on the "image" and they're taken to the page where all the comments are displayed, I want the gallery to check if the photo is bigger than 640x480, if it is, I want it to make a thumbnail that is 640x480 and when the user clicks this thumbnail it opens up a new blank winder (As in, target="_blank") and just displays the image.

2. Add an option where the images can be stored into the MySQL database, and if the user is using a file system it will transfer existing wallpapers to the database.

- Devnull

[Zachery]

I think number 2 has been discussed before and was turned down for the shear storage issues.

MySQL is not ment to store mass quanities of biniary data and it doesnt do the greatest job in storing it either.

1). Couldn't you do that by editing the 'ADV_GALLERY_SHOWIMAGE' template, change the URL to just point to the original image, and add target="blank" in the link?
2). As Zachery said, bad idea. Allowing the database to get that big would cause nothing but problems.

[Shadowsuite]

Originally Posted by Brian

1). Couldn't you do that by editing the 'ADV_GALLERY_SHOWIMAGE' template, change the URL to just point to the original image, and add target="blank" in the link?
2). As Zachery said, bad idea. Allowing the database to get that big would cause nothing but problems.

When you are viewing the image in the 'ADV_GALLERY_SHOWIMAGE' you're seeing it at the original size. I want it to be able to detect whether the size of the image is greater than 640x480 and if it is, to generate another thumbnail and when this thumbnail is clicked it opens up a new blank window with the original image.

On one of my presales question you said I will need to use an 'if' statement and it would be easy to do (http://www.vbadvanced.com/forum/show...36&postcount=5)

- Devnull

[KW802]

Originally Posted by Shadowsuite

When you are viewing the image in the 'ADV_GALLERY_SHOWIMAGE' you're seeing it at the original size. I want it to be able to detect whether the size of the image is greater than 640x480 and if it is, to generate another thumbnail and when this thumbnail is clicked it opens up a new blank window with the original image.

On one of my presales question you said I will need to use an 'if' statement and it would be easy to do (http://www.vbadvanced.com/forum/show...36&postcount=5)

- Devnull

You got me confused somewhere. Let's say you have a wallpaper image that's 1024x768 in JPG format. In your file types I'm assuming that you have configured JPG to have a size limitation of 640x480. When you upload that image it creates a thumbnail, and "image" and keeps the original. When you click on the thumbnail you get taken to the "image" and right now when you click on the image you get taken to the original.

So the only thing you want to change is that when you click on the original that it opens in a different window instead inline like it does now?

Set the max file size for images to 640 x 480 in the 'Edit Filetypes' link in your admincp. Make sure 'Save Original Files' is set to 'Yes' in your main options. Then in your 'ADV_GALLERY_SHOWIMAGE' you should see the <if condition> for original images. Change the link there to point to $image[url] rather than showimage.php and add target="_blank".

[Shadowsuite]

Originally Posted by Brian

Set the max file size for images to 640 x 480 in the 'Edit Filetypes' link in your admincp. Make sure 'Save Original Files' is set to 'Yes' in your main options. Then in your 'ADV_GALLERY_SHOWIMAGE' you should see the <if condition> for original images. Change the link there to point to $image[url] rather than showimage.php and add target="_blank".

Thanks, sorry, I'm confused on the last bit, can you tell me which <if condition> do I change please.

Thanks

Content visible to verified customers only.

[Shadowsuite]

Thanks

[Shadowsuite]

Just one problem, when i click the link, the same page shows up, as in the picture isn't in its original size and I can see the forums header and footers and everything.

[StewardManscat]

If anything come of these and similar suggestions, let us hope for greater granularity of the link and image information available to the template. I'd wish for:

$image[height]=200
$image[width]=480
$image[player]='gallery/misc.php?do=something&i=76542'
$image[alt]='My Wedding'
$image[relativedir]='files/3/4/5'
$image[ext]='wmv'
$image[basename]='mywedding'
$image[src]=http://www.mysite.com/gallery/files/3/4/5/mywedding.jpg

(Ok,ok so my sample values don't all make sense taken together)

Etc etc. In other words, let us build the anchor and image tags in the template.

Break up that contruct_image_url(), and you can still use the pieces to duplicate existing functionality, and return the composite template variables. But also give me the weapons to blow a large hole in my foot.

Cheers

[KW802]

Originally Posted by StewardManscat

Etc etc. In other words, let us build the anchor and image tags in the template.

I'd have to vote the opposite and keeping it as it as. By constructing the URL in the PHP there is a lot more flexibility available in what you can do (PHP is just a tad more powerful than VB's conditionals ) plus then it allows you to keep your templates as compact as possible.

Example: http://www.coolscifi.com/gallery/browseimages.php?c=31

Click on any of the SWF files.... I was able to change the PHP file really easily to play the flash files inline. In the PHP I have a lot more information available to me so I was able to do some code that will automatically specify the SWF's height & width based upon the values I have in my Gallery's file types table for the "SWF" entry I created. In other words, I have configured SWF in Gallery in the ACP with a max height of 600 and a max width of 600 and if a SWF is smaller than those dimensions then it'll play full size but if it's larger than those dimensions then the height & width parameters in the resulting HTML is automatically scaled back to keep the output within my max dimension. .... without having to make any template changes.

Trying to do that same type of functionality in just the templates alone would've been a major headache and some hard-coding.

Throwing that code into a template also causes it to have to process that additional template, which I believe would add more strain that it would be worth considering that the number of people that will need to change that will be very minimal.

[StewardManscat]

Agree with both counts. Going to have to be more specific now. Please take no offense, none is intended. I'm actually hoping for a change in the code. So far I haven't hacked much, but our gallery is central to the site, and tweaked code is what makes us unique. If the gallery code is granular, I'm going to be able to get my hooks in without touching much of it, hence less pain for RC3 and sons.

Make you a deal. Create this function:

Content visible to verified customers only.

and use it in your construct_image_url(). I'll write my own set of image url functions, but won't have to worry about remembering that line for changes, because I'll be able to use that function in my custom code.

The function has too much in it to be safely cloned yet remain current. See where I'm coming from?

Similarly, I notice construct_image_bits() is overloaded. It (1) loads the $image array for use in a template, and (2) evaluates the template. Darn!

It would be helpful to have, eg:

Content visible to verified customers only.

... now I can write cmps modules that create groovy image blocks using a different image template. But you load the image array.

I may be way off base. Give me some time and I'll die of embarrasment re-reading this message. Meantime, I hope it doesn't hurt to speak out.

I'm surprised to hear Brian say there's not much call for alternate image url handling. I'm going to bet this issue doesn't go away. This software is all about showing images.

I'm making mistakes as fast as I can...

[KW802]

Originally Posted by StewardManscat

Make you a deal. Create this function:

Content visible to verified customers only.

OK, now that one I could've used but to take it one step further.... ideally the file types table would have a definition table (eg: "picture", "video", "audio", etcetra) so that everytime you add a new file type (eg: "mov") you then assign it to the corresponding file type category (eg: "mov" is assigned to the "video" category). The definition table would come pre-loaded with some basic categories just like the files types table does currently but the user would be able to add/modify entries. That way then you could do stuff like a switch statement on the file type category so changes like custom URL's based upon the type of file would be a lot easier to do. Heck, to take it even more down the "It'd be cool if..." road the actual URL code itself would be an 'action' field in the 'file type categories' table -- If I wanted to add a new a new type of file "xyz" I first add a new category called "some_weird_file_type" and fill in the 'action' field of how files in this category should be displayed and then just add my new "xyz" file extension to the file types table.

But, I digress. I would tend to think that at the price-point that Gallery is coming in at that the 'typical' Gallery user is somebody who would use the product 'out-of-the-box' so putting a lot of over-head in for features that might only be truly (or, at least, effectively) utilized by a small segment of the customer base would be a fruitless effort in the long run. At this point I'd rather see Gallery stick to the 80/20 rule and get a 'gold' version out the door.

[nyifan]

Originally Posted by Brian

Set the max file size for images to 640 x 480 in the 'Edit Filetypes' link in your admincp. Make sure 'Save Original Files' is set to 'Yes' in your main options. Then in your 'ADV_GALLERY_SHOWIMAGE' you should see the <if condition> for original images. Change the link there to point to $image[url] rather than showimage.php and add target="_blank".

Brian;
This is sort of what I wanted - is there a way to link JUST the full size image? If you click the link now, it does open a new window, but it still has all the header, footer etc on the page. I was looking to have JUST the full sized pic itself in that _blank window. Thanks for any suggestions!

[Shadowsuite]

Originally Posted by nyifan

Brian;
This is sort of what I wanted - is there a way to link JUST the full size image? If you click the link now, it does open a new window, but it still has all the header, footer etc on the page. I was looking to have JUST the full sized pic itself in that _blank window. Thanks for any suggestions!

That's what has happened to me as well!

[nyifan]

Brian (or anyone else) ?
any suggestions here?
I've messed to the limits of my ability, and have come up empty
Im not saying I want an answer spoon fed, but a direction would be great

[StewardManscat]

I read on the forums that RC3 may have member galleries, which may mean I get excited about it all over again (live in fear!).

I'm not sure my point was taken here. In particular, I do not understand Brian's response:

Throwing that code into a template also causes it to have to process that additional template, which I believe would add more strain that it would be worth considering that the number of people that will need to change that will be very minimal

My suggestion is simply this. I believe the function construct_image_url($image, $filename = 'filename', $fulllink = false)
is overloaded. It does too much.

You can keep it and still use it.

But inside that function, use a number of different functions to grab the pieces. Eg

construct_image_src, construct_image_tag, construct_image_dimensions etc etc.

Then we hackers can use the piecemeal functions when adding new stuff.

I'm just being lazy, no doubt about it. I want you to do this work, not me.

I phrased my original comment in terms of templates. But what I'm really looking for here is to be able to leave your function alone. Getting inside it is not a pretty hack.

It would be safer and easier to leave it alone. Yet if I write my own set, I need to duplicate static data and application logic which may change in future releases.

Hope that makes a little more sense. I understand it's a bit picky.

Truly I believe you will see many interesting add-ons to gallery, more than your other products, and this function is core to getting a picture.

Respectfully,