[Fixed] template adv_gallery_navbar

Luciano · March 19th, 2009, 01:22 AM

I have been having trouble with the gallery navbar... (also in beta2
Cosmetic no nos and sessionurl errors causing other errors... (like the category not being automatically selected when clicking upload in a category or me being logged out in my office, because we have cookies disabled)

I fixed the template adding a little tweak...

what was fixed:

Sessionurl errors: replaced ?$session[sessionurl] with $session[sessionurl_q] where needed
Sessionurl errors: replaced ?$session[sessionurl]&do... with ?$session[sessionurl]do.. where needed
Replaced & with & where needed
Changed id tag location from <td or <span to <a tag (this made in some layouts the dropdown menu not being centered under the link for monitors over 24" and screen resolutions like 1920x1200). As the dropdownbutton is now underlined by the link (like in vbulletin navbar), i added a class called gbar to the links so if you want you can add a css with text-decoration:none to the vbulletin css that will remove it.

here it is. Just replace the old template adv_gallery_navbar in the template manager with the one below for the style you want. If you dont want it anymore, just revert the template and you will have the original.

(there is no screenshot as you will not see any difference
but check the page at w3c.org it wont validate without the changes)

Code:

Content visible to verified customers only.

if the underlined links disturb you, you can add in the extra css in the style manager:
a.gbar {
text-decoration:none;
}

-------------------

What still can be done.. to remove a little markup.. is to remove the <span class="smallfont"> sourrounding each link..
You would then have to add the smallfont class to the td tag changing

<td class="alt1"
to
<td class="alt1 smallfont"
for every <td tag
I have not checked if this would have some consequences.. thats why i did not implement it here..

Luc
PS: Todo:
there is one todo left.. forgot about that one..
IF a user cannot create a membercat.. hi still has the menu item "catadmin" ... of course if he clicks it.. he gets a no permission ... (which is completely correct) but...

I would like to remove it, if a user does not have permissions, he shouldn't even have the possibility to click it..

Luciano · March 29th, 2009, 04:08 AM

AAAAAHhh .. seems I cant edit post #1 anymore!!!

OK found another bug in that template...
and fixed another issue!!!!

Just found another error in that template

there is a wrong conditional in whats new:

Code:

Content visible to verified customers only.

The whats new menu has NOTHING to do with replies being enabled or not.. leaving it as it is would meen there is no "whats new" dropdown If replies are off!!! (even if there are new images)

I removed the conditional and added if popups enabled !!!
also removed the class="gbar" because i corrected the id tag position to span, so the bar now behaves as expected without the additional css)

Please replace the template if you are using it!!!
If you have not installed it.. just open the template adv_gallery_navbar in the template manager and replace the contents with the html code below.

Here is the new template: (overwrite the one in post 1!!!!)

Code:

Content visible to verified customers only.

Also removed the class gbar i had added... its not needed anymore..

Luc

Michael P · March 30th, 2009, 08:57 PM

Ok, I'll put in next update.

marcovb · March 30th, 2009, 09:44 PM

glad to see this one will make it in 2.5....the menu should definitely be under the text....

Luciano · April 1st, 2009, 12:48 AM

Quote:

Originally Posted by Michael P

Ok, I'll put in next update.

Great, please double check there are no typos..
AND
[Fix] Template adv_gallery_nav
is even more important!!!!
Luc