Next/Previous Links

Max Paint · March 2nd, 2009, 10:32 AM

Just downloaded the BETA-Version. Thx so far

Already found a bug: Next/previous links aren't working anymore

Luciano · March 2nd, 2009, 02:02 PM

Quote:

Originally Posted by Max Paint

Just downloaded the BETA-Version. Thx so far

Already found a bug: Next/previous links aren't working anymore

Mine are working.. just downloaded the beta and a 2.43.

I did a file compare and nothing has changed with the previous/next links..

Luc

Chuck S · March 2nd, 2009, 02:02 PM

Yes same here mine are working as well

Luciano · March 2nd, 2009, 02:33 PM

@Chuck
I would suggest you open a new thread for beta discussion
Luc

Chuck S · March 2nd, 2009, 02:39 PM

Luc not sure what you mean by that. I work here

I was confirming your diagnosic as well

My suggestion to Max would be to try and reinstall the templates.

Luciano · March 2nd, 2009, 02:53 PM

Loooool I know you work here
Nooo i meant to open a special thread where users discuss the new beta. could be sticky

Example title: Vbgallery 2.5 beta 1 discussion
where users can give their opinion..
AND
a second thread where users can post bug reports.
Example title:Vbgallery 2.5 beta 1 bugs

Because i accidently stumbled into this thread.. (didnt get notification because i hadnt posted in it).. if I wouldn't have stumbled into it.. i wouldn't have known the beta was out.

Also.. I dont want to look through the whole section to see if someone posted a bug (for the beta) or just saying.. hey its super...
thats because i'm lazy

L.

Chuck S · March 2nd, 2009, 03:00 PM

Well one forum is good for a temporary forum I think. Max simply did not create a new thread when posting about his issue. No worries I just split off these posts into a new thread.

Luciano · March 3rd, 2009, 12:41 AM

Good...
But still.. as there is no announcement.. no special thread.. how would I have known that the beta is out.. without having stumbled into this thread????
I dont check the download section every hour..
Luc

Max Paint · March 3rd, 2009, 04:36 AM

Made a change in showimage.php as read here:

Previous Image - Next Image

So I deleted

Code:

Content visible to verified customers only.

Seems to me that this is a problem of the older version, too

Luciano · March 3rd, 2009, 08:04 AM

What I dont understand..

I do NOT have the problem..
But if I remove that line..
Do I loose the ability to stay in users images when using previous next links.. ?? (click an image in Luciano's images and then surf to previous next -- but that seems to work if that line is there or not...)

Or Is this issue happening only when you are in usergalleries? or in normal galleries also?
Because i dont use usergalleries...
Luc

Max Paint · March 3rd, 2009, 08:19 AM

I also don't use usergalleries. The URL does change for example. If I'm looking at pics of a user, for example the link

http://www.maxpaint.de/gallery/showimage.php?i=1065&catid=member&imageuser=99

"Next" image is:

http://www.maxpaint.de/gallery/showimage.php?i=1031&c=0&imageuser=99

Chuck S · March 3rd, 2009, 08:23 AM

Some things posted on this forum Max are user specific only changes as in that old thread like if no one can reproduce an issue we sometimes post something for the user to try to see if it resolves there specific issue.

Luciano · March 3rd, 2009, 09:13 AM

Quote:

Originally Posted by Max Paint

I also don't use usergalleries. The URL does change for example. If I'm looking at pics of a user, for example the link

http://www.maxpaint.de/gallery/showimage.php?i=1065&catid=member&imageuser=99

"Next" image is:

http://www.maxpaint.de/gallery/showimage.php?i=1031&c=0&imageuser=99

Ahhhhhhhhh I understand.. but that is a different problem...
( i dont have the code in front of me because i'm in the office...)
anyway i changed the construct_adv_sort_url function... because there were lots of problems.. (ugly urls, wrong urls etc...)

so probably thats why i dont have the problem..

Luc

Max Paint · March 3rd, 2009, 09:26 AM

The funny thing is: I get only "broken links" in categories where I didn't upload any pics myself. If I choose a cat where I uploaded one or more pics, the next/previous link "work" but only lead to my own pictures.

Chuck S · March 3rd, 2009, 10:05 AM

Quote:

Originally Posted by Max Paint

The funny thing is: I get only "broken links" in categories where I didn't upload any pics myself. If I choose a cat where I uploaded one or more pics, the next/previous link "work" but only lead to my own pictures.

That is because that specific query tells the program to do that

Code:

Content visible to verified customers only.

It really has no consequences deleting it that I see off hand which is why I suggested it to you along time ago to see if it helped. I think the core issue here is why you are the only one affected by this meaning what setting how are things configured differently than the rest of us that would cause you to be affected by such an issue that normally we can not see.

My usual response is to ask users what exact steps they are doing to get to such an issue and I think we have already been there and we cant reproduce the issue which is the mystery here.

Max Paint · March 3rd, 2009, 10:18 AM

Perhaps this could help also. I'm using VBCMS, too. As I read in their supportforum, this CMS uses catid as a global variable. One advice was to add unset($vbulletin->GPC['catid']); in gallery_global.php after require_once('./global.php');.

But that didn't help. I deactivated VBCMS completely and the links are still broken. The only change (while disabled VBCMS) is

http://www.maxpaint.de/gallery/showimage.php?i=xy&c=0&imageuser=xy

turns to

http://www.maxpaint.de/gallery/showimage.php?i=xy&c=member&imageuser=xy

But I think it should be

http://www.maxpaint.de/gallery/showimage.php?i=xy&catid=member&imageuser=xy

Shouldn't it?

Luciano · March 3rd, 2009, 12:36 PM

[I'm back home]
Ok max.. try this.. it is the adv_sort_url I use because i ran into problems long time ago...

what it does though.. it handles the searchid correctly.. (what the original does NOT do) .. AND it removes the ugly c=nothing in ecard.php... which is not really needed, but it handles the specials cats like member a bit differently.

to test it do the following:
open forums/includes/functions_gallery.php
and find:

Code:

Content visible to verified customers only.

replace with:

Code:

Content visible to verified customers only.

then just above add:

Code:

Content visible to verified customers only.

I cant remember if i did some other changes to make it work..
BUT if it doesnt work for you just remove the new function and remove the _old from the old function and you will have it again as it was..

AH i almost forgot.. check if in your version the changes mentioned here:
Showimage bug with sorturl

are done.. I think chuck implemented them in the download showimage.php file, but i dont know if they are also in the file You are using.

Luc
[EXPLAIN]
The problem with the old one, it only checks the request['do'] for categories like member, favorites etc... when you do previous/next or filmstrip.. you will loose the category as it has become: catid=member... here it checks the request['do'] and then.. it checks if the request[catid] is maybe a special cat like member, favorites etc...
As for the searchid.. the old one only adds the searchid if it is asked to do so.. with $extra.. so on previous/ next and filmstrip you loose the searchid, because $extra is defined nowhere in showimage.php. The new one will append the searchid.. so you stay in the images of your search when you look at a series of found images... (I hope someone understood this explanation loool)

[/EXPLAIN]
PS: Its not optimized... i just removed other stuff i have added to make it work on a clean install.. if there is general need, i can clean up the code...

Chuck S · March 3rd, 2009, 12:43 PM

Kristi - testing links http://www.something.com/something/ http://www.something.com/something/ PhotoPost vBGallery

Yeah I would suspect it might be a hack/mod conflict of somekind

the next previous links which show other photos in that specific category work on my little test install with or without the variable

Luciano · March 3rd, 2009, 01:04 PM

Quote:

Originally Posted by Chuck S

Kristi - testing links http://www.something.com/something/ http://www.something.com/something/ PhotoPost vBGallery

Yeah I would suspect it might be a hack/mod conflict of somekind

the next previous links which show other photos in that specific category work on my little test install with or without the variable

Yes thats because they are in the same category..

if you are looking at search results.. with images in different categories, you will only see the first image as part of the result.. (the filmstrip will have images of the category that image was in.. after the second image..) AND not the images of the result anymore.. thats why i modified that adv_sort thing in first place...

If you stay in a cat.. it works fine as is.. but in some special cases.. the filmstrip jumps back to the cat the main image is in.. dont ask me why.. (actually what i suspect is that there are one or 2 wrong links somewhere.. but i think i will never find them)

Luc

Chuck S · March 3rd, 2009, 01:31 PM

Any bugs we discussed on previous versions Luciano should be included and I show they are.