I mentioned this in another thread but wanted to put it in a separate thread.
I was doing an album search for specific keyword in a title but the image I expected to see in the search results wasn't there. What I discovered was that this image was a retitled "copy" of another one I had uploaded.
It is the nature of the beast. Users complained about seeing the same photo showing up multiple times in the program. The original image is the only stored image on disk. The rest are just copied inserts in other cats
Well, I think instead of opening a new thread I'll attach to this one. Of course, it makes perfect sense not to show the copies of images in the search results - who wants to see three times the same picture? But wouldn't it make the same sense not to show copies of images when using the "Last 1 day" "Last 7 days" function? If I do that, I see most of the images twice, because it shows copies to other categories (several users already contacted me and asked whether I could delete their duplicate imagery that in fact was not duplicate at all). How can this be fixed?
Yes, it did the trick for the "last x days"-function. But now pictures that are sorted into more than one category don't get displayed on a category's gallery home.
Image XYZ is sorted into user album A and category B. If I apply the code change you proposed, the following happens:
- the double-image bug is fixed. No more double images in the "last x days"-function
- the image is still visible in gallery view of user album A.
- the image is not visible in gallery view of category B.
Clearly, this is not a feasible option, so I undid the changes to showgallery.php. Sorry to be a nuisance, but I think this is quite fundamental.
Albums and categories are two separate things. The change I noted in showgallery is valid to not show duplicates. album photos do not show on a category anyway so your losing me here with your description. If one assigns an album to a category all you see is an album block with an thumb representation. Those are two separate queries and nothing has changed there
Of course album photos show up in categories. What else would the "copy to category"-function be good for? That's what we are talking about in this thread, are we not? This was never about assigning whole albums to a category, but about assigning single images to a second category.
Obviously, I did not fully analyze the code. But the index pages of categories are called by showgallery.php, and that's where the changes are made. After the changes, the single photos copied to a category from a User Album are not shown in the index of that category any more. If you say that there can be no connection, I have to say that there has to be, since this is the only change I made to showgallery.php and I'm able to switch this behaviour on and of by applying and removing the code changes.
O.K., let's see, once again:
I have a single Photo. This single photo I upload to my User Album (showgallery.php?cat=564) and at the same moment I copy it to a category (showgallery.php?cat=502).
If I leave showgallery.php unpatched, I see the single photo in my User Album and in the index of the category I copied it to. But: If I use the "Last x days" function, I see the photo twice.
Now I apply the patch to showgallery. The "Last x days" function now works perfectly well, and I can still see the photo in my User Album. But it has vanished from the category index now. If I call the category index (showgallery.php?cat=502), the photo does not show up anymore. Once again: This is not about assigning an album to a category.
There is a reason the code is the way it is then. You must allow showing multiple Photos in the ALL scenerio's if you want things to work right when viewing albums therefore back out and use the unaltered code.
As I and several other user in this forum have stated several times: The overall handling of image-copies does not make any sense at all. I made a statement over at suggestions, but up to now nobody cared to explain to me or the many other customers what sense it may be to show images twice in some places and not at all in other places (see first and second posting in this thread). The handling is just inconsistent.
Since showgallery handles displaying both categories and albums it must be coded as noted. If you add a statement to not show those duplicates there when viewing a category or album you will never see the images that are copies so only must show them on VIEW ALL etc because they are in essense being treated as a real photo. We can remove duplicates out of photo blocks little stuff like that but on the overall scheme of things these are true full photos just only one photo is kept on disk