In the process of upgrading one of our forum sites from 4.7 to 5.13 using the upgrade.php app, there is a step that moves files. (4.85 step 2) Well, this particular site has so many images (about 3 gigs) that the browser 'timed out' during this step and we have about 15,000 or so images "missing."
Has anyone experienced this? We have the sight backed up, but this still puts us in a pickle.
Thoughts or suggestions are greatly appreciated. Thanks in advance.
Um ... why does the upgrade not first check to see if the user id has ALREADY been prepended to the filename? I see now that the database entries have the user id prepended twice, which means that i ran step 3 for upgrade 485 twice. My fault, but the upgrade should be more careful.
No offense, but restructuring the filesystem after a product has already been established is a Bad Idea. In this case, i can see the necessity due to hogging up too many inodes on the filesystem ... but in the least, don't you think a simple check to see if the user id has already been prepended would be helpful to prevent tacking it on a second or third time?
Another issue. Since you are now putting thumbs in dirs ... shouldn't each user have their own directory. Prepending to filenames is generally another Bad Idea. That's what directories are good for.
I didn't say it wasn't a change for the better -- i just said it was a Bad Idea. Bad Ideas, however, are necessary sometimes, but Good Software design typically involves deprecation, not outright deletion. One word: transactions. Bad Ideas can be Not So Bad Ideas when you throw in the ability to roll back. Sure, it is my responsibility to make backups (which i have), but MAJOR changes such as this are Bad Ideas because if they are not atomic, they will lead to Head Aches.
I still think a simple check to make sure that the user id had not already been prepended to the filename would be a good safety belt.
One thing i still don't understand is why the decision to prepend the userid to the filename? Why not simply create a directory for that user and store their images there? Doesn't prepending the userid to the filename recreate the same problem as prepending the word 'thumb' instead of using a seperate thumbnail directory?
Hello The script from the beginning of time prepended the userid so creating a directory for every user in every cat was not the way to go. Thats just not how they built the application originally years and years ago.