ReviewPost 6.0 Questions - Page 2

Chuck S · August 22nd, 2012, 11:52 AM

well not really sure thats specifically a bug. If I look at all the other search pages in the other applications the search page is all the same no titles are clickable. Not to say thats something we could not alter in the future.

The edit I suggested above is something I found to resolve the issue based off our last discussion where you never responded back. I found that if I wrap a description with those div tags then the ol li tags work. I am assuming that those div class tags have specific ol li class definitions that override the global ol and li statements that vb uses so that things look right. Remember your earlier discussion was all about the ol and li tags where not what you wanted them to look like. That was because they where using the vb global ol and li class definitions. This was an issue specifically related to vb4. Using those div things solves that issue.

Your line breaks I can not tell whats real and whats not. I mean viewing your source you have break tags everywhere. Remember the application will convert line breaks into break tags so if your users are hitting return on a line and also adding break tags you might have double breaks.

I can not say because we are dealing with a specialized use here. It is not like your actually using the editor in our program your copying and pasting which is a whole different thing in itself. If you are copying line breaks in then that I would suspect is your issue.

My example showed clearly if I enter the description with just the proper html and text it does display correctly

editor - Reeftalk Reviews

There are not extra breaks there and I am using your own text. I simple removed all the <br /> tags

carsafety · August 22nd, 2012, 02:20 PM

Consider it a feature request as far as the product titles being linked then please. Intuitively, if you search anything anywhere, the results are nearly always links. I just assumed it was a bug and had intended to be that way, sorry!

The formatting issue is resolved as I mentioned. Those posts that were not showing the formatting they had prior to the update now show the formatting correctly with that template fix you provided. I know you had resolved some issues for me last year, perhaps it might have even been a template edit you made to fix it, unbeknownst to me. Either way, Thanks!

Obviously, I'm not sure what caused an extra space to appear between lines during the upgrade. It may have to do with how we entered our formatting, but ultimately, I would still expect it to appear as it does in the editor. What I do know is that it appears now with an extra line between everything than there was before. Sometimes more than an extra break between sections. These breaks also don't appear at all in the editor, you can see how compact they are in the image I posted vs. what it looks like when you view the product page.

So, even if I took it upon me to manually edit every single review to remove breaks, I still would not be able to do so because the editor doesn't show them. Prior to the upgrade, it looked how your website shows it. Now there are extra breaks. Even in the product you used as an example, if I go into the editor, it looks like the attached image.

Sorry to be a newb as usual, I'm sure it's something simple that can be fixed, but I'm not seeing how to make it look like it appeared before the update.

Chuck S · August 22nd, 2012, 02:48 PM

If you want me to look at your site and come up with a custom solution for your old descriptions I would need ftp access as I said I do not know why you have all those extra breaks they are being entered possibly because your copying things from one editor in vb to the editor in our app. I can not say but definitely like I showed if I take a properly formatted message without breaks our application does show them correctly.

In your site I would probally turn off the editor and edit one of the old reviews to see what is actually there. That way I know what we are working with here.

The test I did was I took one of your descriptons and like I said removed any <br /> tags and simply typed the message with the proper html tags you want for things to display like bold list etc. It displays fine.

The Theory I have is that some of your old content probally has line breaks which is common when typing a paragraph and break tags as well. When your description is processed for display any line breaks in your description which are \r or \n in the formatting are converted to <br /> tags. If you have both line breaks and break tags in your html description that would definately explain your issue.

I have a search file that adds the title as a link so you can email me and I can send you that file.

carsafety · August 22nd, 2012, 03:27 PM

Would these breaks not show in the reviewpost editor for some reason then? Because at the moment, what is in the WYSIWYG editor looks perfect as in the screenshot.

I did just try to use the rp editor and backspaced out every line to run into the preceeding line and then hit enter to separate them again, presumably clearing out any "invisible" breaks. I didn't see any change. This leads me to believe the extra line spacing is embedded such that the editor can't touch it or that it is added as the page is displayed or something.

I would not be surprised if the extra breaks were caused by the manner in which the moderators had to copy/paste the reviews in order to get the formatting to appear in the previous version. It was the only workaround we could find. The question then becomes what caused the extra breaks to suddenly appear in the upgrade.

Obviously, whatever may be causing it, I'm hoping it's a setting or something simple because going back into every review and editing every line is going to be a major hassle, even if what needs to be edited out becomes apparent.

The ftp password should now be the same as the one I emailed earlier.

I am out of time for today. Tomorrow I will try to take an original post from the vB section and upload it from scratch and see how it appears.

Chuck S · August 22nd, 2012, 03:37 PM

What I am saying is if you turn off the editor you should see how it is actually in the database. I can not say what the editor is going to show.

I highly suspect your issue is in your workaround you did earlier. I did a quick look and your users in what I see is they are using paragraph tags in conjunction with hitting returns on lines.

What this tells me is your going to have break tags on line returns PLUS there is the spacing that the html paragraph tags add so this in essence tells me this is your double spacing.

carsafety · August 22nd, 2012, 03:44 PM

Right, so even if that is the case, is there something simple with the update that can be changed to make it look how it was before the update. Something changed it, a new template, php file, database change, whatever it was. Can this be reverted somehow with an edit?

If you are saying I will have to use something like phpmyadmin to go into the database for each file and remove every page break just to have it display how it did before the upgraed to 6.0, that would be a rather time intensive task that likely means my project is dead for a long time, if not permanently. Even if I had the funds to pay the moderators to go in and manually edit all their existing products if they could even see the all the extra lines to remove, that would likely be difficult to do, especially given all the headaches they had getting it to work right in version 5.

What do you mean by turn off the editor? Is that a setting in RP? Probably something I've forgotten. I'll take a look in the morning.

carsafety · August 22nd, 2012, 03:51 PM

Lol you must have just done something, as the spacing issue appears to be fixed now. May I ask what it was?

Also thanks for fixing the search result title link issue!

Chuck S · August 22nd, 2012, 04:00 PM

Not really sure I did anything. I uploaded a modified search.php file for your title to be linkable.

Your descriptions still look like they take up way too much room than they need to to me when I view your site for the reason I posted above. Your using both paragraphs and line breaks.

carsafety · August 22nd, 2012, 04:18 PM

I'll check again in the morning as well, but a few I know that had lots of extra spacing now appear to have a single line break. I haven't checked many others so it could still be there or it could be more than one issue involved perhaps. I wonder if part of it could be a cache issue or something, causing something done hours ago to only have appeared now. I'll verify with a different browser also. I have to take a break from it today as I'm pulling my hair out lol.

Chuck S · August 22nd, 2012, 04:20 PM

LOL yeah I have been in development straight through the last 9 months between support etc. I am lookiing for a little break. LOL

carsafety · August 22nd, 2012, 04:23 PM

Right now on my browser, your forum post:

editor - Reeftalk Reviews

and mine:

Advocate 70 CS - CarseatMoms Product Gallery

Are appearing on my screen the same, with a couple minor exceptions that I also see in the editor. The extra line breaks that appeared on my forum an hour or two ago between each bullet and section are gone. There's still a single line break that doesn't appear in the editor, but that is how it was prior to the 6.0 update as well.

If you didn't touch anything, I have no idea what I may have done. I didn't change any admin settings or much of anything other than making that template change you suggested. Guessing that's not it, because I saw those format changes immediately but the extra breaks remained. Since then, I've mostly been trying new uploads and using the editor and such, stuff that wouldn't have affected anything more globally. Weird.

Chuck S · August 22nd, 2012, 04:34 PM

yeah there are minor differences as I probally did not enter exactly what you have as I did a copy and paste from the source of your page and removed those div tags and break tags then posted it on my site.

Enjoy your evening and some rest.

carsafety · August 23rd, 2012, 10:53 AM

I just noticed that I lost my Amazon affiliate code in the dealtime link since yesterday. I had added it back into showproduct.php right after the upgrade. I looked and it appears you uploaded a replacement file around the same time the line breaks disappeared yesterday. Perhaps something in that file or another change made at that time caused the global fix for the line breaks I noticed- maybe simply a corrputed file during the upgrade?

Seems to be working as expected now. Even in uploading a review from a vB post, I can remove the extra linebreaks and have it appear as it did before the upgrade. There is still a single linebreak between bullet points in lists, but that's how it had been and most certainly due to the way lists were done by some moderators in vB. The issue with the 2nd or 3rd linebreak that appeared after the upgrade seems to be gone in all the products I've checked so far. I'll update when I have some more feedback when the moderators start adding new uploads.

Chuck S · August 23rd, 2012, 11:04 AM

enjoy your day.

carsafety · August 23rd, 2012, 01:00 PM

Quote:

Originally Posted by Chuck S

enjoy your day.

Lol well, hopefully whatever it was helps someone else in the future as well. thanks!

Chuck S · August 23rd, 2012, 01:11 PM

Enjoy playing with the new plugin system

I setup forums so users can share with others there plugin ideas etc.

carsafety · December 9th, 2012, 10:00 AM

Quote:

Originally Posted by Chuck S

enjoy your day.

I've just updated to 6.03. Somewhere in this update or one of the previous ones, I'm wondering if the change you made referenced earlier in this thread to remove an extra line break may have been lost. It's also possible the moderators are doing something slightly different with their review uploads than before, but the effect is the same.

For example, In looking at "view source" on a review, it seems that the software is automatically adding two sets of line breaks after each list element, for example:

Code:

Content visible to verified customers only.

Do you happen to remember what file or template this was in so I can possibly remove one of those line breaks as a test? If so, could you direct me where I might find this?

Thanks!

Chuck S · December 9th, 2012, 10:36 AM

Line break where? We should properly add line breaks in comments or descriptions look at the convert_returns function in pp-inc.php

I will have to reread this post but from what I have seen thus far this was never some issue we had in the code as we where able to post the same text without issue so if we need to revisit this discussion let me know. I do not see where we changed anything or recommended changing anything.

Removing one of the break tags in the function I noted might help you

carsafety · December 9th, 2012, 11:08 AM

Quote:

Originally Posted by Chuck S

Line break where? We should properly add line breaks in comments or descriptions look at the convert_returns function in pp-inc.php

I will have to reread this post but from what I have seen thus far this was never some issue we had in the code as we where able to post the same text without issue so if we need to revisit this discussion let me know. I do not see where we changed anything or recommended changing anything.

Removing one of the break tags in the function I noted might help you

Hi-

I don't know what edits you made, but you fixed this issue previously in response to this thread. I'll tinker with that php file you mentioned and see if that resolves it. If you happen to remember what changes you made to fix this previously, please let me know! Unfortunately, you didn't specifiy the exact changes when you made them in response to this thread, so I'm unable to be more specific. Perhaps they were done custom for my site and not included in the general release, so that they are removed when a certain file is overwritten with a new version update or something?

The code I pasted in my last post was how a list created within the editor appears on a "View Source" output when viewing a product upload page in Internet Explorer. Two line breaks are added after each list element, making the spacing between elements unusually large and it makes lists look poor.

Update: In fact, in looking at view source, the content of the product upload has two line breaks after each and every line, making an extra line break everywhere on the page, not just list elements. You just happen to notice it more on list elements because those should normally appear without any line breaks.

Chuck S · December 9th, 2012, 11:48 AM

Have you checked your template showproduct maybe?

http://www.photopost.com/forum/1302294-post18.html

I really do not see any replies from the last discussion where I said I did anything to your site as the discussion on the second page here just say I posted your exact post on my site and it displays fine.

You can send any data for me to look at your site if you want maybe we can find out what your issue is but if we can not replicate it anywhere else hard to post some fix for something we can not break anywhere.