Upgraded from 3.3 to 4.2 now product description is jacked

wacnstac · August 18th, 2009, 03:59 PM

See description here. Can't seem to get it formatted correctly with the advanced editor. Does the advanced editor work?

ThermaCELL Realtree Hardwoods Green Appliance - IndianaSportsman Product Reviews

wacnstac · August 18th, 2009, 04:06 PM

Also is there any way to get an intelligent linefeed in category descriptions that are too long Main Index - IndianaSportsman Product Reviews See the themacell review top left.

Chuck S · August 18th, 2009, 04:39 PM

Are you allowing html in products under admin options in admin?

wacnstac · August 18th, 2009, 06:28 PM

That's too dangerous since we have user gen product reviews. Does HTML need to be enabled to use the advanced editors?

Chuck S · August 18th, 2009, 06:37 PM

well the enhanced editor uses or creates thing in html so you need to set the setting to yes

it is not dangerous because our un_htmlspecialchars function we created only allows certain html tags it does not allow script embed or similar tags.

wacnstac · August 18th, 2009, 06:47 PM

Ok I enabled HTML and re did the product and this is it:
ThermaCELL Realtree Hardwoods Green Appliance - IndianaSportsman Product Reviews

Should be showing the <p> tags IMO.

Chuck S · August 18th, 2009, 07:15 PM

Maybe try chaning this in showproduct.php

Code:

Content visible to verified customers only.

to maybe this

Code:

Content visible to verified customers only.

wacnstac · August 18th, 2009, 10:42 PM

That change didn't make any difference. Is anyone using this version of ReviewPost with the Advanced editor? Also is there anything we can do about the jacked category names below the pictures?

I don't get it. I tried deleting everything switching to the basic editor with and without html and get the same result:

ThermaCELL Realtree Hardwoods Green Appliance - IndianaSportsman Product Reviews

wacnstac · August 18th, 2009, 11:09 PM

Try this..... I had to fix this in 4.1 and obviously the bug fix didn't make it into 4.2. Can I interest you guys in some good issue tracking software

Quote:

if ( $Globals['editor'] != "off" )
{
$desc = un_htmlspecialchars($desc);
if ( VB3_COMMWYSIWYG == "on" ) $desc = un_htmlspecialchars($desc);
$desc = convert_returns(convert_markups($desc));
}
else
{
if ( VB3_COMMWYSIWYG == "on" ) $desc = un_htmlspecialchars(convert_markups($desc));
$desc = convert_returns(convert_markups($desc));
}

Needs to be:

Quote:

if ( VB3_COMMWYSIWYG == "on" ) $desc = un_htmlspecialchars(convert_markups($desc));
else $desc = convert_returns(convert_markups($desc));
if ( $Globals['editor'] != "off" ) $desc = un_htmlspecialchars($desc);

Now is there anything we can do about the jacked alignment of thumbs with long category names?

Chuck S · August 19th, 2009, 08:25 AM

That is essentially what this already is and I already tried the code I posted so not sure what your problem was then

Code:

Content visible to verified customers only.

The only difference is if you run the editor we add an additonal line

$desc = un_htmlspecialchars($desc);

That was already what was in my code here

Code:

Content visible to verified customers only.