PhotoPost Community

PhotoPost Community (http://www.photopost.com/forum/)
-   ReviewPost Installation & Upgrades (http://www.photopost.com/forum/reviewpost-installation-upgrades/)
-   -   Upgraded from 3.3 to 4.2 now product description is jacked (http://www.photopost.com/forum/reviewpost-installation-upgrades/140660-upgraded-3-3-4-2-now-product-description-jacked.html)

wacnstac August 18th, 2009 02:59 PM

Upgraded from 3.3 to 4.2 now product description is jacked
 
See description here. Can't seem to get it formatted correctly with the advanced editor. Does the advanced editor work?


ThermaCELL Realtree Hardwoods Green Appliance - IndianaSportsman Product Reviews

wacnstac August 18th, 2009 03:06 PM

Also is there any way to get an intelligent linefeed in category descriptions that are too long Main Index - IndianaSportsman Product Reviews See the themacell review top left.

Chuck S August 18th, 2009 03:39 PM

Are you allowing html in products under admin options in admin?

wacnstac August 18th, 2009 05:28 PM

That's too dangerous since we have user gen product reviews. Does HTML need to be enabled to use the advanced editors?

Chuck S August 18th, 2009 05:37 PM

well the enhanced editor uses or creates thing in html so you need to set the setting to yes

it is not dangerous because our un_htmlspecialchars function we created only allows certain html tags it does not allow script embed or similar tags.

wacnstac August 18th, 2009 05:47 PM

Ok I enabled HTML and re did the product and this is it:
ThermaCELL Realtree Hardwoods Green Appliance - IndianaSportsman Product Reviews

Should be showing the <p> tags IMO.

Chuck S August 18th, 2009 06:15 PM

Maybe try chaning this in showproduct.php

Code:

Content visible to verified customers only.
to maybe this

Code:

Content visible to verified customers only.

wacnstac August 18th, 2009 09:42 PM

That change didn't make any difference. Is anyone using this version of ReviewPost with the Advanced editor? Also is there anything we can do about the jacked category names below the pictures?

I don't get it. I tried deleting everything switching to the basic editor with and without html and get the same result:

ThermaCELL Realtree Hardwoods Green Appliance - IndianaSportsman Product Reviews

wacnstac August 18th, 2009 10:09 PM

Try this..... I had to fix this in 4.1 and obviously the bug fix didn't make it into 4.2. Can I interest you guys in some good issue tracking software :)

Quote:

if ( $Globals['editor'] != "off" )
{
$desc = un_htmlspecialchars($desc);
if ( VB3_COMMWYSIWYG == "on" ) $desc = un_htmlspecialchars($desc);
$desc = convert_returns(convert_markups($desc));
}
else
{
if ( VB3_COMMWYSIWYG == "on" ) $desc = un_htmlspecialchars(convert_markups($desc));
$desc = convert_returns(convert_markups($desc));
}
Needs to be:

Quote:

if ( VB3_COMMWYSIWYG == "on" ) $desc = un_htmlspecialchars(convert_markups($desc));
else $desc = convert_returns(convert_markups($desc));
if ( $Globals['editor'] != "off" ) $desc = un_htmlspecialchars($desc);
Now is there anything we can do about the jacked alignment of thumbs with long category names?

Chuck S August 19th, 2009 07:25 AM

That is essentially what this already is and I already tried the code I posted so not sure what your problem was then

Code:

Content visible to verified customers only.
The only difference is if you run the editor we add an additonal line

$desc = un_htmlspecialchars($desc);

That was already what was in my code here

Code:

Content visible to verified customers only.


All times are GMT -5. The time now is 03:12 PM.

Powered by vBulletin® Version 3.8.1
Copyright ©2000 - 2013, Jelsoft Enterprises Ltd.
Search Engine Friendly URLs by vBSEO 3.2.0


1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97