Problem after Site Move - Page 2

KenDude · November 9th, 2008, 08:44 PM

BTW I just looked in my physical directory via ftp for signaturepics and every single image in that directory is a .gif file. I'll go check the database values as I think I see which table it is from your code snippet.

KenDude · November 9th, 2008, 08:56 PM

Ok I'm not sure I am looking at the right table, but there is a table in my database called "sigpic" it has a field in it called "filename" and most every entry in that field is a .jpg (saw a couple of .png).

So what I suspect "may" be happening is that when you check the checkbox to tell it to allow animated signatures that even if someone uploads a .jpg it converts the file and stores it as a .gif in the filesystem on the server. But that must mean that vbulletin code knows to change the extension at display time. Have you looked through the postbit code to see where it is grabbing the sigpic from and if it is doing something to the extension on the fly? I concur the filename variable in the sigpic table is almost always a .jpg but the actual file in the filesystem is a .gif on the server.

Chuck S · November 10th, 2008, 09:16 AM

I have not torn apart the entire sigpic thing in vb.

I just wrote up the code to actually display them based on the data that I saw. I am not sure what option your talking about animated signatures I dont see that in the user profile signature box? If all your signatures are going to be gif extentions then you could alter our coding very easy to use a gif extention. I would definately need to look at things alot deeper though.

KenDude · November 10th, 2008, 09:55 AM

The option for animated signatures is in the Usergroups Manager, just pull up a usergroup and scroll down it will say:

Can Upload Images for Signature Yes No

Can Upload Animated GIF for Signature Yes No

Signature Image Maximum Width (pixels)

Signature Image Maximum Height (pixels)

Signature Image Maximum Filesize (bytes)

Mine are both set to YES for all usergroups on my site.

It is my "assumption" that is you have the first one set to yes that vb is somehow converting all images to GIF format when storing them on the server hard drive in the file system. I have asked about this in the following topic on vbulletin.com:

Signature Pic - SigPic - use of JPG vs. GIF - vBulletin Community Forum

Can you tell me which table and which field you are reading the fileame value from for reviewpost? Is it table=sigpic value=filename or something else?

Chuck S · November 10th, 2008, 10:15 AM

Well I am not sure what this option is called in the vb database. If I know what that option is called I may be able to query it and if it is set to yes and all your sigpics will be gif then code something in.

I got it coded to use both database and filesystem storage that is easy. It is just figuring out that animated setting. I myself cant even find where this is in the vb admin area.

KenDude · November 10th, 2008, 12:21 PM

Quote:

Originally Posted by Chuck S

Well I am not sure what this option is called in the vb database. If I know what that option is called I may be able to query it and if it is set to yes and all your sigpics will be gif then code something in.

I got it coded to use both database and filesystem storage that is easy. It is just figuring out that animated setting. I myself cant even find where this is in the vb admin area.

Yes, that was my thought, if that option is selected as yes, then make all filenames end in .gif. I have no idea in the vb config where that option is stored, other than it might be stored in whatever table stores information about the usergroups, since you could have one usergroup using it, but another not using it, it isn't a "universal" choice for the whole site. Is there a table that stores usergroup config options?

If it is just easier for you to hardcode .gif in the vb3.php file and produce 2 versions one for .jpg and one for .gif and just have me use the hardcoded .gif version I am happy with that until a more universal/permanent fix can be found.

Chuck S · November 10th, 2008, 03:31 PM

You can download the reviewpost and classifieds builds and see where your at works from my side.

KenDude · November 10th, 2008, 04:45 PM

Quote:

Originally Posted by Chuck S

You can download the reviewpost and classifieds builds and see where your at works from my side.

You changed something today then? You know it might be faster if you just emailed me the changed file(s)....

Chuck S · November 10th, 2008, 04:52 PM

You can download the builds and upload the changed files.

KenDude · November 10th, 2008, 07:21 PM

Chuck,
As an FYI check that topic thread over on vbulletin.com they said that the files ALWAYS are converted to .GIF files and that they follow the pattern of

"sigpicUSER#_IMAGE#"

So for example if user #300 on your site uploaded his 4th signature picture attempt the file would be stored as "sigpic300_4.gif" but ALWAYS as a .gif file, so sounds like you could hardcode that...

KenDude · November 10th, 2008, 07:25 PM

Ok when I downloaded all files had the same time/date stamp so I couldn't see what was new in 4.04 (is that in the docs? forgot to look) but anyway copied over just the vb3.php file into the forums directory and Tada it works!

Kudos! Now I need to try the Classifieds and VBgallery, were those updated as well today?

Chuck S · November 10th, 2008, 09:36 PM

No idea about vbgallery

Classifieds was updated yes.

KenDude · November 11th, 2008, 12:24 AM

Ok I got the list of changed files from the changelog.txt file, they were listed as the following:

adm-misc.php
install.php
pp-inc.php
showfeature.php
showframe.php
showproduct.php

forums/vb3.php
forums/mybb.php
forums/fusion.php
forums/smf2.php

(although the pp-inc file was identical to what I had from 4.03...)

Off to go work on the classifieds now...

KenDude · November 11th, 2008, 12:38 AM

Ah man I should have quit while I was ahead. I wanted to make sure I got all of the updated files, not just the vb3.php file and so I copied up the rest of the new files and now it doesn't work again!!!

Ugh! Something in one of those other files broke it!

For example in this review:
Catback Exhaust System - My Articles

Look at my sigpic, it is trying to display http://www.caymanclub.net/signaturepics/sigpic3_4.gif

The problem is that my signature is actually:
http://www.caymanclub.net/signaturepics/sigpic3_7.gif

So something isn't right now in the math of how it figures the number of instances of uploads of the sigpic images and it was something in one of the other files that broke this... ugh!

Of course I didn't do a backup of those file, I just trusted that they will work. I am going to go to my 4.03 download and put the 4.03 file versions back on my server and just use the 4.04 version of vb3.php until the problem is tracked down.

KenDude · November 11th, 2008, 12:52 AM

Ok here is another example of where it works and doesn't work in the same review. Here is the review/article link first:

Catback Exhaust (686006_1705) Installed by TRG - My Articles

Scroll down until you get to the 4th comment left by KS-CS, his SigPic is showing up fine, the file is http://www.caymanclub.net/signaturep...gpic5646_4.gif

Scroll down 2 more comments to the one from grrlsix, her sigpic shows up as a red x. It is trying to show http://www.caymanclub.net/signaturep...gpic4859_4.gif when in fact her correct sigpic is here:
http://www.caymanclub.net/signaturep...gpic4859_3.gif

In other words the numerical value is a 3 instead of a 4, the code is trying to display an iteration 1 higher than what it truly is, whereas in my instance it is trying to show a suffix that is 3 less than the actual true value (4 instead of 7).

I loaded back the 4.04 files and confirmed the problem exists in 4.04, reverting back to the 4.03 files didn't fix it, I must simply have missed this earlier because I saw the one working from KS-CS.

Anyway you are getting closer, just not perfect yet!

Chuck S · November 11th, 2008, 05:57 AM

You might just need to grab a coffee download the build and try the files again.

KenDude · November 11th, 2008, 09:50 AM

Chuck did you change them since yesterday? I copied over the 4.04 files 3 times to check and see if they work and for some signature images they do and for some they do not. My site is running the 4.04 version, or are you saying you updated the files again this morning?

Chuck S · November 11th, 2008, 09:51 AM

I made sure they are what I posted. They seem to work fine to me.

KenDude · November 11th, 2008, 10:11 AM

Ok the vb3.php file in last nights 4.04 version was 22,945 bytes, the one in ths morning's 4.04 version is 22,303 bytes. I just uploaded the files again and now all of the signatures appear to work from the articles I looked at so far. I will continue to check them. I also noted that the SF2 file was 3 bytes different as well although I don't believe it has anything to do with the sigpics does it?

KenDude · November 11th, 2008, 10:16 AM

Yep found one that doesn't work, see this review:

Wall mount wheel hangers - My Articles

His sig pic in his reponse doesn't work, although the link shown there is correct. his signature pic is at:

http://www.caymanclub.net/signaturep...pic3437_32.gif as confirmed in our forums his sigpic shows up.

this article shows his sigpic link as http://www.caymanclub.net/signaturep...pic3437_32.gif which appears to be identical but it isn't rendering for some reason.

Could it be that his suffix is 32 and that is double digits where everyone else's has been single digits?