RP 4.03 issues

Zigw · September 29th, 2008, 01:04 PM

Just upgraded to RP 4.03 (from 3.32)

I noticed an old bug is back: HTML is interpreted in user reviews even with admin option set to No.

Other issues so far:

1. When I enable category cache, it says I don't have permissions to view any of my categories, even when admin. When I disable category cache, problem goes away.

2. I get the following PHP error in my error log:

[Sat Sep 27 16:19:37 2008] [error] PHP Warning: mysql_fetch_row(): supplied argument is not a valid MySQL result resource in /home/www/html/reviews/pp-inc.php on line 3764

This is the pp-inc.php code starting at 3764:

Code:

Content visible to verified customers only.

I've just started testing, so I may find more issues.

Thanks

Chuck S · September 29th, 2008, 07:15 PM

I will look and see if I can confirm any of those.

The last one looks like you may be missing an upgrade so what field is your iponline table missing?

Zigw · September 29th, 2008, 08:19 PM

Thanks. I haven't seen that PHP error again since doing the upgrade, so wondering if it happened during the upgrade process. Possible?

Chuck S · September 29th, 2008, 11:03 PM

Yes indeed that is possible if its an email error.

Zigw · October 1st, 2008, 10:05 AM

Hi Chuck,

Have you been able to confirm the HTML in reviews issue, or the category cache issue?

I ran into another issue today. We have Allow Edit Reviews enabled for registered users in the usergroup permissions, but the Edit Review option or button doesn't appear for registered users, so a registered user can't edit his own review. Only admin can edit it.

Also, the IP address when viewing a review as admin appears twice. In RP 3.32, it appears only once.

Thanks,
Zig

Chuck S · October 1st, 2008, 06:55 PM

I dont know my cache works so I would need to investigate that some but most anything else redownload the build and reupload showproduct.php

Zigw · October 2nd, 2008, 10:44 AM

Quote:

Originally Posted by Chuck S

I dont know my cache works so I would need to investigate that some but most anything else redownload the build and reupload showproduct.php

Okay, I've downloaded the new build and installed the new showproduct.php. It is no longer interpreting HTML, so it looks like that's fixed.

HTML is still however being interpreted in Reviews listed from the Profile page (member.php).

Here are the issues I've found with member.php so far:

1. I can't see any profiles. Clicking on Profile results in an empty, black frame.
2. When clicking on Reviews link, the reviews contain interpreted HTML.
3. Reviews are not shown for registered users with reviews. It only seems to work for admin.
4. Reviews listed when admin are not limited to reviews posted by admin, it seems to list all the latest ones posted by any user.
5. We've disabled product uploads for registered users, yet there is a Products link shown for registered users.

Thanks.

Chuck S · October 2nd, 2008, 09:22 PM

1. You need to make sure in registration options you are prompting to do additional info and the user must edit their profile for something to show otherwise you must click a link on the left to show something

2. I would have to look at that but thats not necessarily something that was ever part of the original structure of the feature your talking about here the member page is actually something from photopost pro ported over

3. I will take a look

4. I will take a look

5. There will be a link there not really a bug having a link there and its designed to be there regardless whether they have products or not

Zigw · October 3rd, 2008, 09:37 AM

Quote:

Originally Posted by Chuck S

1. You need to make sure in registration options you are prompting to do additional info and the user must edit their profile for something to show otherwise you must click a link on the left to show something

2. I would have to look at that but thats not necessarily something that was ever part of the original structure of the feature your talking about here the member page is actually something from photopost pro ported over

3. I will take a look

4. I will take a look

5. There will be a link there not really a bug having a link there and its designed to be there regardless whether they have products or not

1. I've done that. The profile still doesn't show, even if I click on the Profile link. The link has the same URL as the member page, so no surprise. In RP 3.x, the profile view would at least show the user's name, date registered, number of posts and so on. Even after adding additional info, it doesn't show on the member page in RP 4.03 (though I do see a link to the user's homepage under their reviews now).

2. This is a security issue even if it wasn't meant to be a feature in RP, so I think HTML viewing needs to be addressed.

3, 4. Thanks.

5. I guess we can edit the template to remove that link, as we don't allow user products, so it'd be empty for all users except admin.

Thanks.

Chuck S · October 3rd, 2008, 06:19 PM

Member Profile - Reeftalk Reviews

If I fill out a profile it shows otherwise if you do not fill out a profile there is nothing to display. I think your just not use to the profile system as it has changed alot. Its based off photopost pro.

anything else I can look at as stated on 2 3 4

Zigw · October 3rd, 2008, 09:51 PM

Well that's odd. We don't see anything when we click on Profile or Reviews for a registered user with a profile and reviews. Only Statistics and Watch List show for us. And we haven't modified member.php. Any ideas? Did any other files change in yesterday's build other than showproduct.php?

Chuck S · October 4th, 2008, 06:30 AM

RP 4.03 issues

Did you make sure number 1 is followed and you edited the profile? You need to prompt for additional info.

Zigw · October 4th, 2008, 08:23 PM

Quote:

Originally Posted by Chuck S

RP 4.03 issues

Did you make sure number 1 is followed and you edited the profile? You need to prompt for additional info.

Ah, I see. You said "...otherwise you must click a link on the left to show something", so I didn't realize I must enable the additional info prompt. Now that it's enabled, I do see the extra profile fields being displayed in the Profile.

I still don't see reviews for registered users though. Just when viewing admin's reviews, and then reviews from all users appear (with HTML). And in the Statistics page, there is a link to Forum Profile, but we don't have the built-in Forum enabled. It seems to point to the regular user Profile though.

Chuck S · October 4th, 2008, 09:33 PM

yeah I am looking into the couple issues I see are not right and will let you know about those but anything else just seems to be confusion on the new profile system since its vastly different.

Chuck S · October 5th, 2008, 07:57 PM

The latest review on member products are not limited to just admin anyway any issues I see with the code are corrected

redownload the build upload profile template member.php and the english.php language file

Zigw · October 25th, 2008, 10:21 AM

After uploading the new profile.tmpl , member.php and english.php files, the correct reviews seem to be displaying now, but I'm still seeing HTML being evaluated in the "Most Recently Made Reviews" and "Recent Comments on Member Products" frames of the user profile.

Chuck S · October 25th, 2008, 07:04 PM

Line 591 of member.php try this?

Code:

Content visible to verified customers only.

change to

Code:

Content visible to verified customers only.

Zigw · October 25th, 2008, 08:55 PM

That line change didn't seem to work. Still seeing HTML being evaluated in the profile (but not in the actual reviews in showproduct, so I know it's not a configuration issue).

Chuck S · October 25th, 2008, 09:54 PM

Do you have allow html set to yes?

Zigw · October 25th, 2008, 11:36 PM

It is set to No. That's why it doesn't show in showproduct.