RP 4.03 issues - Page 2

Chuck S · October 26th, 2008, 10:37 AM

Replace the lines noted above twice with this

Code:

Content visible to verified customers only.

Zigw · October 29th, 2008, 08:27 PM

Not sure if I understand. I tried replacing:

Code:

Content visible to verified customers only.

with:

Code:

Content visible to verified customers only.

for both occurrences (line ~592 and again at around line 646), but it's still showing HTML (bullet lists for instance).

Chuck S · October 30th, 2008, 06:06 AM

If its still executing html then something is wrong with your edits and you can feel free to post a link for us to look at. remember even with html off you will still see html its just not going to be executed meaning no link or image is actually shown.

Zigw · October 30th, 2008, 09:10 AM

Sorry, we haven't gone live with RP4.03 because of the security issues, and our test site is not available to the public. How about you fix member.php and update the build, so I can just upload it? That will remove any issues with my editing.

Thanks.

Chuck S · October 30th, 2008, 09:59 AM

Okay will let you know when I do that

Zigw · November 7th, 2008, 04:23 PM

Any idea when a new version of member.php will be available? It's been a week.

Thanks!

Chuck S · November 8th, 2008, 10:20 AM

Try the download now.

Zigw · November 11th, 2008, 01:36 PM

Quote:

Originally Posted by Chuck S

Try the download now.

Do I download RP 4.04? According to the change log, member.php has not been changed from 4.03.

Chuck S · November 11th, 2008, 01:50 PM

Reviewpost 4.04 Released * 11-10-2008

yes my overlook on the announcement member.php did change.

Zigw · November 11th, 2008, 02:03 PM

Quote:

Originally Posted by Chuck S

Reviewpost 4.04 Released * 11-10-2008

yes my overlook on the announcement member.php did change.

Hmm, I uploaded just the RP 4.04 member.php, but I'm still seeing HTML being interpreted. What other files are related to this particular issue?

Thanks

Chuck S · November 11th, 2008, 03:49 PM

Member Profile - Reeftalk Reviews

I am not sure where you think its interpreted in the reviews. We may display it but its not interpreted

2paclogo.gif - Reeftalk Reviews

Then on the profile page as my previous post shows we strip the html tags

Zigw · November 11th, 2008, 06:26 PM

Interesting. Seems to work for you, but not for me. What version of PHP are you running? Any other files involved?

Chuck S · November 11th, 2008, 08:08 PM

No other files involved.

I am using PHP 5 on my server but that should not have anything to do with it.

You can also simply try this

Code:

Content visible to verified customers only.

change to this as its simply the same thing strip html tags

Code:

Content visible to verified customers only.

Zigw · November 11th, 2008, 08:30 PM

I tried your <img src="http://www.reeftalk.com/ads/paclogo.gif" border="0" alt="premiumaquatics" title="premiumaquatics" vspace="4" hspace="4" /> example code, and it doesn't show in our profile view either. However, I see the actual code in both of our showproduct views, and I was expecting to see the code in the profile view as well.

I have HTML test cases with bulleted lists, bolding, etc. The HTML code shows in showproduct, but is being interpreted in profile view of the same reviews. Perhaps you should try similar on your site.

Ah, I just tried it on your site, and it's being interpreted in the profile view: http://www.reeftalk.com/reviews/memb...id=1&protype=2 but not in the showproduct view: http://www.reeftalk.com/reviews/show...php?product=52

Chuck S · November 11th, 2008, 08:38 PM

Just for the record though only thing we are trying to stop being printed out be links script img tags anything harmful

We dont care about bold or bullet tags. If you do then remove this line

Code:

Content visible to verified customers only.

Zigw · November 11th, 2008, 08:48 PM

Quote:

Originally Posted by Chuck S

Just for the record though only thing we are trying to stop being printed out be links script img tags anything harmful

We dont care about bold or bullet tags. If you do then remove this line

Code:

Content visible to verified customers only.

Ah. Why would you care about them in showproduct.php, but not in member.php?

Chuck S · November 12th, 2008, 08:07 AM

Showproduct does not do anything to the code actually you see full html printed out just not executable. I could do that on member.php but I choose to do it like we do on showcat.php because we limit the display like on showcat so we dont want to actually break html. I would more keep things in line with showcat because of the limited display. We do not limit anything on showprodcut that is why we dont compare to that script.

Zigw · November 13th, 2008, 09:42 AM

Quote:

Originally Posted by Chuck S

Just for the record though only thing we are trying to stop being printed out be links script img tags anything harmful

We dont care about bold or bullet tags. If you do then remove this line

Code:

Content visible to verified customers only.

Thanks. Removing this line works, though there is a side-effect of the product image not being right-aligned anymore in one case where I had <img src="http://www.reeftalk.com/ads/paclogo.gif" border="0" alt="premiumaquatics" title="premiumaquatics" vspace="4" hspace="4" /> HTML code. It may be the way that code is filtered out.

Chuck S · November 25th, 2008, 07:50 AM

could be which is why we instead on showcat page choose to remove the html in descriptions so as not to break html on a page when you cut a response to a certain length as not to cut into the middle of an html string. This is why I did it the way I did it in member.php.

Zigw · December 13th, 2008, 04:24 PM

I see.

Have another question: In the register screen, the first required field is without a title, so the user doesn't know what to enter. (see attached screen shot).

Looking at the register template file, it's using 'name':
<td class="{$Style['tddetails']}"><b>{$Globals['pp_lang']['name']}:</b></td>

however 'name' is not defined in the english.php file.

Can I just add:

$Globals['pp_lang']['name'] = "Name";

Or are other changes required?