RP 3.3 issues and suggestions - Page 4

Zigw · June 8th, 2006, 01:47 PM

OK, so we understand why the empty quotes - back to the orginal issue. Can you delete all reviews at once from a particular user in your install? It doesn't seem to matter if the user has a product upload or not for our install. Have you tried posting reviews as a new user without posting products and then deleting them from the new user's profile?

Quote:

Originally Posted by Chuck S

Yep it gets the username from the query when it returns the product uploads.

Chuck S · June 8th, 2006, 01:50 PM

Well the way it works your only issue is it could not get the name. UID is passed so if you check the box it should delete the reviews as the query is sound.

Code:

Content visible to verified customers only.

Zigw · June 8th, 2006, 02:03 PM

Well, I wonder why it doesn't work for us. Should I remove that 'delcomments' => STRING, patch, or is that definately needed?

Another possible side-effect of not having the uid passed when a user has no product uploads is this message when I try to unsubscribe from a product or category from the user's profile:

"Script not called correctly. Navigate to a specific product, then click on the edit link. "

But unsubscribing this way from a user's profile still seems to work.

Quote:

Originally Posted by Chuck S

Well the way it works your only issue is it could not get the name. UID is passed so if you check the box it should delete the reviews as the query is sound.

Code:

Content visible to verified customers only.

WB · June 8th, 2006, 03:21 PM

Chuck:

Odd that the uid doesn't seem to be passing for us.

Coming at the main issue from a different perspective, we can likely work around it by doing the equivalent in the db itself. Just want to make sure that there isn't any associated data that we'd need to clean up.

So for example, let's say that we wanted to get rid of all of the reviews posted by user X across all products.

We'd pop into the reviews table (via phpMyAdmin or something similar) and search for everything with the username X in that table.

That would pull back all the relevant reviews and then we could delete them all at the same time.

If we did it that way, would that work? Or would we need to delete any other keyed or associated data so that RP would be okay?

The query seems to only delete the reviews from said user so I think that would do it.

We don't expect to have to use the option much but would like to make sure that we can get rid of all reviews at once JIC.

Thanks.

Chuck S · June 8th, 2006, 06:22 PM

The form tag needed to be moved up single html issue. I also changed the query not to count on the username coming from the products table so in adm-misc.php you can use this

Code:

Content visible to verified customers only.

Zigw · June 8th, 2006, 08:58 PM

Chuck,

After adding another } at the end of this code, it seems to work! I get both the username in quotes, and all the reviews by that user are deleted. The only problems I see so far are:

1. At the category index level, the numbers in the "Reviews" column are not updated. They are the same as before. For example, it says 8 reviews for a product which now has only 6, as 2 from the user were deleted. Another product says 1 reviews, but when I click on the link, there are no reviews.

2. Product rating averages don't get updated in the product view. However the number of Reviews, Recommended By and Average Purchase Price is updated.

3. In the Admin->General-> Edit User option, the number of posts for the user is still the old number. Not the number of posts that are left (0). We can edit that though.

Zig

Quote:

Originally Posted by Chuck S

The form tag needed to be moved up single html issue. I also changed the query not to count on the username coming from the products table so in adm-misc.php you can use this

Code:

Content visible to verified customers only.

Zigw · June 9th, 2006, 12:03 PM

Chuck,

With RP3.3, without the above bulk user review delete patch, when a user deletes his own review and it is the only review for that product, the Reviews column in that product's category index view shows -1 instead on 0. In the product view, it's correct (0). Can you provide a patch ASAP that fixes this independent from the bulk user review delete patch? Is there a way to manually fix it for now?

Thanks,
Zig

Quote:

Originally Posted by Zigw

Chuck,

After adding another } at the end of this code, it seems to work! I get both the username in quotes, and all the reviews by that user are deleted. The only problems I see so far are:

1. At the category index level, the numbers in the "Reviews" column are not updated. They are the same as before. For example, it says 8 reviews for a product which now has only 6, as 2 from the user were deleted. Another product says 1 reviews, but when I click on the link, there are no reviews.

2. Product rating averages don't get updated in the product view. However the number of Reviews, Recommended By and Average Purchase Price is updated.

3. In the Admin->General-> Edit User option, the number of posts for the user is still the old number. Not the number of posts that are left (0). We can edit that though.

Zig

Chuck S · June 9th, 2006, 12:53 PM

I would have to look into that cause on initial testing from what your saying I dont see an issue but will test some more.

Zigw · June 9th, 2006, 08:16 PM

Should I try the "resync reviews counts on showcat page" in the scan database admin menu? Running it fixed the numbers on the category view on our backup site, but the number of reviews at the top level product gallery is still wrong (old total). I'm a little nervous trying it on our live site.

Quote:

Originally Posted by Chuck S

I would have to look into that cause on initial testing from what your saying I dont see an issue but will test some more.

Zigw · June 29th, 2006, 10:38 PM

Chuck,

We've noticed someone else wanted a way to limit user reviews to 1, and you provided a simple fix. We're going to use that patch too.

I have found a couple of issue with Sidebar Settings: "Under Category Bar - Display Recent Comments and Who's Online Pals". When enabled:

1. The Recent Reviews pod evaluates HTML in reviews, which is a security issue.

2. It seems to display reviews from deleted products. No image is shown, and when you click on the image placeholder, you get an error saying "Product not found in your database!".

Thanks,
Zig

Chuck S · June 30th, 2006, 08:47 AM

Hello

If you delete a product all comments for that product are deleted. At least thats what I show and we update the cache. Whats happens if you turn your cache off?

Code:

Content visible to verified customers only.

As far as recent reviews in index.php just change this line to use convert_markups and not un_htmlspecialchars

Code:

Content visible to verified customers only.

Zigw · June 30th, 2006, 09:51 AM

Hi Chuck,

I don't think it's a cache issue. The product with the review listed in "Recent Reviews" was deleted over a week ago. Turning the cache off doesn't seem to make a difference.

Zig

Chuck S · June 30th, 2006, 10:04 AM

Well where did you delete the ad? Taking a look at the code the reviews are deleted when product is deleted and the cache is updated. At least thats what I am seeing which is why I posted the code above right out of adm-product.php

Zigw · June 30th, 2006, 03:18 PM

It's been a while, but I'm pretty sure I deleted the product from the product view, by ticking the Delete box and submitting as admin. We don't allow user products.

I just tried adding a new product as admin, adding a user review to it and then deleting the product as admin, and that review did get deleted from the Recent Reviews pod, so I don't know what's going on with the old deleted products. Could it have something to do with being deleted before turning on this Recent Reviews feature?

Quote:

Originally Posted by Chuck S

Well where did you delete the ad? Taking a look at the code the reviews are deleted when product is deleted and the cache is updated. At least thats what I am seeing which is why I posted the code above right out of adm-product.php

Chuck S · June 30th, 2006, 04:12 PM

Can not say as reviews should be deleted when a product is deleted.

Zigw · July 5th, 2006, 12:53 PM

Chuck,

I've stubbled upon what looks like a bit of a catch-22 situation when registering with RP 3.3. I registered a new user, but gave a bogus email address, so I never got the regististration confirmantion email. I then went into my new, unregistered user's profile and fixed the email address, which resulted in a New Temporary Password email, and the new password allowed me to login. However, the user is still unregistered and I don't see a way to generate a new registration confirmation email to change his status to registered. Is there a way, or is it by design for security reasons?

Thanks,
Zig