Upgrade RP 3.11 to 3.3: E-mail notification not working

snoopy5 · April 26th, 2006, 08:44 PM

Hi

I just upgraded from Reviewpost 3.11 to 3.3. today. Downloaded today the newest RP version from your site.

Upgrade went without any problems.

If a user now uploads a review and chooses "YES" for e-mail notification, RP does not recognize it. On the product page, there is still the option visible to enable (not disable) the e-mail notification for this product for him.

If the same user then clicks again on the "enable for e-mail notification" below the image, the system accepts it finally by showing now "disable email notification" as the option.

How can I fix this?

Thanks in advance

Chuck S · April 27th, 2006, 09:02 AM

uploadproduct.php try adding in bold?

Code:

Content visible to verified customers only.

snoopy5 · April 27th, 2006, 09:32 AM

Quote:

Originally Posted by Chuck S

uploadproduct.php try adding in bold?

Code:

Content visible to verified customers only.

I used the new tmpl, that you published for my other question. There is no extra6 with the string at all in it (the non-bold-one).

there is also a uploadproduct.tmpl and an uploadproduct.tmpl1 file in my templates folder. Is this by purpose?

Chuck S · April 27th, 2006, 09:46 AM

That line definately exists in uploadproduct.php line 27

snoopy5 · April 27th, 2006, 10:01 AM

sorry, I mixed the tmpl of the other thread with the php file of this thread.

So I found it and made the change. Now I get an error after hitting upload as a user:

"We're sorry, but the system experienced an unrecoverable error. Please try again later."

If I click after that on "Index", The image appears in the category, but e-mail notification still turned off...

Chuck S · April 27th, 2006, 10:07 AM

HMM try to use display errors set to on in admin global options.

snoopy5 · April 27th, 2006, 02:40 PM

Quote:

Originally Posted by Chuck S

HMM try to use display errors set to on in admin global options.

it was already set this way. The result was the error mentioned above.

I did now a totally fresh installation, no upgrade, with a new URL and new database. Installation was successful without any problems.

I inserted the string you mentioned above in "uploadproduct.php"

I then uploaded again as a user an image. If in the upload window, notification is set to yes, the following error (mysql fetch see screenprint) appears at the same time as a success alert.

If I set the notofication to "no" while uploading an image, no error occurs.

Chuck S · April 27th, 2006, 05:04 PM

In image-inc.php at the bottom make sure the query is this.

Code:

Content visible to verified customers only.

snoopy5 · April 28th, 2006, 03:31 AM

Quote:

Originally Posted by Chuck S

In image-inc.php at the bottom make sure the query is this.

Code:

Content visible to verified customers only.

mine was differnt. I post it here:

-------------
if ($notify == "yes") {
$resulta = ppmysql_query("SELECT id FROM {$Globals['rp_db_prefix']}products WHERE userid=$upuserid AND bigimage='$realname'", $link);
list( $productid ) = mysql_fetch_row($resulta);

$resulta = ppmysql_query("INSERT INTO {$Globals['rp_db_prefix']}notify (id,userid,product) values(NULL,$upuserid,$productid)", $link);
------------

But even after I changed the second $resulta to your code, the problem does not go away...

snoopy5 · April 28th, 2006, 03:47 AM

Quote:

Originally Posted by Chuck S

uploadproduct.php try adding in bold?

Code:

Content visible to verified customers only.

One additional question, to avoid confusion:

In the code quotes above, does the word notify has to have quotation marks?

Chuck S · April 28th, 2006, 09:32 AM

yes it does

snoopy5 · April 28th, 2006, 10:30 AM

... I chnaged it, but it does not make any difference. Same error as before...

Chuck S · April 28th, 2006, 10:41 AM

Make sure to edit uploadphoto.php as well and make sure the notify query at the bottom of the file is removed. It does not need to be in uploadphoto and image-inc.

snoopy5 · April 28th, 2006, 11:54 AM

Quote:

Originally Posted by Chuck S

Make sure to edit uploadphoto.php as well and make sure the notify query at the bottom of the file is removed. It does not need to be in uploadphoto and image-inc.

???

There is no uploadphoto.php. Do you mix this now with Photopost?

Chuck S · April 28th, 2006, 12:38 PM

uploadproduct.php

snoopy5 · April 28th, 2006, 12:49 PM

mmmh, but this does not work...

1. in uploadproduct.php Ihave added this 'notify' => STRING as advised

2. in image-inc.php, almost at the buttom, I have now this:

-------
if ($notify == "yes") {
$resulta = ppmysql_query("SELECT id FROM {$Globals['rp_db_prefix']}products WHERE userid=$upuserid AND bigimage='$realname'", $link);
list( $productid ) = mysql_fetch_row($resulta);

$resulta = ppmysql_query("INSERT INTO {$Globals['rp_db_prefix']}notify (id,userid,product) values(NULL,'{$User['userid']}',$lastproductid)", $link);
}
}
----------------

But it does not work. Same error as before...

Chuck S · April 28th, 2006, 01:16 PM

Well if notify is being declared in uploadproduct.php and image-inc.php looks like this it definately works. I have tested this before posting here.

Code:

Content visible to verified customers only.

Notify would have to be passed as yes to write the query to the notify table.

snoopy5 · April 28th, 2006, 01:42 PM

Quote:

Originally Posted by Chuck S

Well if notify is being declared in uploadproduct.php and image-inc.php looks like this it definately works. I have tested this before posting here.

Code:

Content visible to verified customers only.

Notify would have to be passed as yes to write the query to the notify table.

Chuck, but the code now is something totally different, than discussed before

There have been 2 different $resulta code strings in the original image-inc.php close to the buttom. I always changed only the second one, since the second one was the one that you quotes to change (see your post Yesterday 09:04 PM)

So now I deleted BOTH $resulta at the buttom of the image-inc.php file and inserted instead only the ONE string you showed in your last posting.

Anyway, now it works...

Chuck S · April 28th, 2006, 02:05 PM

The query is not something different though. The query I posted to replace is exactly the same as posted way up in this thread. I just removed the first query cause it did nothing and has no bearing on the issue since $productid was not being used anywhere. I would state you issue had to do with notify not being encapsulated.