Upgrade v2.9 to v3.11 - & is now being shown as &amp

criscokid · November 16th, 2005, 01:48 PM

In upgrading Reviewpost from v2.9 to v3.11 I 've noticed that the line spacing problem has been sorted where an extra line was being thrown in at the end of every paragraph or carriage return.

A new problem is that & is now being shown as & and " as "

I'll have to look for some examples of this problem as I've been going through each product and changing all instances of & to and.

The problem is that one of my customfields is for a URL that always an & - the problem is that since the upgrade ReviewPost is rewriting the & to &amp in the URL. Take a look at http://scene-out.com/party/showproduct.php?product=89 and click on the 'Find it on the map' link.

Chuck S · November 16th, 2005, 02:05 PM

What happens if you turn html on in descriptions?

criscokid · November 16th, 2005, 02:45 PM

Setting 'Allow HTML in Product Fields?' to 'yes' fixes the problem put creates another problem... when using BBcode in the product descruiption causes the BBcode text to be displayed rather than the formated link the BBcode is supposed to create.

Chuck S · November 16th, 2005, 03:58 PM

try this then in showproduct.php

if ($Globals['allowhtml'] == "yes" ) $desc = un_htmlspecialchars( $desc );
else $desc = convert_markups( $desc );

would become

$desc = convert_markups( un_htmlspecialchars( $desc ) );

criscokid · November 16th, 2005, 06:19 PM

Thanks Chuck - that solves the problem providing 'Allow HTML in Product Fields?' is set to 'yes'.

criscokid · June 11th, 2006, 06:50 PM

Upgrading to ReviewPost 3.3 I can't get the 'additional fields' to show data formatted with BBcodes - when using BBcode the actutal BBcode is displayed rather than nicely formated text.

Is it possible to use some sort of control character to force a line break in the data I put into an 'additional field'?

Chuck S · June 11th, 2006, 07:16 PM

How about in showproduct.php this line in bold

Code:

Content visible to verified customers only.

criscokid · June 12th, 2006, 04:27 AM

No change unfortunately

Chuck S · June 12th, 2006, 12:59 PM

it definately works. Remember this was the change for product extra fields. If its review extra fields you need to change the same type of line for the extra fields in reviews as well to add convert_markups

Is it reviews your talking about not product extras?

criscokid · June 12th, 2006, 01:56 PM

Quote:

Originally Posted by Chuck S

Is it reviews your talking about not product extras?

It's the product extras (not review/comment extras).

Chuck S · June 12th, 2006, 02:27 PM

well here is an explicit example the code posted works

http://www.reeftalk.com/reviews/show...p/product/1864

criscokid · June 12th, 2006, 04:44 PM

What else do you recommend I check to try get it working?

Chuck S · June 12th, 2006, 05:57 PM

make sure you doing the exact edit to showproduct.php that I have provided.

criscokid · June 12th, 2006, 06:22 PM

I read your line "How about in showproduct.php this line in bold"
and added the 'bold code' it in as an extra line instead of replacing the line. At least I've got that sorted now

Next problem: In the productextra fields if I enter a ' I get \' being displayed.

And a question: Is it possible to use some sort of control character to force a line break in the data I put into a 'product extra' fields?

Chuck S · June 12th, 2006, 06:30 PM

If the line you changed is the line in bold in showproduct.php bbcode definately displays

I would have to do testing on slash issues.

criscokid · June 12th, 2006, 06:54 PM

Is it possible to use some sort of line break or control character to force a line break in the data I put into a 'product extra' fields?

Chuck S · June 12th, 2006, 07:31 PM

In a text box? NO

criscokid · June 13th, 2006, 06:49 PM

One of my 'product extra' fields is for a URL that always an & - the problem is that since the upgrade ReviewPost is rewriting the & to & in the URL.

Chuck S · June 13th, 2006, 07:20 PM

I am using a url in the box fine so please post a link and a test login

http://www.reeftalk.com/reviews/show...p?product=1865

amp works fine in a url and there is not much we can do since we need to call convert_markups to convert markup on those fields. Now its the lesser of two evils here

Now I am talking about 3.3 here so you might want to upgrade if your on a n old version.

criscokid · June 14th, 2006, 04:44 AM

I experienced the same problem when I upgraded RP2.9 to RP3.11 - see the first post of this thread.

I'm doing this on a test site at the moment - I'd need to move it to a public site for you to be able to login.
Correct format: http://www.streetmap.co.uk/streetmap...180350&A=Y&Z=1
From RP extra field: http://www.streetmap.co.uk/streetmap...mp;A=Y&Z=1

The first URL is a 'good URL', the second URL is what RP is formatting the URL as when it's put into an extra field. If you click on the second link you'll see that it's not working.