No spaces at all in reviews(FIXED)

[fonzerelli_79]

this issue has already been raised at this thread

New line chars removed?

though it has not been resolved

all reviews in the standard installation are crunched together - ie no spaces or paragraphs

it makes it very hard for visitors to read reviews

could someone please look into this

thank you

kevin

[Arnie]

Just to add my 2p too, please do look into this as it is a massive oversight.

[fonzerelli_79]

could someone please look into this

this is a major issue for me and im sure other members as well

i have purchased both reviewpost and photopost for my forums and im looking to do the same with another forum i own. Whilst i love the software, im very dissapointed with the lack of support on this issue

errors like this need to be addressed

[Arnie]

At this rate I'll be looking into rewriting the text parsing code myself and posting it here. I too am somewhat disappointed by the support for a paid for product. The recent security alerts combined with the slow fixes is also worrying.

I take it that all copies of ReviewPost are currently at risk from the published risk that PhotoPost was open to? That I'm not happy about. I'd prefer to at least see full disclosure so that those of us that are PHP savvy could to fix it ourselves.

[Chuck S]

This function here writes two line breaks everytime I post a line break

function convert_returns( $convert_returns ) {
$convert_returns = str_replace( "\n\r\n", "<br /><br />", $convert_returns);
$convert_returns = str_replace( "\r", "<br />", $convert_returns);

return ($convert_returns);
}

Your telling me line breaks are not formed? I show they are on my install

This is the code in showproduct for comments that builds the line breaks

$reviewtextline = convert_markups(stripslashes($reviewtextline));
if ( VB3_ENHANCEDINT != "on" ) $reviewtext[$itemnum] = convert_returns($reviewtextline);


If your running vb3 it is disabled as all vb3 users where complaining there where too much space between lines but I show convert_returns is used.

[fonzerelli_79]

set Do you want to enable the vB3 Enhanced features which use vB3 controls in ReviewPost? to Yes

[Chuck S]

Okay well then line breaks will not be used. It will use whatever VB WYSIWYG controls you have set.

You can always change this line

if ( VB3_ENHANCEDINT != "on" ) $reviewtext[$itemnum] = convert_returns($reviewtextline);

to this to force line breaks in a vb3 environment

$reviewtext[$itemnum] = convert_returns($reviewtextline);

[Arnie]

I've just checked the code here. The linebreaks are being stored in the database properly as when you go to re-edit a post they are there, however they are not being replaced for the display routine when you go to view a review. The linebreaks and spaces are just there in the plain HTML and not replaced with the usual BR tags.

For the record I am using ReviewPost in standalone config but using my IP2 userbase.

[Arnie]

Well here's one problem:

Content visible to verified customers only.

(~ lines 483-485 showproduct.php)

The third line is run even if the second IF routine runs, which nulls the second line replacing $reviewtext[$itemnum] with the unformatted text regardless. Basically the third line needs to be in the form of an ELSE statement (or just commented out if you do't use VB), or if ( VB3_ENHANCEDINT != "on" ) $reviewtext[$itemnum] = convert_returns($reviewtextline); is replaced with "if ( VB3_ENHANCEDINT != "on" ) $reviewtextline = convert_returns($reviewtextline);".

Currently when secondline is run, and $reviewtext[$itemnum] is replaced with the correctly formatted text, but then on the next line it's replaced with the unformatted string regardless.

Omegatron: There is no way that if your code is the same as the above (you even quoted it) and you are running RP with IP2 in a test environment that line breaks will work at all. I'm somewhat suspect that you've even tested this problem yourself? If a bug is reported here do you actually test a simulation deployment?

...anyway as I promised I'd do bug is now fixed chaps, just modify line 484/5 in showproduct as I described and it'll then correctly format newline chars in posted replies.

A correct code solution is:

Content visible to verified customers only.

[Chuck S]

Try this

Content visible to verified customers only.

[Arnie]

Methinks I already suggested that and pointed out that that solution works as well.

[Chuck S]

Right!

However look at your code it is not what I posted. You do not have an else statement in there. My code is different as it has the else and I have verified this as the fix so I posted the correct code so others could use it until such time the developer releases it into the code which affects all our products.

Your fix is right on however it is our policy to post the actual code for users to copy and paste to make it easy on em.