Add fields to the review display?

[Jeremy]

I want to add fields for manufacturer contact information, company webpage & some other fields to the reviews. I think in classifieds you can do this via the menus? Can you do this via admin menu in reviewpost?

[Jeremy]

anyone?

[Chuck S]

Jeremy

You can add in Admin => Edit Categories extra fields so when you upload products you can fill those in like company webpage etc

[Jeremy]

ahh... thats right. I knew it was somewhere.

Sorry, I'm suffering from adminesia right now.

Digging through too many scripts lately.

[Chuck S]

LOL No problem thats what we are here for

[Jeremy]

Hmmm... can't do carriage returns in these fields.

I tried with <br> (and HTML on) I tried with &#13;


hum.

[Chuck S]

Nope they are not html boxes although they should work for it However its a simple input box with a 50 character limit

<input type=\"text\" name=\"extra1-$id\" value=\"$extra1\" size=\"50\" class=\"{$Style['bginput']}\">

[Jeremy]

must be something to do with one of our earlier fixes/patches sanitizing the input.

I'll have to investigate tomorrow when I have more time.

[Chuck S]

<br /> works fine from what I see just remember the input field is max character 50 you can change that though

[Jeremy]

This still isn't working.

I'm sure it has something to do with the other fixes you gave me.

I have HTML enabled in product fields through the admin.

<br> doesn't work, <br /> doesn't work either


You might review these threads:

Description field does not like double quotes & more...(FIXED)

When ALLOW HTML = ON , carriage return is stripped.(FIXED)


What a mess.

[Jeremy]

Ok here is what I have ~ showproduct.php:

// if ($Globals['allowhtml'] == "yes" ) $desc = un_htmlspecialchars( $desc );
// else $desc = convert_markups( $desc );
// rm'd the 2 above, added the one below
// $desc = convert_markups( un_htmlspecialchars( $desc ) );
// then rm'd to add this instead:
// $desc = un_htmlspecialchars( $desc );

// now trying this...
if ($Globals['allowhtml'] == "yes" || VB3_ENHANCEDINT == "on" ) $desc = un_htmlspecialchars( $desc );
$desc = convert_markups( $desc );
if ( VB3_ENHANCEDINT != "on" ) $desc = convert_returns( $desc );


$extra1 = convert_markups( $extra1 ); $extra1 = convert_returns( $extra1 );
$extra2 = convert_markups( $extra2 ); $extra2 = convert_returns( $extra2 );
$extra3 = convert_markups( $extra3 ); $extra3 = convert_returns( $extra3 );
$extra4 = convert_markups( $extra4 ); $extra4 = convert_returns( $extra4 );
$extra5 = convert_markups( $extra5 ); $extra5 = convert_returns( $extra5 );
$extra6 = convert_markups( $extra6 ); $extra6 = convert_returns( $extra6 );

if ($Globals['allowhtml'] == "yes" ) $extra1 = un_htmlspecialchars($extra1);
if ($Globals['allowhtml'] == "yes" ) $extra2 = un_htmlspecialchars($extra2);
if ($Globals['allowhtml'] == "yes" ) $extra3 = un_htmlspecialchars($extra3);
if ($Globals['allowhtml'] == "yes" ) $extra4 = un_htmlspecialchars($extra4);
if ($Globals['allowhtml'] == "yes" ) $extra5 = un_htmlspecialchars($extra5);
if ($Globals['allowhtml'] == "yes" ) $extra6 = un_htmlspecialchars($extra6);



Btw, the <br> <br /> isn't working in the description area either (the problem isn't limited to just the extraX fields) - but HEY, the " shows properly now. LOL

[Chuck S]

Jeremy

Your talking about html where I thought the category box for the name?

Okay in showproduct.php this is what the code block should look like. convert_returns and un_htmlspecialchars dont play nice together

Content visible to verified customers only.

[Jeremy]

Is that going in the next release?


Are you sure that last block is right?

if ($Globals['allowhtml'] == "no" ) $extra1 = convert_markups( $extra1 ); $extra1 = convert_returns( $extra1 );

[Jeremy]

ok I tried it....

(with HTML on)....

Now it stripped the BB Code, <BR> & <BR /> works in extras, but still not in description. BB code works in description (but not in extras)


(With HTML off)

in desc: BB Code works, <br> <br />does not

in extras: neither BB code or <br /> <br> work (they get escaped out and DISPLAYED literally as &lt; &brgt; etc.

[Chuck S]

Like I said html and bbcode dont play nice together.

I would think this is what I am going to include. You either use html or bbcode

Content visible to verified customers only.

[Jeremy]

Can you tell me the following, so myself, you, and your customers can all be on the same page here....


With HTML IN PRODUCT DESCRIPTIONS "YES"

- Should BB/VBulletin Code be allowed or disallowed?
Example: Bold: bold Italics: italics (Using square brackets)

- Should " and & be allowed to be DISPLAYED? (not executed)
Example: Includes: 2 photos 6"x9" & 5"x7"

- Should > and < be allowed to be DISPLAYED? (not executed)
Example: 100 > 10 - 1 + 3

- Should any/all (approved/sanitized) HTML be allowed to execute?
Example:Bold: <b>BOLD</b> Italics: <i>Italics</i>

With HTML IN PRODUCT DESCRIPTIONS "NO"

- Should BB/VBulletin Code be allowed or disallowed?
Example: Bold: bold Italics: italics (Using square brackets)

- Should " and & be allowed to be DISPLAYED? (not executed)
Example: Includes: 2 photos 6"x9" & 5"x7"

- Should > and < be allowed to be DISPLAYED? (not executed)
Example: 100 > 10 - 1 + 3

- Should any/all (approved/sanitized) HTML be allowed to execute?
Example:Bold: <b>BOLD</b> Italics: <i>Italics</i>

[Jeremy]

Originally Posted by Chuck S

Like I said html and bbcode dont play nice together.

But they can play nicely together in Jelsoft products, right?

Not that I would enable HTML in VB.

Anyway, I would prefer to use BBCODE throughout.

[Chuck S]

html is sanitized but not executed with html off. This is exactly how photopost and classifieds already execute things we simply do not allow html

Now I tried to give the users the ability to use html in reviewpost and if you want to use html you sacrifice using bbcode and this is what I posted above.

The vbulletin bbcode parser messes with the html and there is nothing we can do about that so it vbulletin integration you either use html or bbcode

Html works fine with our bbcode parser

[Jeremy]

No problem... I *want* to use BBCODE over HTML.

However, I also need to be able to send a carriage return or line break.

So how do I do this with HTML disabled? (which enables/stops conflicts with BBCODE?)

I'm going to reinstall your fix now & test....

[Chuck S]

With vbulletin just hit return on your keyword thats a line break