Would you recommend it? Always No

inspi2012 · January 31st, 2012, 06:33 PM

Would you recommend it? This at review step, no matter which one to pick, yes, or no, it always display it as "No". I believe this is a bug. Please help us to fix.

Latest 5.2 version.

Thank you!

Sean

Chuck S · January 31st, 2012, 07:39 PM

CS8 Series - Reeftalk Reviews

Interesting I just did a quick test and do not see any issues recommend is indeed typecast and the variable seems to pass.

inspi2012 · February 10th, 2012, 06:16 PM

But on our installation, we noticed from the very beginning this variable input does not get passed. See the example here:

KB 12P1 - Inspirare Social

The review section down I made a note that I selected YES, but on the top, RECOMMENDATIONS: NONE.

This problem exists before we did any template customization.

Please help.

Chuck S · February 10th, 2012, 06:35 PM

Interesting I edit the ones on the link you provided and they show yes for me?

KB 12P1 - Inspirare Social

inspi2012 · February 10th, 2012, 06:38 PM

I swear it did not work for me.

Now it worked. I just posted another one, and it worked. Sorry.

Chuck S · February 10th, 2012, 07:14 PM

enjoy your weekend.

kvnband · March 13th, 2012, 03:59 PM

We also have this on our non-modified installation. The value DOES get saved as "Yes", but on output, it always displays "No".

Chuck S · March 13th, 2012, 04:04 PM

Your using a custom language?

kvnband · March 13th, 2012, 04:05 PM

No we aren't.

kvnband · March 13th, 2012, 04:16 PM

Line 1277 of showproduct.php is currently

Code:

Content visible to verified customers only.

SHOULD BE

Code:

Content visible to verified customers only.

Even better would be

Code:

Content visible to verified customers only.

Chuck S · March 13th, 2012, 04:44 PM

Nope they should not be like that as you are looking at the wrong option I think as this thread I think pertains to this code

Code:

Content visible to verified customers only.

kvnband · March 13th, 2012, 04:48 PM

Our problem was that on output the 'would you recommend' was ALWAYS saying no, even if the database said 'Yes'. The reason is because the script checks for the 'Yes' value and wraps a green span around it if it's 'Yes'. But since it was checking for 'yes' and the value is stored as 'Yes', they weren't matching up, causing the issue. By changing the code to check for the correct value, it fixed our problem completely.

Chuck S · March 13th, 2012, 04:49 PM

Correct your talking about the dropdown so you might want to make sure your code higher up in the file for the $recode is what I have posted.

kvnband · March 13th, 2012, 04:51 PM

I have no idea what you're saying. I'm not talking about the dropdown. I'm talking about the output on the actual product page. And my fix corrected our problem. Perhaps the OP and I were having different issues.

Chuck S · March 13th, 2012, 04:56 PM

lists - Reeftalk Reviews

That is a default install

There are no changes needed to the code your noting because it is quite simple if clause if recommend is yes it shows yes

Code:

Content visible to verified customers only.

If your recommend on the review does not equal yes that is the only reason it would not say green yes there.

kvnband · March 13th, 2012, 05:01 PM

I'm a PHP developer by trade. I know "it is quite simple if clause". Like I've said many many times now - The value stored in the database is NOT 'yes', it is 'Yes'. And since PHP treats those two strings as different, as it well should, the test ALWAYS returns false. Therefore, the output is ALWAYS no. This is on an up-to-date machine running 5.3 and with several extensions. Perhaps a php.ini setting on our install is activating case sensitivity where yours isn't, but the point remains.

'yes' !== 'Yes' EVER

It's amazing that you guys still exist, really.....

Chuck S · March 13th, 2012, 09:24 PM

The value should never be Yes which is your issue which is why I said the code to make sure is as I posted is in post 11. You must make sure that code is what I am posting there and you can edit a review or place a new one you see it works fine so I posted the proper resolution in my initial response to you.

Basically I posted the resolution you told me I was wrong. My resolution is the correct answer here do with it as you wish.

kvnband · March 13th, 2012, 09:43 PM

This is why I literally despise this software. You have AWFUL code and even worse support.

From a fresh download this evening,

Code:

Content visible to verified customers only.

And what does reviews.php contain?

Code:

Content visible to verified customers only.

Therefore, the select box will ALWAYS have 'Yes' and 'No' as the options because you don't explicitly set the value in the select box. This is from a DEFAULT installation from TODAY. Don't tell me that the value should never be 'Yes' when that's what it is right out of the damn box.

I had to implement a custom fix, which is to make the 'Yes' comparison case insensitive, in case you screw it up again in the future. I recommend you either fix reviews.php for future downloaders so that they don't have to try to decipher what you're trying to say.

Chuck S · March 13th, 2012, 10:07 PM

I answered with the correct resolution so the support was perfect.

we have yet to release a 5.22 with the bug fix I posted which is only a month old.

There is no problem with the language phrase that should always be capital.

The actual correction was adding values in the option selections which is why my very first post here gave you the code. I informed you that you where looking in the wrong place gave you the proper fix.

kvnband · March 13th, 2012, 10:17 PM

When I have to sit here and try to interpret your responses for several minutes, that indicates that support is lacking. Perhaps you should hire a personal spell checker? Your grammar and general attitude gives off a horribly unprofessional appearance.

Now, on to your "fix". Answer me this, oh guru of PHP....

HOW DOES CHANGING THE DROPDOWN VALUES TO 'yes' INSTEAD OF 'Yes' FIX OUR PROBLEM? WE ALREADY HAVE THOUSANDS OF REVIEWS WHERE THE RECOMMEND FIELD IS STORED AS 'Yes'. SURE YOUR 'FIX' FIXES FUTURE REVIEWS, BUT IT'S NOT REALLY A FIX FOR THOSE OF US WHO HAVE BEEN RUNNING THE SOFTWARE FOR YEARS, IS IT?

This kind of garbage would never come out if you had quality control in place or did test driven development. You need to lose the poor attitude and start accepting critiques graciously. If you stand out and look from an outside perspective, you REALLY need to be doing a case insensitive comparison here, in case you ever make this idiotic mistake in the future. More importantly, this should really be a boolean field and not a yes/no field. I'm not sure why you would code it that way.

But I'm done here. I'm tired of attempting to reason with you. I can't wait for something to come along and replace this **** product. The only good thing you guys have is vbgallery and that's because it was purchased from a decent coder. Hopefully soon I can sleep well knowing I never have to interact with you again.