"Search Reviews" returns all products, not just reviews

[Zigw]

Hi Chuck,

Comparing again with 3.3, so let me know if this change was intentional:

Selecting "search reviews" returns (all?) products, not reviews. For example, enter "Best EF lens" for keywords, select "All Categories" and select "search reviews". You'll get a long list of products, many without reviews. It returns specific reviews in RP 3.3, so this seems to be broken.

Thanks!

[Chuck S]

That is definately not the behavior I see

quick test to show

Search - Reeftalk Reviews

leave it on search all fields and enter blue you get loads of results.

then go back and hit search reviews and enter blue. You get NO RESULTS which is correct.

I have looked at the code and your free to as well this is right in search.php

Content visible to verified customers only.

If your searching reviews that is the only table searched the products table is not searched.

If you leave the keyword blank and hit search reviews then it returns all reviews up to the search limit which is set in admin normally set to 500 results.

[Zigw]

Thanks Chuck.

I see the functionality on your site and I verified the code is correct in search.php, but for some reason on our site, a search within "reviews" is returning products without reviews. You can see for yourself at:

http://ir7.theimagingresource.com/reviews/search.php

- Set to search "Best EF Lens".
- Set to "All Reviews".

And the first result returned is a product without a review.

[Chuck S]

I would ensure all your files are uploaded correctly as you can see if your looking at search.php if $what is equal to comments the only table searched is reviews table.

I would make sure you have no modified files or templates. I can not verify what your site is doing I do a search as you suggest and the server times out trying to display results.

The example I posted is obviously a clean 5.21 site with no mods at all.

If you want to debug what is going on at your site then simply do this. Edit the search.php script and at the bottom put the code in bold that will stop the search script after it finds the results and will print the query for you to view.

Content visible to verified customers only.

You will then know how it is getting its results.

[Zigw]

After our the first thread when I mentioned diffing and you asked me why, I made sure to upload all the files from the distribution. We also don't have any of our regular mods on the site. This is a clean site.

I added the code you provided at the bottom of our search.php file, but it does nothing.

I am noticing that it seems to be exhibiting the behavior you would expect if the search field was left blank (returning all items in the db - in our case the test set is only 174).

I'm not sure why the server was timing out for you, but you can try again and see the behavior and results as described.

[Chuck S]

If you add the code I noted it should stop the script and print the query. that is what exit does. Everything I tell you I tried on my site before I posted I verified what is ran which is why I linked my site which is a clean install. Like I said if you hit all review the what variable is comments which means the only table searched is reviews. The products table is not searched which is why I asked about mods since I know you modify things normally. If I search on my site and hit all reviews and leave keywords blank it returns 21 results which is the number of reviews so again it is working correctly. Like I said hitting all reviews only means the reviews table is searched.

Here is what I get searching your site

[Zigw]

You're right, we normally do mod the site, but since you've told us time and time again you wouldn't work with us unless we had an un-modded site, we created one just so we could check the issues Zig was coming across.

I had already uploaded all the files from your distribution, but just to be sure nothing lingers, I'll recreate the mirror site from scratch tomorrow and import some of our data. Then for any future questions you can consider the site a clean install...

I'll be back.

[Chuck S]

well like I said I can not even verify you have an issue as the site keeps timing out for me as noted in my attachment.

[Zigw]

Of course, that goes without saying.

Ok, the site is now a completely fresh install with the exception of our stylesheet and our data in the db. Would you humor me and attempt the URL again?

Thanks.

[Chuck S]

The connection has timed out. The server at ir7.theimagingresource.com is taking too long to respond.

That is all I get from your site

Make sure line 41 of your search template reads like this

Content visible to verified customers only.

[Zigw]

I'll ask William why he may think your connection is timing out.

In the meantime, I checked search.tmpl and found the line different. The distribution file has a different line:

Content visible to verified customers only.

Once I changed "reviews" to "comments", it looks like it fixed the issue. I'll verify with Zig and get back to you...

[Chuck S]

Yeah your server timesout all the time anytime I try doing anything.

Yeah I saw the default template set line was different which is why I posted what I did.

[ywickham]

William thinks he found your ip and whitelisted it. I didn't post your IP here because I wasn't sure if that would be okay with you. Please check that URL again and let me know if it is not letting you in If it is not please p.m. me your IP so we can whitelist it. Thanks.

[Chuck S]

Nope it works now

[Zigw]

Great!

I verified with Zig and this fixes this issue.

Thanks!

[Chuck S]

Enjoy the holidays.

[Zigw]

No rest for the weary, Chuck. lol

Happy Holidays to you too.

[Chuck S]

Yep we generally work 365 days a year.