All Products just disappeared!!!

[KenDude]

Well something to think about. BTW I was considering upgrading my Classifieds to the latest version as well and I see it has a new search feature incorporated as well, would it also need this same fix to sort appropriately?

[Chuck S]

yes it would

[KenDude]

FYI I updated my classifieds and also modified the search.php using the same method you used for the reviewpost search.php and it works fine.

Thanks!

[Chuck S]

yeah I hope you just added the order statement

[KenDude]

Originally Posted by Chuck S

yeah I hope you just added the order statement

Yes I did, since the database line refers to different database name, as well as some different fields you can't just cut/paste between the two, so I compared the two and saw where you put the Order statement in at a couple of spots and just added that to the lines in the classifieds search.php file and it seems to work fine.

There is an issue with page numbering in the classifieds I really wish you could fix though, it's been there for years...

What happens is when say you have 200 items in a category, but only 80 of them are active, the other 120 are hidden because the items have sold or expired, etc. When you go into that category instead of seeing page links at the bottom for pages 1-4 (20 items per page for 80 active items), you see instead 1-10 (20 items per page for 200 total items in the category). As you click from 1 to 2 to 3 to 4 you see items but when you click on 5 you just get a page with the header, footer, etc. a category bar and nothing underneath it, the same for 6-10. It is confusing to users who think they are missing something or think something is wrong because they can navigate to someplace where nothing shows up.

In essence I'd like to see the navigation paging numbers generated on the total of "Active" items in the category, items that actually show up, vs. "Total" items in the category.

Now for the admin tools I fully understand how you need to page through all items because you might want to reactivate a closed item, etc. but in viewing the categories and items in those categories in the user interface, you don't see the items that don't show up, but you see the page numbers for them which is confusing.

This also shows up in the category listing where it shows say 25 items in a category but you go into the category and only 2 items show up because the other 23 have expired. It would be nice of the number was just of Active items, or if need be you could something like (2/23) to show that there are 2 active items out of 23 total in that category.

Make sense?

[Chuck S]

well if your referring to hidden items because you do not show sold ads over x amount of time there is nothing to fix. Remember it all depends on how often you expire things but to do pages you can only run a diviison on the number of results say 200 or whatever are pulled.

whether or not something shows in that specific page is done inside the next loop. So really the only way to do something like you want is to remove a whole section of functionality in the program hense the ability to show sold ads for a specific time period.

[KenDude]

Originally Posted by Chuck S

well if your referring to hidden items because you do not show sold ads over x amount of time there is nothing to fix. Remember it all depends on how often you expire things but to do pages you can only run a diviison on the number of results say 200 or whatever are pulled.

whether or not something shows in that specific page is done inside the next loop. So really the only way to do something like you want is to remove a whole section of functionality in the program hense the ability to show sold ads for a specific time period.

I am referring to hidden items, which as I understand it are items that have expired and are thus hidden, but still exist in the database and exist in that category per se. Now I understand that when you pull an item from the database you can do a simply count, I pull 1 item, counter =1, I pull 2 items, count = count +1, etc. and you get 2, so if you pull 200 items you'd have a count of 200. What I'm asking for is that when you pull from the database you do it in the fashion of Where the item exists AND where field.hidden is False, in other words you get a count of only active items in the database for that category, you weed out the hidden in your count. Then you use that count variable to establish the paging, as well as the display of how many items are in that category.

If you can point me to where you are reading from the database for this calculation (which file and roughly what line #) I can probably take a look at it and make the change to show you what I mean.

Does that make more sense now?

[Chuck S]

Ken I know what your talking and its not expired items I am referring to but sold ones.

Your free to modify the showcat script however you wish but as I have noted there is nothing wrong with the script. we will not be removing functionality from the script in this regards concerning the ability to show or not show sold ads in a specific timeframe.

[KenDude]

Originally Posted by Chuck S

Ken I know what your talking and its not expired items I am referring to but sold ones.

Your free to modify the showcat script however you wish but as I have noted there is nothing wrong with the script. we will not be removing functionality from the script in this regards concerning the ability to show or not show sold ads in a specific timeframe.

Chuck,
I'm not asking you to remove functionality, so to continue the discussion, how do you determine whether or not to show a sold item? There must be some formula or some field that is flagged to indicate whether the item is shown or not right?

Ultimately you have a number of items shown in the category, in my example above it was 80 items out of 200 that exist in the category. Whatever formula or field value(s) you use to determine what to show in the category is what I am saying you should also use to determine the "count" of the number of items for display and paging purposes as opposed to the raw count of 200 in this example.

I guess I'm not understanding what is so hard about that.

[Chuck S]

Pagination is done off the results returned by mysql not after any filters or sub loops down the chain. We count each row and your like several rows down the chain before you know what is shown.

You can set the number of days to to show ads in the show ad options in admin.

There is no support whatsoever for this and I can not comment further but you can try this

Content visible to verified customers only.

You would have to add that in bold where noted

Content visible to verified customers only.

same thing where noted add that line in bold

then the line below you would need to change the variable to the new one you defined

Content visible to verified customers only.

Thus $cntresults would become $finresults on that line.

[KenDude]

Ok I'll give it a try and see, is that in showcat.php or somewhere else?

[Chuck S]

Nope its showcat.php the script we have been discussing.

[KenDude]

Chuck,
Before I try this out I was surfing through my classifieds looking at various categories and I notices a LOT of items marked Sold that are still showing up in the category view. I thought those were supposed to disappear after 24 hours (or whatever I have it set at in the admincp), any idea why this isn't happening?

Is there any quick way to remove all of the items currently marked Sold? I can't seem to find a way in the admin panel to do it.

[KenDude]

OK I tried the code you suggested and the last line that should display the paging links doesn't display anything at all, no text, nothing. I switch back to cntresults instead of finresults and the default method of paging shows up again, so it evidently doesn't like whateever is stored in the finresults variable, even though I put the code into showcat.php where you instructed me to. Thoughts?

[Chuck S]

no thoughts and as stated not something I have tried so not much I can comment on. The software is performing as it should from my perspective as I have explained how things work. I merely posted a thought of how you could do something different.

if you have issues with sold ads appearing check your days your looking to display back from. also remember just because an ads posted date may be older than how many days your electing to show ads has no bearing on the actual sold date.

[KenDude]

Ok well if you think of something that might work let me know.

As for sold ads some of these were months old and were marked sold months ago, in the admin panel I have the display sold ads setting set to 1 day. Yet some are still hanging around, as if the cron job isn't doing its job.

[Chuck S]

how do you know these ads have been sold for along time? have you actually gone into the database to the status field pulled the timestamp there and gone to some site like unixtimestamp.com and converted the timestamp?

Reason I say this is code is absolute.

Content visible to verified customers only.

Thats how we figure a cut off date

Content visible to verified customers only.

This if clause tells it all. Your going to see the ad if the ad is not sold which is status 0 or if the status is greater than the cut off date.

[KenDude]

Originally Posted by Chuck S

how do you know these ads have been sold for along time? have you actually gone into the database to the status field pulled the timestamp there and gone to some site like unixtimestamp.com and converted the timestamp?

Reason I say this is code is absolute.

Content visible to verified customers only.

Thats how we figure a cut off date

Content visible to verified customers only.

This if clause tells it all. Your going to see the ad if the ad is not sold which is status 0 or if the status is greater than the cut off date.

Chuck,
I did not go into the database but I did contact 3 of the members asking them when they marked their items as sold (I had probably 50 items showing up as sold dating back several months so the odds of that happening all within the last 24 hours would be astronomical!) Anyway I heard back from some of them that they had marked their ads sold weeks ago or over a month ago, so I knew these were stale ads that were not removed for some reason. I've since deleted them so I can't go back in and look at the date values stored in the database, but if I find another one that looks like it was marked sold awhile ago and is still showing up then I can point you to that ad. I can then also use my plesk control panel at my ISP to go into the database and look at the entry and see whatever some field values are if that helps troubleshoot the issue.

I'm thinking it is something simpler like the cron job isn't running right or something, but heck if I know what's causing it.

Any other thoughts on the paging display after what we tried didn't work?

[Chuck S]

Like I said as far as hacking not much I can respond to there as I would not consider that necessarily a bug in the code but the normal functionality

As far as a sold ad showing what version of the code are you running? You would probally need to view the actual status field in the database of an ad and pull up that timestamp for me to comment on why sold ads are appearing. Like I said code wise if you have sold ads to set to display for one day I would think those ads are not sold or not expired.

You can setup the cron or run the manual cron sendnotice.php through your browser. Basically I would need concrete data to comment.

[Chuck S]

As far as hacking one idea besides adding the $finresults++ line you might need to remove the $cntresults++ from under the while loop and then replace all other $cntresults variables in that file with $finresults.