 | |  | | | ReviewPost Bug Reports Let us know about any post installation problems you are having with ReviewPost. |
June 1st, 2011, 07:05 PM
|
#41 (permalink)
| | Photopost Developer Verified Customer
Join Date: Jun 2002 Location: Abingdon,MD
Posts: 71,947
|
Thanks will let you know.
|
| |
June 1st, 2011, 08:22 PM
|
#42 (permalink)
| | Photopost Developer Verified Customer
Join Date: Jun 2002 Location: Abingdon,MD
Posts: 71,947
|
Your reviews page issue was a slight change to htaccess changing page to cpage but as far as your issue with 404's and catname not being in the url all I did was upload all clean 5.2 files and that fixed it so you had some old files.
|
| |
June 2nd, 2011, 09:30 AM
|
#43 (permalink)
| | Member Verified Customer
Join Date: Oct 2006
Posts: 426
| Quote:
Originally Posted by Chuck S Your reviews page issue was a slight change to htaccess changing page to cpage but as far as your issue with 404's and catname not being in the url all I did was upload all clean 5.2 files and that fixed it so you had some old files. |
Chuck,
Thanks for fixing I will check it out, that's weird about the old files, the only one I ever keep around is the one I keep having to manually update (which I assume I will have to fix again if you just uploaded over it) that incorporates the addition of the < input > into the allowed items so that my hidden button works. Other than that, everything should have been the latest and greatest which is very weird if it wasn't.
Thanks!
|
| |
June 2nd, 2011, 10:00 AM
|
#44 (permalink)
| | Photopost Developer Verified Customer
Join Date: Jun 2002 Location: Abingdon,MD
Posts: 71,947
|
Yeah the htaccess thing was simple it was looking for page in the url not cpage to declare the variable. Easy fix
As far as your catname thing that could have only been an old file because I remember a bug awhile back with an earlier 5.0 version I think where we had to explicitly declare the cat variable in the construct ppurl function line.
|
| |
June 21st, 2011, 12:58 PM
|
#45 (permalink)
| | Member Verified Customer
Join Date: May 2006 Location: Toronto
Posts: 205
| I see something similar on Reeftalk
Hi Chuck -
I get 404 errors when I click on the Page: 2, 3, 4, etc. links at the bottom of this page of your site:
The More link doesn't appear to work either, as I get the same page when clicking it.
I also get 404 errors when I click on the thumbnails in "Most Recently Made Reviews" section on this page of your site:
We are seeing similar issues with bad URLs on our RP 5.2 test site. Related to above thread? Is there a patch?
Thanks!
Last edited by Chuck S; June 22nd, 2011 at 11:19 AM.
|
| |
June 21st, 2011, 04:18 PM
|
#46 (permalink)
| | Photopost Developer Verified Customer
Join Date: Jun 2002 Location: Abingdon,MD
Posts: 71,947
|
well when I looked into Ken's thing he had old files etc.
If you want me to look at your site let me know but I would suggest you download the build and upload all the files.
|
| |
June 22nd, 2011, 08:53 AM
|
#47 (permalink)
| | Member Verified Customer
Join Date: May 2006 Location: Toronto
Posts: 205
| Quote:
Originally Posted by Chuck S well when I looked into Ken's thing he had old files etc.
If you want me to look at your site let me know but I would suggest you download the build and upload all the files. | So you are not running the released 5.2 code on reeftalk.com?
We did a full upgrade to 5.1, and uploaded all 5.2 files that were different from 5.1 (a larger list of new files than yours).
How about you fix those issues on your site, then let us know the changes required?
Thanks.
|
| |
June 22nd, 2011, 09:21 AM
|
#48 (permalink)
| | Photopost Developer Verified Customer
Join Date: Jun 2002 Location: Abingdon,MD
Posts: 71,947
|
I really could not say what version I am using there. Thanks for pointing out the spam though as I have not looked at that install for awhile
anyway uploading 5.2 fixed that issue
The issue as I saw on Ken's site with old files is this
The htaccess file this line had the variable as page not cpage Code: Content visible to verified customers only.
Next issue which was fixed in 5.2 over 5.1 in showproduct.php the cat variable was not passed accordingly to grab the catname hense the catname missing from the url on the page links. Code: Content visible to verified customers only.
|
| |
June 22nd, 2011, 10:40 AM
|
#49 (permalink)
| | Member Verified Customer
Join Date: May 2006 Location: Toronto
Posts: 205
|
We've already got those changes on our site. Not sure if paging is actually a problem with ours yet, as we don't have that many reviews on our test site. I'll need to enter a bunch more to see if paging works.
BTW, the second issue with bad URLs when you click on some of the product thumbsnails in "Most Recently Made Reviews" still exists on your site. Clicking on the first thumbnail produces this bad URL: We have the same issue on our test site, so we'd be interested in a fix for that.
Looking at showproduct.php in the 5.2 download zip file, I see two lines that are similar to your second code segment above, but one has 'cat' => $cat and the other and the other has '$cat' => $cat Shouldn't they both use 'cat'?
See: Code: Content visible to verified customers only.
This code is directly from the 5.2 zip I just downloaded again, so it's the latest released code.
Last edited by Chuck S; June 22nd, 2011 at 11:18 AM.
|
| |
June 22nd, 2011, 11:17 AM
|
#50 (permalink)
| | Photopost Developer Verified Customer
Join Date: Jun 2002 Location: Abingdon,MD
Posts: 71,947
|
That is the issue as I reported it should be 'cat' not '$cat'
Please stop posting my site links here.  If you have an issue with your site then fine you can post your links but I have not given anyone permissions to post my site. I have overlooked it thus far but you keep doing it.
In member.php line 663 should read Code: Content visible to verified customers only.
Last edited by Chuck S; June 22nd, 2011 at 11:23 AM.
|
| |
June 22nd, 2011, 12:06 PM
|
#51 (permalink)
| | Member Verified Customer
Join Date: May 2006 Location: Toronto
Posts: 205
|
Okay, I didn't know that pointing to your site was prohibited. Thought I was doing you a favor by showing what was not working.
Thanks for the member.php fix...it works.
We have another issue with thumbnails not showing in the various profile views on our site. They all have images that say "no thumbnail". Any idea what that would be? Image paths all end in /reviews/images/nothumb.gif but the alt text points to the correct thumbnails (for example: .../reviews/data/38/thumbs/olympus-epl2.jpg)
Thanks.
|
| |
June 22nd, 2011, 12:24 PM
|
#52 (permalink)
| | Photopost Developer Verified Customer
Join Date: Jun 2002 Location: Abingdon,MD
Posts: 71,947
|
Well it is like pulling teeth getting people to post there site links here to even provide support. Note your not posting your site as examples which is what normally you would do if your trying to show and convey an issue. Likewise posting someone else's link online without permissions is not appropriate. If I post my link thats one thing.
I would have to see your example of images not showing. There are four things that show thumbnails on the profile. Statistics, Products, Watch List and the Reviews. I have clicked around my site and all things show. One function in our program determines what is shown as a thumbnail and basically if a thumbnail exists we show it and if there is not one the nothumb.gif is shown. The alt tag is a mere url representation of where a thumbnail should be. Server data path is used to see if the thumb exists so maybe just a guess something wrong with permissions on that file corruption etc. If thats the case you should also see the thumbnail missing viewing the product etc or the category of products where that thumbnail is shown.
|
| |
June 22nd, 2011, 01:04 PM
|
#53 (permalink)
| | Member Verified Customer
Join Date: May 2006 Location: Toronto
Posts: 205
|
Yeah, our test site is not live for public access, so unfortunately I can't point you to it. We're still running RP 3.3 on our live site.
BTW, if I cut & paste the alt tag URLs into the browser address bar, the thumbnail images are displayed, so they exist. And thumbnails appear fine in the standard product or category views. We're looking into it, but I thought I'd ask in case you've seen this before.
|
| |
June 22nd, 2011, 02:57 PM
|
#54 (permalink)
| | Photopost Developer Verified Customer
Join Date: Jun 2002 Location: Abingdon,MD
Posts: 71,947
|
yeah no I haven't it has to maybe be related to something on the server not allowing something it all depends exactly where and thats why seeing the site helps so I can make a good guess. Especially when viewing any other site that has reviewpost they display fine.
|
| |
June 25th, 2011, 04:49 PM
|
#55 (permalink)
| | Registered User
Join Date: Sep 2005
Posts: 18
| Quote:
Originally Posted by Zigw
We have another issue with thumbnails not showing in the various profile views on our site. They all have images that say "no thumbnail". Any idea what that would be? Image paths all end in /reviews/images/nothumb.gif but the alt text points to the correct thumbnails (for example: .../reviews/data/38/thumbs/olympus-epl2.jpg)
Thanks. | Quote:
Originally Posted by Chuck S I would have to see your example of images not showing. There are four things that show thumbnails on the profile. Statistics, Products, Watch List and the Reviews. I have clicked around my site and all things show. One function in our program determines what is shown as a thumbnail and basically if a thumbnail exists we show it and if there is not one the nothumb.gif is shown. The alt tag is a mere url representation of where a thumbnail should be. Server data path is used to see if the thumb exists so maybe just a guess something wrong with permissions on that file corruption etc. If thats the case you should also see the thumbnail missing viewing the product etc or the category of products where that thumbnail is shown. | Shedding more light on the issue Zig brought up with the image URLs. I can say with certainty it is not a permissions issue or file corruption since one of the thumbnails that won't show on the m1-reviewadmin-protype1.html page is showing up just fine on the index.php page under the "Recent Products" table.
I thought at a first you were right and that it was a simple permissions issue, but if it was the image wouldn't be visible on the homepage. What I don't understand is why the same path, when evaluated for one location of the site works with the file_exists() function on line 3637 of pp-inc.php, yet makes the function fail when evaluated for a different location. Have any ideas?
Thanks.
|
| |
June 25th, 2011, 07:25 PM
|
#56 (permalink)
| | Photopost Developer Verified Customer
Join Date: Jun 2002 Location: Abingdon,MD
Posts: 71,947
|
I do not have any site info to look at it. As long as the code is not modified things should be fine. At least I can show they are on a test site. Without seeing the issue no one here can comment.
|
| |
July 11th, 2011, 09:26 AM
|
#57 (permalink)
| | Member Verified Customer
Join Date: May 2006 Location: Toronto
Posts: 205
| Bad URLs
Hi Chuck -
We're still seeing some bad URLs generated with the above fixes. For example, when we have more than one page of reviews, there is a "More ->" button at the bottom of the page that has a bad URL (seems to be missing a category: /reviews//p232-sigma-28mm-f-2f1-8-cpage2.html), plus there is no link for Page 1, so there is no way to get back to Page 1 without re-searching. You have the same issue on your site with no Page 1 link, but I don't see a "More ->" link.
We have a similar problem with keyword search results, only all page links are bad, generating URLs like: /reviews/gall--page2.html I can't tell if Page 1 gets a link on subsequent pages, as they are all 404s.
Thanks.
|
| |
July 11th, 2011, 10:44 AM
|
#58 (permalink)
| | Photopost Developer Verified Customer
Join Date: Jun 2002 Location: Abingdon,MD
Posts: 71,947
|
I do not get any bad urls on search page. I enter a search term get 194 results and can page through without issue. There is no more link that I see.
I reuploaded the build you can try to redownload the files and replace yours.
|
| |
July 11th, 2011, 12:05 PM
|
#59 (permalink)
| | Member Verified Customer
Join Date: May 2006 Location: Toronto
Posts: 205
| Quote:
Originally Posted by Chuck S I do not get any bad urls on search page. I enter a search term get 194 results and can page through without issue. There is no more link that I see.
I reuploaded the build you can try to redownload the files and replace yours. | The bad page links don't happen with regular searches, only keyword searches. I wasn't able to find enough keyword results on your site to generate multiple pages of results, but I didn't look very long.
As for review pages, I found you have a More link when I view reviews in the "additives" category (since there are 561 reviews), but it seems to work where as ours doesn't.
I guess I will re-download and compare again, but the missing Page 1 link issue is on your site, so I don't think that has been addressed.
|
| |
July 11th, 2011, 02:34 PM
|
#60 (permalink)
| | Photopost Developer Verified Customer
Join Date: Jun 2002 Location: Abingdon,MD
Posts: 71,947
|
what are you referring to missing page 1 issue. That is the problem with these types of threads where multiple issues are being brought up it can be addressed. Any issues I have replied to addressing a fix should be included in the current download. If there are explicit urls to address it you can email us,
|
| | |
Currently Active Users Viewing This Thread: 1 (0 members and 1 guests) | | | | Thread Tools | | | | Display Modes | Rate This Thread | Linear Mode | |
Posting Rules
| You may not post new threads You may not post replies You may not post attachments You may not edit your posts HTML code is Off | | | All times are GMT -5. The time now is 01:18 AM. | |