RP 4.1: Formatting in e-mails wrong/ HTML code visible

snoopy5 · April 18th, 2009, 10:24 AM

Hi

RP 4.1

Downloaded-packacke of 16.4.2009 in the evening.

The content of the e-mail notifications is wrong.

If I set it in ACP to no HTML e-mail, they arrive with HTML code in it. Example:

Code:

Content visible to verified customers only.

If I enable HTML code for emails in ACP it looks like this:

Code:

Content visible to verified customers only.

So in both versions, username and URL are only code and in the non-html e-mail, also HTML code like <br> etc. is visible.

I do not know whether also the actual posting of the user should be included in these e-mails. But it is not in my version.

I use Outlook 2007 and windows XP. Both newest version

How can I fix this?

Thanks in advance

P.S.: as a sidenote: I changed the line with the word team in it to a standard phrase with no code in it. That is why there is "Dein mywebsite-team" visible.

Chuck S · April 18th, 2009, 11:35 AM

well html in emails is being done by you in your translations it would appear. None of our default emails in phrases.php have break html tags we use /n and /r in them not html.

I also wonder why as I have tested the default email and it works why only half your variables work in the email. Look at your email some variables are correct others are not.

This is a default message it looks like emailreply

Code:

Content visible to verified customers only.

Based on that email we then apply the replacements below.

Code:

Content visible to verified customers only.

snoopy5 · April 18th, 2009, 12:07 PM

I reverted my translation to have it in the original version. But the bug is the same also with the original code in the language file:

HTML in ACP turned off.Again <br> tags, globals etc.

Code:

Content visible to verified customers only.

HTML set to on:

Code:

Content visible to verified customers only.

So it must be a bug and not a a setting/translation question on my end.

The text entered by you in RP is:

Code:

Content visible to verified customers only.

So the globals, get title and the username are just ignored. I do not know where the br are coming from, but I did not enter any. So this is obviously an issue of the code or the mysql database

By the way: if I put the marking in ACP languages on "revert", it seems to make problems with quotes. See screenshot the comparison of the original on the right and what happens after reverting & saving on the left.

Chuck S · April 18th, 2009, 01:47 PM

You know in the phrase there is no br tag

Try removing in pp-inc.php this line

$letter = un_htmlspecialchars(nl2br($letter));

Chuck S · April 18th, 2009, 01:49 PM

This is the email I recieve

Quote:

Admin has posted a reply about the following ad: "test" - test - Omegatron.net Reviews

test review emails

Chuck S · April 18th, 2009, 01:53 PM

I just tested again with default code this is what I get

Quote:

Admin has posted a reply about the following product:

"test"

test - Omegatron.net Reviews

If you no longer wish to be notified of replies about the above product, you can disable notification for it here:

http://www.omegatron.net/reviews/com...id=1&product=7

Thanks!

The Omegatron.net Team
Main Index - Omegatron.net Reviews

snoopy5 · April 18th, 2009, 02:32 PM

Quote:

Originally Posted by Chuck S

You know in the phrase there is no br tag

Try removing in pp-inc.php this line

$letter = un_htmlspecialchars(nl2br($letter));

I commented it out with

//

But no difference in the e-mail

Did you change in pp-inc or any other file within the last 2 days something?

What is your setting in ACP for sending out e-mails HTML and what do you have in your field one below for "How do you want to Send Mail?"

Do you use a vb integration? I do. Could that cause the trouble?

In the classifieds software another user seems to have a similar problem. But he did not post his e-mails properly, so I can not judge whether it is the exact same problem:

How to change email text

Chuck S · April 18th, 2009, 05:59 PM

Feel free to download the build and upload pp-inc.php and see what happens.

snoopy5 · April 19th, 2009, 04:22 AM

Quote:

Originally Posted by Chuck S

Feel free to download the build and upload pp-inc.php and see what happens.

I did that. I exchanged my pp-inc file against the new one of the new download. But no improvement.

I saw that in the new download almost all files have a new date (mostly 18.4.2009)

Have there been also changes with the other files?

Can you give me your email settings in ACP, so that we can compare?

Chuck S · April 19th, 2009, 08:11 AM

My email settings are html email to NO

send email is set to both

here is the messaging entry I get. Based on your email we are talking about the emailreply entry which is done when a user posts a reply.

Code:

Content visible to verified customers only.

Here is the email that I recieve

Code:

Content visible to verified customers only.

I really dont see anything wrong here. Your free to test with a default product and files then make any modifications your making later thats probally the best way to do it. Make sure your using all the current files.

Chuck S · April 19th, 2009, 09:19 AM

Specifically the two files that control the review email are reviews.php and pp-inc.php

snoopy5 · April 19th, 2009, 04:24 PM

Hi

I think I found at least the location for this bug. It is the language setting in ACP. I installed a fresh installation. This works fine as long as I do not add another language in ACP.

As soon as I add a new language (/ACP/Add/Edit Languages) no matter with which setting, the problem starts again.

I tried the following combination in ACP/edit languages:

german
UTF-8
ltr

german
ISO-8859-1
ltr

german
UTF-8
-

german
ISO-8859-1
-

german
-
-

Always in ACP no html e-mail checked (Use HTML Email? = no)

Hope that helps to find a fix...

Chuck S · April 19th, 2009, 07:26 PM

What language you use should cause no issues. Your email strings are your email strings. I created a new language called German with UTF-8 and then made a review on a product. I get the same email I get if I use English.

Chuck S · April 19th, 2009, 07:30 PM

Main Index - Omegatron.net Reviews

Code:

Content visible to verified customers only.

Set to german

snoopy5 · April 20th, 2009, 05:32 AM

Quote:

Originally Posted by Chuck S

Main Index - Omegatron.net Reviews

Code:

Content visible to verified customers only.

Set to german

In which file do I set this?

I think I can narrow down the bug. It seems to appear only, if you translate a phrase. No matter which language is set in ACP/language. This is what I did:

I made again a fresh install of the newest download. This time I left it with english. As before, everything works fine out of the box. I do not change anything now in the ACP/Add/Edit Languages. It is still left to English.

Now I only search in ACP/Search Language Strings for the phrase

"has posted a reply"

I get to fields. I translate only 3 words in each field. Nothing else. I check the boxes on the right to "approve changes" and hit save.

Now I get the mess in the e-mail again. I can reproduce it every time with a fresh install. But once I did a translation of a text, I can never revert again. If I click on revert, it reverts the text, but the bug stays in the e-mails forever.

Also when I revert the text to the original, the "gettitle line" is messed up. The quotes are not there anymore. I attached a screenshot how this gettitle looks before translating text, and then after translating it and after set to revert.

So the software messes something up as soon as the original text (not code) is changed and is not able to undo this. To undo it, I have to delete the database and make a fresh install of the whole software

If you want to, I can send you access to 3 different testinstalls I made. Always the same. All 3 are integrated with a fresh and empty vb 3.82 if that matters (only user integration, no layout integration).

Chuck S · April 20th, 2009, 07:25 AM

Well appreciate your ideas but lets break this down.

I tested all this before my last reply which it states I am using another language as shown.

I search for string gettitle and find things fine.

Whether or not you see " or " does not matter thats simply a display thing and I can remedy that by adding this line at around line 194 in adm-lang.php. In fact as far as storing in the database you want to store quotes in that code.

Code:

Content visible to verified customers only.

Now I translated that string basically just approving it and submitting it. I made a comment and this is the email I get

Quote:

Admin has posted a reply about the following product:

"test"

test - Omegatron.net Reviews

If you no longer wish to be notified of replies about the above product, you can disable notification for it here:

http://www.omegatron.net/reviews/com...id=1&product=7

Thanks!

The Omegatron.net Team
Main Index - Omegatron.net Reviews

As long as your not changing the code part of the email strings you should be fine.

snoopy5 · April 20th, 2009, 09:09 AM

Hi

I do not mind with the quotes in ACP as long as this does not results in the e-mail-bug.

But in your example, you did not change the text like I did. See your e-mail you got in your quote above. It is the original text without modification.

Try to change the words "has posted a reply about", save that change, submit it and then post again and wait for the e-mail. In this e-mail the new text has to appear. But all links will be broken as shown in my earlier postings.

Here again. You see al these "globals" in the e-mail as soon as the text within the e-mail has changed (I marked the translated text in the quote here for you in bold):

Quote:

^User['username'] hat einen Kommentar geschrieben about the following product:

"asfsdg"

^Globals['maindir']/showproduct.php?product=1

If you no longer wish to be notified of replies about the above product, you can disable notification for it here:

^Globals['maindir']/comments.php?notify=off&notifyid=3&product=1

Thanks!

The ^Globals['webname'] Team
^Globals['domain']

I am pretty sure it will cause the same trouble in your installation as in my installations.

It is very unlikely, that with 3 testinstallations I am wrong on this. I can repeat this before/after bug as often as I want to with every fresh RP 4.1 installation. Just try it.

Chuck S · April 20th, 2009, 09:56 AM

I think I know your issue

redownload the build and upload adm-lang.php

snoopy5 · April 20th, 2009, 11:06 AM

Quote:

Originally Posted by Chuck S

I think I know your issue

redownload the build and upload adm-lang.php

Yeeeeeeeeeeeeeeeeeessssssssssssssssss!

You have got it!

Now it works. I downloaded the complete new download as of today, made a fresh installation. E-mail contnet is now properly diplayed, no globals anymore. The quote appearance within ACP is also gone by the way. This works for both: English and with adding another language.

So far so good.

BUT I tried the same with my old installation. I replaced all files on the server with the new ones. The goabals disappeard, but the regarding line in teh header is still wrong.

Is there a way to fix this also for my first installation, I already made section & products and a lot of translations which I do not want to loose. Or is there a way to import those in a fresh install?

Chuck S · April 20th, 2009, 11:48 AM

Did you reedit any strings you had priorly translated? The new build is not going to fix strings until you actually reedit them