PhotoPost Photo Gallery Sales PhotoPost Sales Toll Free Phone Number
Mon-Fri 9am-4pm EST
  PhotoPost Photo Sharing Photo Gallery    Visualize community tm
| | | | | | | | |

Go Back   PhotoPost Community > PhotoPost Support > ReviewPost Pro Support Forums > ReviewPost Bug Reports

ReviewPost Bug Reports Let us know about any post installation problems you are having with ReviewPost.

Reply
 
LinkBack Thread Tools Rate Thread Display Modes
Old December 29th, 2006, 02:52 PM   #1 (permalink)
Senior Member
Verified Customer
 
Join Date: Jun 2003
Location: London, UK
Posts: 562
revshow.php isn't parsing / displaying paragraph breaks in any of the reviews

revshow.php isn't parsing / displaying paragraph breaks in any of the reviews

The following lines of text for each review doesn't make proper sense:

#1 Last Review Posted by JoeSoap - posted products and: 9 November 04 19:03
#2 Product Details: "Product Name" by JoeSoap - posted products and: - Rating: 8.00

I'd like to suggest that 'rating' in line #2 be changed to 'overall product rating' or similar (which is what it is) as each reviewer's rating already appears just above that... and it may be confusing to some people.
criscokid is offline   Reply With Quote
Old December 29th, 2006, 03:47 PM   #2 (permalink)
Photopost Developer
Verified Customer
 
Chuck S's Avatar
 
Join Date: Jun 2002
Location: Abingdon,MD
Posts: 71,940
I show we convert returns on that script

For the date line find this in revshow.php and add in bold

Code:
Content visible to verified customers only.
In your english.php language file you can make this line this

Code:
Content visible to verified customers only.
__________________
Photopost Developer and Support Engineer

Please do not PM me for support or sales questions. Thank you for your understanding.
Chuck S is offline   Reply With Quote
Old December 29th, 2006, 08:01 PM   #3 (permalink)
Senior Member
Verified Customer
 
Join Date: Jun 2003
Location: London, UK
Posts: 562
Quote:
Originally Posted by Chuck S View Post
I show we convert returns on that script
I'm not sure what you mean Chuck?

I've checked out your site... myhunprotectsme's review of this product has paragraph breaks in it but they don't show up on revshow.php
criscokid is offline   Reply With Quote
Old December 29th, 2006, 08:51 PM   #4 (permalink)
Photopost Developer
Verified Customer
 
Chuck S's Avatar
 
Join Date: Jun 2002
Location: Abingdon,MD
Posts: 71,940
Code:
Content visible to verified customers only.
This is right in the file revshow.php and it has convert_returns in there
__________________
Photopost Developer and Support Engineer

Please do not PM me for support or sales questions. Thank you for your understanding.
Chuck S is offline   Reply With Quote
Old December 30th, 2006, 07:17 AM   #5 (permalink)
Senior Member
Verified Customer
 
Join Date: Jun 2003
Location: London, UK
Posts: 562
Quote:
Originally Posted by Chuck S View Post
This is right in the file revshow.php and it has convert_returns in there
... but it's not working / doing what it's supposed to do and that's show the paragraph breaks.
criscokid is offline   Reply With Quote
Old December 30th, 2006, 07:40 AM   #6 (permalink)
Photopost Developer
Verified Customer
 
Chuck S's Avatar
 
Join Date: Jun 2002
Location: Abingdon,MD
Posts: 71,940
Look at your review in the database you have no paragraph breaks or anything to convert.

If there are no breaks or such to convert nothing can be converted at least that is what I see
__________________
Photopost Developer and Support Engineer

Please do not PM me for support or sales questions. Thank you for your understanding.

Last edited by Chuck S; December 30th, 2006 at 07:46 AM.
Chuck S is offline   Reply With Quote
Old December 30th, 2006, 07:56 AM   #7 (permalink)
Senior Member
Verified Customer
 
Join Date: Jun 2003
Location: London, UK
Posts: 562
But there are paragraph breaks.... I even gave you an example in post #3:

I've checked out your site... myhunprotectsme's review of this product has paragraph breaks in it but they don't show up on revshow.php
criscokid is offline   Reply With Quote
Old December 30th, 2006, 08:00 AM   #8 (permalink)
Photopost Developer
Verified Customer
 
Chuck S's Avatar
 
Join Date: Jun 2002
Location: Abingdon,MD
Posts: 71,940
There are no breaks I went right to the database and there is no /r/n or no <br /> in that review
__________________
Photopost Developer and Support Engineer

Please do not PM me for support or sales questions. Thank you for your understanding.
Chuck S is offline   Reply With Quote
Old December 30th, 2006, 08:37 AM   #9 (permalink)
Senior Member
Verified Customer
 
Join Date: Jun 2003
Location: London, UK
Posts: 562
So what's creating the paragraph breaks for the review on showproduct.php?

Whatever it is please can we get revshow.php to parse those 'paragraph breaks' in the same way that showproduct.php is doing.
criscokid is offline   Reply With Quote
Old December 30th, 2006, 08:55 AM   #10 (permalink)
Photopost Developer
Verified Customer
 
Chuck S's Avatar
 
Join Date: Jun 2002
Location: Abingdon,MD
Posts: 71,940
I can not say if you compare the $commentstextline variable in showproduct against the $rowreviews one in revshow we do the same exact thing so I can not really say what is making it show that cause clearly if I go to the database and look at the review in there it has no line breaks or break tags stored so I dont see where showproduct has anything more to work with that revshow

There are no paragraph breaks and thats the puzzling part although I tested photopost also and it is the same way in comshow. I think it has something to do specifically with vb3 and on that page is something from vb3 that lets spaces not breaks be translated
__________________
Photopost Developer and Support Engineer

Please do not PM me for support or sales questions. Thank you for your understanding.
Chuck S is offline   Reply With Quote
Old December 30th, 2006, 12:02 PM   #11 (permalink)
Senior Member
Verified Customer
 
Join Date: Jun 2003
Location: London, UK
Posts: 562
It's also not parsing BBcode - maybe that holds a clue? - It's outputting it like this:

http://en.wikipedia.org/wiki/JoeSoap " target="_blank" class="bb-url"> JoeSoap
criscokid is offline   Reply With Quote
Old December 30th, 2006, 02:45 PM   #12 (permalink)
Photopost Developer
Verified Customer
 
Chuck S's Avatar
 
Join Date: Jun 2002
Location: Abingdon,MD
Posts: 71,940
It parses markups fine. Looks to me like your trying to do whole html code or something which its not going to do

http://www.reeftalk.com/reviews/revshow.php

Now I dont really know what else to say about getting line breaks that do not exist to show. Clearly looking at the review in the database there are as stated no line breaks or break tags so I dont know what makes space print on showproduct since there are no line breaks to convert.
__________________
Photopost Developer and Support Engineer

Please do not PM me for support or sales questions. Thank you for your understanding.
Chuck S is offline   Reply With Quote
Old December 30th, 2006, 05:13 PM   #13 (permalink)
Senior Member
Verified Customer
 
Join Date: Jun 2003
Location: London, UK
Posts: 562
Quote:
Originally Posted by Chuck S View Post
It parses markups fine. Looks to me like your trying to do whole html code or something which its not going to do.
I'm not trying to do anything special... in the review at /reviews/showproduct.php someone has used BBcode which contains a URL and a word - like this. It's not being parsed properly by revshow.php


I have EMS MySQL Manager Pro installed on my PC. I've just loaded my reviews table, gone to the latest record and the review field, pressed Ctrl C to copy the field then opened notepad and Ctrl V to paste the text.

Voila... there's paragraph breaks in the text.

I've gone back to examine the data in the actual review field of the record and I'm able to navigate around it and can see the paragraph breaks. They're not coded, special characherters or anything, they're just there... much like if you were typing someting in notepad or Word.
criscokid is offline   Reply With Quote
Old December 30th, 2006, 06:15 PM   #14 (permalink)
Photopost Developer
Verified Customer
 
Chuck S's Avatar
 
Join Date: Jun 2002
Location: Abingdon,MD
Posts: 71,940
In a mysql database if you had a line break or break tag it would usually show <br /> or /n/r/n etc

That is what I am saying. I am not disagreeing with you I have simply said looking at the code we clearly run the same stuff on the comments on showphoto as we do the revshow script so thats the stumper right here.

I am continuing testing dont worry but there be no easy answer to this since we do the same thing on both scripts
__________________
Photopost Developer and Support Engineer

Please do not PM me for support or sales questions. Thank you for your understanding.
Chuck S is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes Rate This Thread
Rate This Thread:

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is Off
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On


Similar Threads
Thread Thread Starter Forum Replies Last Post
Paragraph Formatting CGMathis Classifieds Bug Reports 4 December 18th, 2006 07:23 AM
Paragraph Formatting CGMathis ReviewPost How do I...? 10 December 17th, 2006 02:11 PM
RP3.31 Unapproved reviews appearing in 'Recent Reviews' block on /index.php criscokid ReviewPost Bug Reports 2 August 13th, 2006 01:06 PM
An extra 'return' is being added after each paragraph in the 'description block' criscokid ReviewPost How do I...? 2 August 13th, 2006 12:07 PM
Show list of products on /reviews/index.php criscokid ReviewPost Installation & Upgrades 6 November 22nd, 2005 02:29 PM


All times are GMT -5. The time now is 01:49 AM.

Powered by vBulletin® Version 3.8.1
Copyright ©2000 - 2013, Jelsoft Enterprises Ltd.
Search Engine Friendly URLs by vBSEO 3.2.0