RP 3.01 - Misc. Bugs(FIXED)

[WB]

A few miscellaneous issues we've encountering in 3.01:

Member's List:

Only shows one member, the admin. Other registered users are not shown.

Menubar:

After logging in, clicking on the profile link returns:

Script not called correctly. Navigate to a specific product, then click on the edit link.


Admin interface:

If I create a new usergroup and then try to delete it, I get:

You can't delete this usergroup.

Only recourse is to remove it directly from the db.


Show Categories:

The reviews column doesn't appear to be accurately tracking the number of reviews after some have been deleted. For example, we have 2 reviews left for one product. Numerous reviews have been added and deleted but the showcat page shows 3 reviews for said product.

There aren't any unapproved reviews not showing and I tried a recalcualtion in scan db in the admin interface but that didn't have any effect.


Moderation:

When a moderator is set for a category and certain users are set to be moderated, how can a moderator preview/see the review?

When I go to the 'Moderate Reviews' section, there is no link under the review column (just the non-linked title) so with many reviews to approve, no easy way to preview them/find them.

The remove link for a review appears to be incorrect:

adm-modcom.php?remove=X

The appove link is:

adm-misc.php?admact=modcom&approve=X

and it works fine so suspect that the remove link is a hold over from prior versions.

Templates:

For the customer service templates, the reviews are missing the 'rating' being displayed per review (like in the regular templates). Not sure if that is intentional or not but I'd assume that the overall rating should show in each review there.

Thanks.

[Chuck S]

Member's List:

Only shows one member, the admin. Other registered users are not shown.

not a bug it only shows people that have uploaded products

$query = "SELECT id, date, user, userid, bigimage, cat, SUM(views) AS tviews,COUNT(*) AS pcount,MAX(date) AS maxdate FROM {$Globals['rp_db_prefix']}products $phrase GROUP BY user $sortcode";

Menubar:

After logging in, clicking on the profile link returns:

Script not called correctly. Navigate to a specific product, then click on the edit link.

make sure your using the correct updated files from the distribution. I see my profile when I click on it on 4 different installs I have

Admin interface:

If I create a new usergroup and then try to delete it, I get:

You can't delete this usergroup.

try deleting the code in bold

Content visible to verified customers only.

DELETE THIS LINE

Content visible to verified customers only.

add in bold the two thing on the typecast line

Content visible to verified customers only.

then alter in bold on this line

Content visible to verified customers only.

The reviews column doesn't appear to be accurately tracking the number of reviews after some have been deleted. For example, we have 2 reviews left for one product. Numerous reviews have been added and deleted but the showcat page shows 3 reviews for said product.

There aren't any unapproved reviews not showing and I tried a recalcualtion in scan db in the admin interface but that didn't have any effect.

Well the code above below for delete looks correct to me and it works on my install I just tested deleting things etc. I added a review and it properly updated as well. Did you run all upgrade scripts before this one right? Cause I beleive the 2.8-2.91 added a numreviews column to the products table and calculated the number of reviews and that is needed to work right. I show in 3.01 adding and deleting comments works right

Upgradecategories function will not correct this count since its not in the cats table. Numreviews is not autocalculated on scan database

Content visible to verified customers only.

[Chuck S]

Moderation the remove link should be this

adm-misc.php?admact=modcom&

not

adm-modcom.php?

I highly think with somethings you have a mix of old and new files here buddy because note this line below

Line 1570 of adm-misc.php has a link right to the product right here

<td class=\"{$Style['tddetails']}\" align=\"center\"><a target=\"_blank\" href=\"{$Globals['maindir']}/showproduct.php?product=$cproduct\">$cproduct</a></td>

and the full review is shown in the review column

Templates:

For the customer service templates, the reviews are missing the 'rating' being displayed per review (like in the regular templates). Not sure if that is intentional or not but I'd assume that the overall rating should show in each review there.

well I can look at correcting that but that is how that template was written

[WB]

not a bug it only shows people that have uploaded products

Thanks for the explanation. Not following why a member's list would only show those who have uploaded.

make sure your using the correct updated files from the distribution. I see my profile when I click on it on 4 different installs I have

Definitely using the updated files, unless of course some other files were updated that weren't included on the 3.01 list.


try deleting the code in bold

Thanks.



Well the code above below for delete looks correct to me and it works on my install I just tested deleting things etc. I added a review and it properly updated as well. Did you run all upgrade scripts before this one right? Cause I beleive the 2.8-2.91 added a numreviews column to the products table and calculated the number of reviews and that is needed to work right. I show in 3.01 adding and deleting comments works right

Upgradecategories function will not correct this count since its not in the cats table. Numreviews is not autocalculated on scan database

Yes, I started with the 2.5 upgrade and went all the way up when I upgraded.

Can't seem to see any obvious reason but the counts are incorrect in some instances. A product with 2 reviews, shows 3 on the cat page. If I add another review it goes to 4, etc.

I see a numreviews field in the products table if that is the one you are referring to.

Thanks.

[WB]

I highly think with somethings you have a mix of old and new files here buddy because note this line below

Line 1570 of adm-misc.php has a link right to the product right here

<td class=\"{$Style['tddetails']}\" align=\"center\"><a target=\"_blank\" href=\"{$Globals['maindir']}/showproduct.php?product=$cproduct\">$cproduct</a></td>

and the full review is shown in the review column


I have that line in my adm-misc file so looks like I have the latest.

I see the showproduct link but not the full review inline. I'll have to go take another look at that. Perhaps it is being truncated.

What about the approve/remove links on your end? Remove still seems to be a holdover on my end.


Templates:

For the customer service templates, the reviews are missing the 'rating' being displayed per review (like in the regular templates). Not sure if that is intentional or not but I'd assume that the overall rating should show in each review there.

well I can look at correcting that but that is how that template was written

Thanks for clarifying. Would be helpful I think if the overall rating was there.

[Chuck S]

Think I answered the one about remove moderation

adm-misc.php?admact=modcom&amp;

not

adm-modcom.php?


showmembers works the same way it works in photopost and classifieds it pulls the users from the products tables with how many products etc and produces a list. It is not a members list of all users in your forum.

I think I documented all the files on the 3.01 upgrade but just be safe and replace all since I am 100% sure the FULL review is shown.

Now line 426 of showproduct1.tmpl if you want the rating display add in bold

Content visible to verified customers only.

I need to update the filed with an update in inc_reviews.php for a usergroup permissions switch in that photo block that Michael found working on Photopost so I will throw in the rating thing the usergroup delete fix and the remove modcom fix

[WB]

Great, thanks for the response.