Thumbnail-round Error - Images not displayed...(FIXED)

Detomah · September 5th, 2005, 06:14 PM

Ok, this is hopefully a really basic error and one which will hopefully be easily fixable.

http://www.totalformat.com/reviews/showcat.php?cat=12

If you look at the category above, you will see that the images are not showing for all of the products. However, If I change the style to be normal thumbnails, they show up and work fine.

Makes me think it is an issue with the Thumbnail-round bit, but I aint sure what exactly.

Could you fix it please.

I also notice that the link in each of those thumbnails is a bit bizarre and seems like a bit of a waste of space, how can I get it to make the thumbnail link in the product images to link to the actual product rather than just back to the category as it does?

Chuck S · September 5th, 2005, 06:21 PM

Well I see your problem. We dont use that old stylesheet anymore your using for the admin section.

http://www.totalformat.com/reviews/s...rlay-round.gif

I would suggest if you continue to want to use that old stylesheet. I would suggest you copy the images from the reviewpost images directory into the dark-borders directory

Detomah · September 5th, 2005, 06:52 PM

Quote:

Originally Posted by omegatron

I would suggest if you continue to want to use that old stylesheet. I would suggest you copy the images from the reviewpost images directory into the dark-borders directory

Ok, i've just tried that and got the exact same thing.

So I just swapped to the default stylesheets and still getting the same thing.

Edit: Ok, i've tried all the different image borders, with various different stylesheets and for some reason, the only one that is fuctioning properly is the default "thumbnail" one?

Chuck S · September 5th, 2005, 07:02 PM

In showcat.php find this and make the change in bold

$catimage = get_thumbtmpl( $id, $thumbrc, $height, $width, $thumbtag, $pcat, $thislink );

Detomah · September 5th, 2005, 07:07 PM

Quote:

Originally Posted by omegatron

In showcat.php find this and make the change in bold

$catimage = get_thumbtmpl( $id, $thumbrc, $height, $width, $thumbtag, $pcat, $thislink );

It seems to be liking that a lot more, thanks.

How about the other query, regarding the actual link on product thumbs? That baffles me, i'm not sure if it's meant to be like that or a bug or what?

The title text for a product says: http://www.totalformat.com/reviews/s...&cat=12&page=1

But the product thumb for the same item says: http://www.totalformat.com/reviews/s...cat=12&ppuser=

Which just leads you back to the same place?

That's not right surely?

Chuck S · September 5th, 2005, 07:16 PM

download the latest build upload showcat.php and make the one change I noted above and you should be fine

Detomah · September 5th, 2005, 07:29 PM

Quote:

Originally Posted by omegatron

download the latest build upload showcat.php and make the one change I noted above and you should be fine

I'm running 3.01 I did the upgrade before getting the thumbs error. I've made that one change as suggested and that gets the thumbs showing, but they link to the wrong place still?

http://www.totalformat.com/reviews/showcat.php?cat=2

If you look at the links on those images.

I have just noticed also though, if I turn spider-friendly urls on, none of the category links or anything works? Not sure if that would have any relevence, probably not, but hey.

Chuck S · September 5th, 2005, 08:44 PM

in the build download is this and see $thislink. that passes the link to showproduct. Your using an older download it looks like to me

Code:

Content visible to verified customers only.

Detomah · September 6th, 2005, 03:54 AM

Quote:

Originally Posted by omegatron

in the build download is this and see $thislink. that passes the link to showproduct. Your using an older download it looks like to me

This is still the showcat.php file we are referring to right?

The $thislink was in the line of code which you said to change the bold bit in, i've tried it with the $thislink code in it and out of it and it made no difference.

The build download i'm using was only downloaded yesterday and is 3.01, I replaced all the old files with the new ones.

The bit of code quoted above doesn't match the code in the showcat.php file I have though???

I've replaced the code I have with the bit quoted above and it is now working, but I'm now really confused, why it isn't the same anyway?

Arnie · September 6th, 2005, 08:24 AM

It it a bug that even if a product has no images it still shows the thumbnail in showcat?

(e.g. http://www.arniesairsoft.co.uk/revie...cat.php/cat/16 - steyr image not there)

SHould it be blank, or display a "no image yet" spacer?

Say something like this in showcat.php:

if ($thumbtag =="") $thumbtag = $Globals['idir']."/nothumb.gif";

just before:
$catimage = get_thumbtmpl( $id, $thumbrc, $height, $width, $thumbtag, $pcat, $thislink );

edit: I fixed mine with the above code which works very nicely.

While I'm at it, here's a revised version of thumbnail-round.tmpl:

Code:

Content visible to verified customers only.

Background position should not be center, as there's a black shadow to the bottom that moves the center of where you want the image upwards. Repalcing with 50%/40% as above works very nicely.

Chuck S · September 6th, 2005, 08:59 AM

Okay well Arnie

The solution is quite simple for that

if ( file_exists($checklink) ) {
$image_stats = @getimagesize( $checklink );
$width = $image_stats[0];
$height = $image_stats[1];

$catimage = get_thumbtmpl( $id, $thumbrc, $height, $width, $thumbtag, $pcat, $thislink );
}

Move it up into the if statement where it checks to see if there is an image to get the width and height on.

The templates for those all have background position center already.

Arnie · September 6th, 2005, 09:14 AM

Yes the templates do have it set to center; however with a large shadow image to the bottom the inset product image wants to be slightly higher, otherwise for a thin image you get a larger black bar at the top than the bottom.

Look at the Siemens thumbnail on this page:
http://www.totalformat.com/reviews/s...p?cat=11&page=

The thumbnail is set too low, hence the imbalanced black bars top and bottom.

If you do what you ahve suggested to the $catimage statement it won't work.

If one product has no thumbnail, it picks up the previous product's definition (because $catimage is still definined from before and it's not be reset) and will display the previous thumbnail again.

Chuck S · September 6th, 2005, 09:20 AM

I dont think so my friend. I don't use the thumbnail templates cause my images are so unique in size but here is a test with the code I stated and thumbnail round on

http://www.reeftalk.com/reviews/show...p?cat=36&page=

It works just as I stated it works if no image exists in the loop $catimage is then empty and not defined. Remember the whole definition itself is within a while loop

Arnie · September 6th, 2005, 09:34 AM

Which one of those products has no image assigned to it?

Remove the image for one of those products and then have a look. You'll see that it will pickup the image from the previous product.

You have $catimage nested inside a while statement:
while ( $row = mysql_fetch_row($queryv) ) {

If you stick it inside an if statement, such as "if ( file_exists($checklink) ) {" and there's no image, $catimage retains the value from the first iteration and displays that.