Wierd subcat link bug(FIXED)

[Arnie]

If I go to a subcategory, the links on the images correclty link to the product listed, however:

Click the link tot he cubcategory you are in on that page and it'll redirect you from reviewpost/showcat.php/cat/16 to this page /reviewpost/showcat.php?cat=16&page=1 (for example)

Now some images next to each product link to: /reviewpost/showcat.php/cat/-1/ppuser/

Any ideas?

[Arnie]

Okay just to make this even wierder, different images get that broken link upon a refresh.

[Arnie]

Okay looking into this further:

445/447 of showcat.php are:

Content visible to verified customers only.

But the a-href tags are already supplied by$catimage as it's the output from the function get_thumbtpl (in pp-inc) which is defaulting because of the code:

function get_thumbtmpl( $id, $imgtag, $height, $width, $thumbtag, $whichcat = -1, $thislink = "" ) {

$whichcat seems to be set to -1 no matter what? muh?

As a result we get an href tag around a table with a junked href tag inside that.

I think the -1 and null setting for $thislink are junk and debug gumf? I removed the ="-1" bit and the $thislink preset and it all worked for me.

[Chuck S]

I beleive the fix here is real simple. THANKS

$catimage = get_thumbtmpl( $id, $thumbrc, $height, $width, $thumbtag, $pcat );

[Arnie]

How's about reducing this line (~447 showcat.php):

Content visible to verified customers only.

.. to this?

Content visible to verified customers only.

Otherwise you get some very wierd effects in FireFox plus there's a needless link within a link otherwise.

[Chuck S]

Arnie

I dont know what you mean by needless link

If you set the line that I note to add the $pcat variable the link then also becomes a perfect link to the actual product just like the title next to it

I use Firefox by the way

[Chuck S]

If I go to the page your talking about example below the links are product links

http://www.reeftalk.com/reviews/showcat.php?cat=36

[Arnie]

Doesn't function get_thumbtmpl always return a string with the correct ahref tags in it?

If so, why the need to enclose the returned string ($catimage) in showcat.php inside another ahref link?