PhotoPost Photo Gallery Sales PhotoPost Sales Toll Free Phone Number
Mon-Fri 9am-4pm EST
  PhotoPost Photo Sharing Photo Gallery    Visualize community tm
| | | | | | | | |

Go Back   PhotoPost Community > PhotoPost Support > ReviewPost Pro Support Forums > ReviewPost Bug Reports

ReviewPost Bug Reports Let us know about any post installation problems you are having with ReviewPost.

Reply
 
LinkBack Thread Tools Rate Thread Display Modes
Old July 20th, 2005, 06:46 AM   #1 (permalink)
Member
Verified Customer
 
Join Date: Jun 2005
Posts: 179
Unparsed vars in showcat.php

The variable "$si" is not checked or sanitised upon input. There's also a wierd code obscurity.


First the code obscurity on line 112:
Quote:
$searchterms = $si;
$searchterms is never used or referenced in showcat.php until around line 197 when it is reinitialised. Line 112 therefore looks redundant to me.

Going back to sanitizing the variables (around line 112):

Code:
Content visible to verified customers only.
"trim" merely removes uneeded whitespace before and after the string and explode then splits the string into interative chunks whereever there's a space (' '). The initial variable passed in ($si) has never been checked or cleaned up before it's used.

Because of this I'm pretty certain that the security issue mentioned here is directly applicable to ReviewPost:

http://marc.theaimsgroup.com/?l=bugt...5342909640&w=2

(I'm refering to the showgallery.php references which apply to showcat.php as it's based on the same code)

With reference to the security listing above ( http://marc.theaimsgroup.com/?l=bugt...5342909640&w=2 ) $cat in showproduct.php does not look to be sanitised either, meaning that that code is most likey going to fall foul to the flaws listed against showgallery.php as again showgallery and showcat are as far as I can tell the same code (I don't have photopost though.. so I'm doing my best to make an educated guess here)
Arnie is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes Rate This Thread
Rate This Thread:

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is Off
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On


Similar Threads
Thread Thread Starter Forum Replies Last Post
showcat.php question ace67 ReviewPost Installation & Upgrades 4 October 21st, 2005 04:08 PM
Is this possible? Show the name from the category in showcat.php?cat=all wrang Classifieds Suggestions 0 September 18th, 2005 06:01 PM
Unparsed vars in member.php Arnie ReviewPost Bug Reports 0 July 20th, 2005 07:08 AM
Problem with showproduct.php and showcat.php jed423 Classifieds Bug Reports 4 November 14th, 2004 10:48 AM


All times are GMT -5. The time now is 09:27 AM.

Powered by vBulletin® Version 3.8.1
Copyright ©2000 - 2013, Jelsoft Enterprises Ltd.
Search Engine Friendly URLs by vBSEO 3.2.0