2.91 & vB3 integration - double spacing

djroketboy · April 15th, 2005, 07:05 PM

I'm getting double spacing on all posts in my reviews section even with the vb3 enhanced templates, which i thought should be wysiwyg.

Is there a setting to resolve this that i missed?

http://www.hpoa.org/reviews/showproduct.php/product/163

Chuck S · April 15th, 2005, 08:04 PM

We use the same convert_returns thing we use in every other field

$reviewtext[$itemnum] = convert_returns($reviewtextline);

You could however change the above line in showproduct.php to this

Code:

Content visible to verified customers only.

djroketboy · April 15th, 2005, 08:22 PM

that worked perfectly

thank you!!

what about the double spacing in the products?

Chuck S · April 15th, 2005, 09:18 PM

there is not a wysiwyg editor or template for uploads. Our convert_returns function is used and is correct. Your products looks spaced right to me. If your hitting return twice then there is your issue as your trying to do a WYSIWYG where it isnt one.

djroketboy · April 16th, 2005, 08:38 PM

if i create a account for you on my site, will you create a product, and see? I am not creating any extra spacing, as i know it's not WYSIWYG for the product uploads. But the spacing should not be this far off.

I created this one if it makes sense, just to show you what it's doing.

http://www.hpoa.org/reviews/showproduct.php?product=166

Chuck S · April 16th, 2005, 09:26 PM

You do not hit double spaces but sure you can post me an account

memobug · April 16th, 2005, 10:24 PM

Hi Chuck

I have vb3 too. If you hit return once you get double spacing in the output. Is that the way it's intended to work, because I am confused too? I don't believe it is working right!

There is no way to get single spacing, i.e:

Quote:

this
that
the other

Single spacing in the textarea comes out double spaced in the output:

Quote:

this

that

the other

Regards,

Matt

Chuck S · April 16th, 2005, 10:44 PM

Yes a return is converted to double space line break for paragraphs. The amazing thing is its always been this way. For people that don't like the way it works editing the convert_returns function in pp-inc.php and remove one of the tags

memobug · April 17th, 2005, 06:27 AM

Quote:

Originally Posted by omegatron

Yes a return is converted to double space line break for paragraphs. The amazing thing is its always been this way. For people that don't like the way it works editing the convert_returns function in pp-inc.php and remove one of the tags

Hi Chuck

Sorry this is a new bug associated with reviewpost. It does not live in the convert_returns function.

Photopost 4.8.2 -5.02 do not force double space line breaks and they share the identical function

Quote:

function convert_returns( $convert_returns ) {
$convert_returns = str_replace( "\n\r\n", " ", $convert_returns);
$convert_returns = str_replace( "\r", " ", $convert_returns);

return ($convert_returns);
}

PHOTOPOST 4.8.2 - OK!
See first comment on this tree - no problem - one word per line!

PHOTOPOST 5.0.2 - OK!
See first comment on this game - no problem. One word per line

REVIEWPOST 2.9 vbe - Messed up!
See the product description and the comments - each newline is doublespaced

Regards,

Matt

Chuck S · April 17th, 2005, 07:34 AM

Exactly they share the same function and works fine

http://www.reeftalk.com/reviews/show...hp?product=430

I just did a normal reply hitting return maybe I am missing something here but I am running 2.91 and I dont see anything different other than what I posted above for people using vb3 not wanting to use WSYIWYG

memobug · April 17th, 2005, 02:48 PM

Quote:

Originally Posted by omegatron

Exactly they share the same function and works fine

http://www.reeftalk.com/reviews/show...hp?product=430

I just did a normal reply hitting return maybe I am missing something here but I am running 2.91 and I dont see anything different other than what I posted above for people using vb3 not wanting to use WSYIWYG

Hi Chuck. You are getting double spacing in your vBenhanced reviewpost too. Photopost doesn't do this and hasn't done this as long as I can remember.

After comparing rp's showproduct.php with pp's showphoto.php I found and corrected the following two bugs in showproduct.php v2.91
>>>It isn't appropriate to call convert returns in vb enhanced mode.

NOTE: These bugs only affect vB users! These fixes correct double spacing in the Product Description and Reviews fields when displayed by showphoto.php

These line numbers come from version 2.91 of showphoto.php. However, the bugs themselves are the same in 2.9. The line numbers are similar.

Step 1: Correct display of Product Description

FIND around LINE 271
$desc = convert_markups( stripslashes($desc) ); $desc = convert_returns( $desc );

and replace it with this:

Code:

Content visible to verified customers only.

Step 2, Correct display of reviews

FIND around LINE 478
$reviewtext[$itemnum] = convert_returns($reviewtextline);

and replace it with this:

Code:

Content visible to verified customers only.

The good news is that it's only a display issue. The content in the database is "single spaced".

Regards,

Matt

djroketboy · April 17th, 2005, 02:52 PM

Chuck, we aren't talking about the actual review any longer, now we are talking about the product. You posted a fix for the review up top, which worked perfectly, and should be included in the next release of ReviewPost.

Your post about the actual product was spot on as well, but it shouldn't double space by default. Pressing return should drop to the next line, pressing enter twice should give you a double space, that's all we are saying.

PhotoPost Classifieds works this way; I do not have PhotoPost to compare. But from looking on all the sample sites they look to be proper. Your site double spaces by default as well, which makes your product descriptions look longer, and takes up more space.

http://www.reeftalk.com/reviews/show...hp?product=430

Is the product you referenced, look at your product description; that looks right to you?

Chuck S · April 17th, 2005, 04:47 PM

See here is the thing. You say classifieds is correct reviewpost isnt.

The coding is exactly the same for the convert returns which adds two break tags. on a line break

Beleive me I would suggest something different if I could other than what I posted above. If your not happy with the double line spacing just alter the convert_returns function to only do one tag

memobug · April 17th, 2005, 05:17 PM

The difference in the code is in SHOWPHOTO/SHOWPRODUCT not in convert_returns

The other products don't doublespace with vbulletin. Reviewpost does. I posted the bugfix above. We just need to roll this into the next release, Chuck. showproduct.php is the problem.

Regards,

Matt

Chuck S · April 17th, 2005, 05:25 PM

I beleive earlier in this thread I posted this fix for you at least the convert returns for reviews

What I am saying though Matt is everyone says classifieds is correct yet classifieds and reviewpost are the same in showproduct there is no code removing the convert_returns function in classifieds yet everyone says it works.

I think half the issue here is since the WYSIWYG comments we code in people tend to now try and enter there upload descriptions the same way and this is where the problem lies. We dont do WYSIWYG on product descriptions hense there is no issue that I see and the convert returns has not changed in many versions.

I think you see where I am going here. The reviews which is a bug I posted a fix for and submitted to Michael already since we do do WYSIWYG in comments.

I have made a test post and find no issue with things on posting a description.

http://www.reeftalk.com/reviews/show...p?product=1762

Remember if your typing a paragraph you just keep typing. The minute you hit return it signals a new paragraph which has always been the way our products work. The confusion here lies in the VB3 WYSIWYG and since we are allowing more and more VB3 stuff in our products.

I think people are purposely hitting those returns to make things look the way they want thinking things are WYSIWYG but its not. Our upload page is not WYSIWYG it yet.

memobug · April 19th, 2005, 04:49 PM

Hi Chuck, This double spacing problem is evident all over your site, particularlly in product descriptions like these

http://www.reeftalk.com/reviews/show.../cat/36/page/1
http://www.reeftalk.com/reviews/show.../cat/38/page/1
http://www.reeftalk.com/reviews/show.../cat/38/page/1
http://www.reeftalk.com/reviews/show.../cat/38/page/1
http://www.reeftalk.com/reviews/show.../cat/36/page/1

Do you see all those nasty double spaced paragraphs in the description? It looks buggy to me!

Anyway I fixed mine and I am happy.

Now I can post single-spaced paragraphs in the Product Description and Review comments, like This product description and review (note the spacing between headings and the paragraph that follows.)

I was hoping to help improve reviewpost by suggesting you incorporate that bugfix in the next revision but if you think Reviewpost should doublespace and Photopost should not, that's cool too. I can work around it.

Regards,

Matt

Chuck S · April 19th, 2005, 05:44 PM

Matt

Again as stated the code is the same in Classifieds Reviewpost and Photopost for photo descriptions there is no code difference at all. Thats what I am saying. We dont do WSYIWYG in product uploads yet.

Yes this is a good suggestion for Reviewpost 3.0 or for any version of our product the next go around.

I posted the fix for reviews because I consider that a bug for reviews when we do use WYSIWYG

memobug · April 19th, 2005, 09:47 PM

Quote:

Originally Posted by omegatron

Matt

Again as stated the code is the same in Classifieds Reviewpost and Photopost for photo descriptions there is no code difference at all. Thats what I am saying. We dont do WSYIWYG in product uploads yet.

Chuck I have pointed out the differences a couple of times. Either you don't have the latest downloads or you just don't want to see it. Please try again:

Here's Reviewpost 2.91 showproduct.php line 271 downloaded just now:

Code:

Content visible to verified customers only.

Here's Photopost 503 showphoto.php lines 579-580 downloaded just now:

Code:

Content visible to verified customers only.

I am sorry to disagree with you, but you are wrong. If you can't see the difference in the lines above, just say so and I will give up now and admit that you are right and Reviewpost is perfect.

Regards,

Matt

Chuck S · April 19th, 2005, 09:54 PM

Actually we have not been talking photopost here. It was brought up that classifieds displays right reviewpost does not in this thread. Based on that point as I have said twice in this thread the coding is the same.

In classifieds showproduct.php line 247

Code:

Content visible to verified customers only.

There is what I have based my response on what you guys have stated.

Yes Photopost is different but that is not what was being discussed in this thread.

memobug · April 20th, 2005, 01:41 AM

Hi Chuck,

I am very glad that we've come to an understanding that the behavior and coding of photopost and reviewpost differ with respect to the way they perform on linefeeds in the text areas. I hope we can get this sorted in a future release. I have this aspect of Reviewpost working well now by applying the Photopost coding to it.

Quote:

Originally Posted by omegatron

Actually we have not been talking photopost here..

Chuck I think you might be confused. I didn't mention Classifieds, it was DJRocketperson who did and I think you latched onto that. I have been comparing Reviewpost performance with Photopost all along by name and function in posts 9,11,16 and 18. I don't think I have mentioned Classifieds at all.

Regards,

Matt