2.84 ... search is broken

[Mikan]

It seems that at least all 2.8x's have several bugs in search.php - so search is practically useless.

The "only" thing that works is "Search all fields" because otherwise you'll end up having errors like:
---------
MySQL error reported!

Script: search

Query: SELECT c.id,c.username,c.userid,c.date,c.comment,c.cat,c.product,p.bigimage,p.cat,p.userid FROM comments c LEFT JOIN products p ON p.id=c.product WHERE c.comment != '' AND ((c.comment LIKE "% Garmin%") OR (c.comment LIKE "Garmin%"))

Result: Table 'viperalley.comments' doesn't exist

Database handle: Resource id #4
---

(those 'c.comment' should be 'c.review' and 'comments' should be 'reviews')

Then there are a couple of other lines in that script where 'comments' should be also 'reviews'.. and then there's also an extra space in 'AND ((c.comment LIKE \"% $key%\") )'

.. see that % $key% - it should be %$key%

Then there are wrong links like (this is twice...) :
$ucuser[$itemnum] = "<a href=\"{$Globals['maindir']}/showphoto.php?photo=$comphoto\">$cusername</a>";

SHOWPHOTO.PHP and ?photo..... ?

Then there are no functions what to do when "what=title" or "what=titledesc" so when those are used script jumps straight to the end where is this "forward" thing....

[Chuck S]

The keys are seached in another file not the seach file for title desc etc but here is a cleaned up file without the photo or comment things.

[Mikan]

Thanks, but it's still broken.

LEFT JOIN {$Globals['pp_db_prefix']}products p ON p.id=c.product WHERE c.comment != '' $catcheck

c.comment .. twice..

And there are still issues at least with "search title only" and probably with "search title and description".

By the way.... when you get those results from searches above it would be a lot better if the text under product would include also the name of the product and not only the name of the person who posted that product originally.

[Chuck S]

The above file has been fixed to remove the c.comments as your right however I dont follow you on your thinking as far as title and description not working.

They work just fine. I have one product with the title of "ecosystem" in the title on over 800 products and I do a search and that one product is returned.

If I follow the same logic and search for "ecosystem" in both title and desc it brings back 5 results which is correct as other descriptions have this word in it.

You can try it here and see it works fine

http://www.reeftalk.com/reviews/index.php

[Mikan]

Originally Posted by omegatron

http://www.reeftalk.com/reviews/index.php

Ok, if you go there you'll see on "Recent Products" this:

SPECTRAPURE Liter Meter III

Ok, let's go to search and put this to "Keywords"

SPECTRAPURE

Check "search title only" & "All Categories" and hit Execute search ->
"This category does not contain any products."

Shouldn't that search find that " SPECTRAPURE Liter Meter III " product?
So it seems that "search title only" doesn't work.

Then... if you go back and check "search title and description" and hit Execute - now it works but I think that is because it is mentioned in description - but if that keyword exists only in title that search will come up empty - so that option searches description ok, but it doesn't search title even though it should - I think.. I'm not 100% sure about this.

[Chuck S]

SPECTRAPURE IS NOT A TITLE

It is a manu or manufacturer. We never search for manufacturer or state that we do. It is title or description or keywords or comments

[Mikan]

Oh? Now I'm a little bit confused - what is actually that "title". For some reason I kind of thought that it's the manufacturer and model combined.

So if you go here:
http://www.reeftalk.com/reviews/show...p/product/1773
...what is the title?

[Chuck S]

Liter Meter III

Nope the title is the title not the manufacturer.

Search works like it should as we dont presently search the manu field although its not a big deal to alter the file showcat.php to add the manu in there and I will pass along to Michael just so people dont get confused on it.

[Tom1234]

Does RP 2.9 search the manu field?

[Chuck S]

its in there yes