V 2.8.2 - Email bugs

[Bryan Ex]

Two email issues I've noticed so far...

If someone adds a product AND provides a review they receive duplicate email notices every time someone posts to that listing (seems to be the only time this occurs).

The notice received when subscribed to a product has a bad link for disabling further notices - "Malformed parameter". Seems the notifyid is missing;

.../reviews/reviews.php?notify=off&notifyid=&product=7

[Bryan Ex]

One free bump after 2 days... isn't them the rules?

[Michael P]

Check the nofiy table and see if there are more than one entries for the userid and product id in the table.

[Bryan Ex]

Yes there is. If a person posts a new product AND reviews that same product it's being entered twice with different notifyid's - userid and productid are the same.

If someone only posts a product and does not review it OR only posts a review, only a single listing has been entered.

[Michael P]

Well, I assume this means the user has asked for double notifications, but we can add a check to see if they are already in the list first.

[Bryan Ex]

That's the part I don't quite follow though. If someone is posting a review they are not asked about notifications... just when uploading the original listing. It should be as in in the gallery where the photo upload has the option of being notified but comments do not unless the person selects it from the showgallery page. If I post a photo, a member comments, and I responds I still only get a single notice for each comment. With Reviewpost I get two for each post if I've uploaded and reviewed.

While I have your ear - any suggestions on how to include the notifyid variable in the email being sent (link to disable further notices);

.../reviews/reviews.php?notify=off&notifyid=&product=7

[Bryan Ex]

Originally Posted by Bryan Ex

... suggestions on how to include the notifyid variable in the email being sent (link to disable further notices);

.../reviews/reviews.php?notify=off&notifyid=&product=7

LOL... kinda sucks being this far down the support forms. I'm used to the top half for PhotoPost galleries.

[Bryan Ex]

The notice received when subscribed to a product has a bad link for disabling further notices - "Malformed parameter". Seems the notifyid is missing;

.../reviews/reviews.php?notify=off&notifyid=&product=7

How do I fix this?

[Bryan Ex]

Am I in the "good books" this week or not yet?

[Michael P]

I was in Dallas, Texas for the Viper Owners convention; so was out for four days.

In looking at the code, if reviews.php is called with notify set to "on", it will insert a record into the notify table without checking to see if a record already exists. This would suggest that the reviews.php script is possibly executing this code (do you get an "enabled" message, because it would forward if it did).

The email is using the variable $getuserid (emails.php, line 27); so we might need to change line 298 in reviews.php to use $getuserid instead of $tuserid:

list( $getuserid, $usernm, $useremail ) = get_userinfo("", $notify_user);

[Bryan Ex]

Okay... making the change above the notifyid is still missing in the email notice but strangely enough, only a single notice is now sent (which is how it should work).

[Bryan Ex]

Any other suggestions on how to include the notifyid?

[Chuck S]

In emails.php language file the notifyid is $getuserid so it should work fine.

I will do some testing on my install

[Bryan Ex]

Any news on this?

[Chuck S]

Nope I can not break it. Did you do the fix Michael posted above?

The email is using the variable $getuserid (emails.php, line 27); so we might need to change line 298 in reviews.php to use $getuserid instead of $tuserid:

list( $getuserid, $usernm, $useremail ) = get_userinfo("", $notify_user);