PP 5.3: 24 hours upload limit error

[snoopy5]

Originally Posted by Chuck S

Content visible to verified customers only.

I do not see anything wrong with Michael's choice of wording there. It never says the image is too small. It says to upload a smaller one cause its too wide or too tall.

Please read my post above again. Yes, in the code it sais it, but not in reality. This is my point.

The messages in the code (actually 3 different messages: too wide, too tall and too small) are correct.

But in reality, it uses only the one of them ("too small" code).

In other words: it does not use all the choices provided in the code. I tested this with images that are too big (in pixel size): The message pops up, the image would be too small which is NOT true.

The image is too big (pixel), but it uses not the wording for it. Normally it should say either it is too tall or it is too wide. But it does none of both. It only sais it is too small. Maybe the problem is, that both criteria (too wide and too tall) are met. So photopost does not know which to use and use then a third option, which is totally wrong in this situation.

Just try it out on your testboard. Use a minimum and a maximum image size in admin panel and try then to upload a bigger (in pixel, not in KB) image and look at the error message.

[Chuck S]

I get the correct message of too wide or too tall in my testing. This works just fine and the coding would be correct. If I set my maxheight and maxwidth variables to say 100 and upload an image that say is 200 wide I get this.

Your graphic is too wide!

Please upload a smaller one.

If you are just getting the smaller message and nothing else it is because of how you have it set as far as minheight and minwidth. Those are entirely different settings. Look at this code here

Content visible to verified customers only.

For you to get that message the image your uploading has to be smaller than what you have specified as the minheight and minwidth settings for an image. So look into your settings in Admin => Upload Options to correct them.

[snoopy5]

Originally Posted by Chuck S

I get the correct message of too wide or too tall in my testing. This works just fine and the coding would be correct. If I set my maxheight and maxwidth variables to say 100 and upload an image that say is 200 wide I get this.

Did you set up in your admin panel a maximum AND minimum width and height before testing?

Originally Posted by Chuck S

If you are just getting the smaller message and nothing else it is because of how you have it set as far as minheight and minwidth. Those are entirely different settings. Look at this code here

For you to get that message the image your uploading has to be smaller than what you have specified as the minheight and minwidth settings for an image. So look into your settings in Admin => Upload Options to correct them.

I do not understand this/ I do not know what could be wrong in my admin settings:

I have in my admin setting 400 pixel as the minimum requirement for both, width and height and 1000 Pixel as a maximum allowed Pixel size for both sides of the image.

So what shall be wrong with these setting?

[Chuck S]

Is the image height and image width of the image the user is uploading either one smaller than 400?

Look at the conditional clause here. Let's pick this apart cause the only way you can get this message would be if the image width or height is below your minimum settings

Content visible to verified customers only.

Obviously you are not triggering the too wide or too tall because the image is not over 1000. Therefore the image has to be too small either in width or height. If either of these two triggers are true then your upload will die.

Content visible to verified customers only.

This will return true if your global min width is greater than 0 and the imagewidth uploaded is smaller than that global min width

Content visible to verified customers only.

This will return true if your global min height is greater than 0 and the imageheight uploaded is smaller than that global min height.

Looking at this then this is the only way to trigger this warning. I set my upload settings to 1000 max and 400 min just like yours and uploaded an 800x636 image fine. If I try to upload an image that has a smaller width or height then the min settings I correctly get the small diewell.

[snoopy5]

Hi Chuck, I am running crazy.

I just tried it again with images of different sizes - exact same images as yesterday, but the alert messages are now correct. I can not replicate the message error anymore !!!

The only explanation I have is that this had to do with the upload information error we fixed yesterday night. I did not do further testing since I changed the code yesterday night and now it works properly (too tall and too wide appears as message).

Sorry for the confusion and extra work. I should obviously work more during daylight and less during nights...

So it is all fixed now. Thanks

[Chuck S]

Yeah you where most likely encountering files still on the server uploads directory hense which is why once you cleared the entire uploads directory you deleted all those files.

Just one more not on the unlink comment in the small code you want $tmpdir and not $realname

[snoopy5]

Originally Posted by Chuck S

Just one more not on the unlink comment in the small code you want $tmpdir and not $realname

Do you mean this part:

------------------
// Too small?
if ( ($Globals['minwidth'] > 0 && $imagewidth < $Globals['minwidth']) || ($Globals['minheight'] > 0 && $imageheight < $Globals['minheight']) ) {
@unlink($imgdir);
diewell("Dein Bild ist zu klein!<br /><br />Bilder müssen mindestens {$Globals['minwidth']}x{$Globals['minheight']} gross sein.");
}
---------------


Are you sure? It worked with $imgdir (your mod of yesterday)

[Chuck S]

Bingo

Yes It Works

[snoopy5]

Hi Chuck,

since I uploaded a newer downloadfile of Photopost 5.31 (as of July 2006) than my old one of 5.31 (as of April 2006), I have the same problem again.

So this problem was even not fixed in the newer upload file, just for your records.

I changed today the exact same parts as last time as described in this thread on page 1. But this time it does not work anymore. I still get the alert, that I uploaded already an image within the last 24 hours.

I also tried already to use $tmpdir instead of $realname, but no difference.

I also deleted all upload folders beforehand by the way.

This is my code currently after the changes:

----------
$imgdir = "{$Globals['zipuploaddir']}/{$User['userid']}/$realname";

// Too big?
if ( $imagewidth > $maxwidth )
{
if ( $Globals['resizeorig'] == "yes" )
{
$resizeorig = 1;
}
else
{
@unlink($tmpdir);
diewell( "Das Bild ist zu breit!<br /><br />Bitte lade ein kleineres hoch." );
}
}

if ( $imageheight > $maxheight )
{
if ( $Globals['resizeorig'] == "yes")
{
$resizeorig = 1;
}
else
{
@unlink($tmpdir);
diewell( "Das Bild ist zu hoch!<br /><br />Bitte lade ein kleineres hoch." );
}
}

// Too small?
if ( ($Globals['minwidth'] > 0 && $imagewidth < $Globals['minwidth']) || ($Globals['minheight'] > 0 && $imageheight < $Globals['minheight']) )
{
@unlink($tmpdir);
diewell( "Das Bild ist zu klein!<br /><br />Das Bild muss mindestens {$Globals['minwidth']}x{$Globals['minheight']} auf der kürzesten Seite sein." );
}
-----------------

And the error messages are still hardcoded in the image-inc file by the way.

So how to fix this problem this time?

Thanks in advance

[Chuck S]

The changes where in this post

http://www.photopost.com/forum/showp...6&postcount=15

You can try using that or try changing $tmpdir to $filepath in your code above as well

[snoopy5]

Hi

this does not work as explained above. Also the exchange $tmpdir to $filepath does not work.

I have in my image-inc.php 3 times the code $realname. I always changed all 3 at the same time after deleting the upload subdirectories:

Once with $imgdir
Once with $tmpdir
Once with $filepath

In none of these scenarios it worked. Always the 24hour alert.

[Chuck S]

snoops go back to my initial post here as you need to define $imgdir first

http://www.photopost.com/forum/showp...6&postcount=15

[snoopy5]

o.k., it seems to work now, i will test tomorrow more. This is my current image-inc.php file (the relevant part):

Content visible to verified customers only.

Strangely, it did NOT work with $imgdir.

So I replaced on FOUR positiones $imgdir with $filepath, incl. the line of code that I had to insert before the // Too big?

But the original code in the download file of end of July is definitely wrong.

(P.S.:how do I highlight here text i.e. in red?)

[snoopy5]

Originally Posted by snoopy5

o.k., it seems to work now, i will test tomorrow more. This is my current image-inc.php file (the relevant part):

Content visible to verified customers only.

Strangely, it did NOT work with $imgdir.

So I replaced on FOUR positiones $imgdir with $filepath, incl. the line of code that I had to insert before the // Too big?

But the original code in the download file of end of July is definitely wrong.

(P.S.:how do I highlight here text i.e. in red?)

As it turned out, this is not a good fix. This fix leads to another bug when editing a photo and replacing it with another one, a jpegtran error appears and there is no medium size image anymore visible. For more information look here:

http://www.photopost.com/forum/showt...=1#post1168519

[snoopy5]

Originally Posted by Chuck S

snoops go back to my initial post here as you need to define $imgdir first

http://www.photopost.com/forum/showp...6&postcount=15

I found the problem:

The bugfix you suggested above is missing the code change for too small images. You only posted to change $realname with $imgdir for too big images plus the line ($imgdir = "{$Globals['zipuploaddir']}/{$User['userid']}/$realname" on top of it. As long as the code for too small images is not changed too, it does not work.

So the complete code for the relevant part is the following:

---

Content visible to verified customers only.

----

With this, the 24h bug disappears

[snoopy5]

I can not believe it. I just upgraded from 5.5. to 5.62 and again there is the same bug!

I tried all these nice exercises explained in detail above today again, but nothing works.

So what is this time the solution?

Since this therad is so long, here a reminder what the problem is:

If a user uploads an image which is too small. he gets the correct alert that this image is too small. If he then uploads another one with the right pixel and KB size, he gets the alert that he already uploaded an image within the last 24 hours, although this is not true.

It seems again, that the upload directory does not get cleaned onece a wrong image was blocked by the system.

It would be nice, if we do not have to fix the same bug in every new release that is coming out. This is now the third time I report this problem, each time when I upgraded to a newer version it is there again!

And the text is still hardcoded by the way!

[snoopy5]

update:

Maybe this information helps you:

I have tested with 2 different usergroups: The so called Test accounts and Bronze levels. The first one (test accounts) is allowed to upload only 1 image/24 hours. The second usergroup (Bronze) is allowed to upload 4 images/24 hours.

The test account gets the alert as described above. The Bronze user however gets first with the image which is too small the size error and with the upload-process of a second image (with proper sizes) he gets directed to the second screen where you can see the images and the fields for comments side by side.

There you can see also the too small image. As long as the Bronze user does not uncheck the box next to the too small image, he alway gets the size rreor message. Nothing happens with the correct image though.

As soon as the Bronze user is unchecking the box next to the too small image, he can successfully upload the other image. No 24 hour problem at all.

I will send a link of the gallery to Chuck

[Chuck S]

Using the defined $imgdir should work fine and I will pass it along

[snoopy5]

Originally Posted by Chuck S

Using the defined $imgdir should work fine and I will pass it along

FYI

I used now again the code I wrote in my posting of August 16th, 2006, 05:52 PM as shown above and it works now.

I obviously have forgotten yesterday that I have to add additionally this line (although it was already in my code box above):

$imgdir = "{$Globals['zipuploaddir']}/{$User['userid']}/$realname";

[Chuck S]

It is sometimes the little things that get ya my friend