PHP + GD memory error

[DesmondSweeney]

Hello Everyone,

I was experencing an error similar to the following:
Allowed memory size of n bytes exhausted (tried to allocate n bytes) in script.php

After reading these forums and google, it's clear this isn't a bug with photopost so much as it is a limitation of GD and PHP (GD being inefficient, and PHP terminating poorly when there isn't enough memory).

My fix was to add a dynamic 'memory required' check to uploadphoto.php and bulkupload.php. I searched for the function call 'create_thumb', and added a check similar to the following:

Content visible to verified customers only.

What the above script does is checks the current image memory requirements (based on the formula) against the maximum available php memory. If there's enough memory to process, it does, if not, it deletes the file and moves on.

What I'm not sure of is if I'm breaking anything when I do this. I'm more than happy to post my modified files if that'd help you determine if i've done the right thing here.

Comments?

Photopost staff: can you work this into a service release or into the next version? Ideally PhotoPost should *never* just flake out, errors should be handled wherever possible.

Thanks in advance!

[DesmondSweeney]

*BUMP*

Here's the two modified files (inside the zip). Could one of the PhotoPost staff members please take a peak? All code i added has 'Desmond' in comments surrounding it.

Thanks!

[Chuck S]

I have removed your attachment but I downloaded it to look at.

Sorry it is never allowed the attaching of our full script php files in any forum not even our own. As with any commercial product you are permissable to upload modified template files etc but never the scripts themselves.

Thanks I will look into this memory check feature.

[DesmondSweeney]

Sorry! I assumed that because only verified customers can get downloads, it'd be OK.

Thanks for your assistance, I look forward to your feedback.

[Chuck S]

Not a problem no harm no foul.

Even in the modifications forum users are not allowed to post full modified PHP scripts of our code. It is like this with most commercial apps.

We shall check out this posted function and test the ramifications and security concerns etc.

[DesmondSweeney]

Excellent. Will you post back here when you're done?

[Chuck S]

Once I have had enough time to test and evaluate all relatevant information on this yes I will respond.

[DesmondSweeney]

I look forward to it. Thanks so much.

[Chuck S]

Well this should work from what I see. I trimmed things down a bit to all that was needed since we already call getimagesize. GD calls resize_jpeg function to create the images so here is all you need to add in bold.

Content visible to verified customers only.

[DesmondSweeney]

Thanks for looking at that for me.

Will this 'fix' make it into your next release?

Desmond.

[Chuck S]

It is already in the new classifieds and the upcoming reviewpost release most likely Photopost will follow suit.

[DesmondSweeney]

Glad to hear it.

Thanks!

[DesmondSweeney]

Hello,

Was this added to the latest Photopost version?

Thanks!
Desmond.

[Chuck S]

I do not show it in Photopost as of yet

[CavySpirit]

Originally Posted by Chuck S

Well this should work from what I see. I trimmed things down a bit to all that was needed since we already call getimagesize. GD calls resize_jpeg function to create the images so here is all you need to add in bold.

Content visible to verified customers only.

I thought I had the latest version of Classifieds and I'm not seeing this code and I think I'm having this same issue. Help?

[Chuck S]

This code is NON WORKABLE with newer PHP's

You want to simple place something lke this in your pp-inc.php file near the error_reporting line

ini_set("memory_limit", "40M);

[CavySpirit]

Thanks. Discovered it doesn't work. I think I got it working--my memory issue, that is.