5.2 Upgrade

[starman]

I just upgraded VB 3.5 and Photopost to 5.2. Everything seemed to go smooth. However, when i "Click on image to view larger image" the window opens in a new window with the header in it. Anyone have some help?

http://www.scrollsawer.com/gallery/

[Chuck S]

HMM interesting

printheader( $dbcat, " $title", 0, "no", $bigimage );
include( "{$Globals['PP_PATH']}/{$Globals['TMPL_PATH']}/showfull.tmpl" );

We clearly define printheader NO in that line above and your site is printing it anyway in showfull.php

Make sure to reupload that file just incase yours is an old file

[starman]

I deleted showfull.php from the server. Downloaded 5.2 again and uploaded showfull.php agian. Header is still appearing.

[starman]

any other clues?

[Chuck S]

Sorry not with this statement clearly setting printheader to NO

printheader( $dbcat, " $title", 0, "no", $bigimage );

I will see if Michael has any ideas

[starman]

I am not sure if this has anything to do with it. In v-bulletin 3.5 I am now using the new plugin sysytem to include my header and footer using global_start.

ob_start();
include('vb-header.html');
$cust_header = ob_get_contents();
ob_end_clean();

ob_start();
include('vb-footer.html');
$cust_footer = ob_get_contents();
ob_end_clean();

[Chuck S]

If you turn off that does the issue go away?

I am using vb header and footer normally with 3.5 my only hack is global include start of vbportal

[starman]

Yes when I turn it off the header and footer go away in the large image but it also is lost throughout the message board and gallery. I don't have any custom hacks.

[Chuck S]

Okay so your not using the normal way to include a header or footer that everyone else does as in header and footer templates in vbulletin admin.

Well given the way there new hack system works I do not think there is anything I can tweak here for you real quick. We call their global.php file and prep the header and navbar and footer templates for display and any other associated java scripts etc.

So since we call global.php your new hack system is called and works fine but as you see you have issue with it printing header in big window display.

The issue is simple but there is no easy solution here. We print the header based on variables we set to call header navbar templates etc and define them $vbheader $vbfooter. If we set them to NO which we do on showfull they are not displayed however your plugin system is called in global.php

The quick solution would be to place your header and footer in the normal templates assigned for these in vb admin but I am assuming you have a reason for not doing so.

[starman]

I placed the header and footer into the normal templates. This solved the problem. However, I miss the ease of making frequent changes to the headers and footers using DW. This is exemplified running multiple VB-PP sites. Will you please consider tweaking the code in future releases so users can take advantage of using Header and Footer includes that don't conflict with showfull.php?

[Chuck S]

Well we would have to see if this is even possible to tell you the truth.

We call the vb header and footer as well as navbar which are static variables in every version of VB.

What your talking about is there new plugin system and we would have to research this.