Contest ended - sorting by Rating does not work

jdougher · November 27th, 2010, 08:01 AM

We have a gallery-run contest that ended. We ended voting. Sort by Rating doesn't work at all. Why not?

PhotoPost 7.02

Chuck S · November 27th, 2010, 01:52 PM

when a contest is ended the sort applied is random from what I am seeing in the code in showgallery.php but to be sure I will do some testing. when running a contest the sorts are hard coded not changeable. As to whats the norm I can not say without asking Michael.

jdougher · November 27th, 2010, 02:55 PM

Quote:

Originally Posted by Chuck S

when a contest is ended the sort applied is random from what I am seeing in the code in showgallery.php but to be sure I will do some testing. when running a contest the sorts are hard coded not changeable. As to whats the norm I can not say without asking Michael.

I believe you have answered my question with a description of how the software currently works, not how it should work or how the software leads one to believe it should work.

Certainly a random sort should not be applied when a user specifically selects Sort By Rating. Yet this appears to be what is happening. Or rather, as I described, there is NO sort happening!

Chuck S · November 27th, 2010, 03:26 PM

Like stated when a category is set to voting the sorts are hard coded so that sorting box is irrelevant as you can not switch sorting.

If you wish to change your sorts you would need to do so in the coding to work the way you specifically want.

So when you end the voting what sorting are you wanting?

jdougher · November 27th, 2010, 03:37 PM

Quote:

Originally Posted by Chuck S

So when you end the voting what sorting are you wanting?

Well we want sorting by rating, naturally. Otherwise how are we to see which images get the most votes? As it is, we have to do a visual scan of all the images and note the vote count. It's insane. That can't be the behavior that's intended, can it?

Also if certain types of sorting are not available in some views, then the sort box should not even be displayed. There's not even an error message that appears stating that a sort didn't take because it's not supported. I'm sorry, but this is just nuts. This has to be a bug.

Chuck S · November 27th, 2010, 06:47 PM

The sort for contests have always been hard coded for many years since the functionality was introduced so this is not something new.

I also wonder if your issue is caused by you having a cookie with a sort set to random.

Try clearing all cookies for your site in your browser and view the page.

jdougher · November 28th, 2010, 05:54 PM

Quote:

Originally Posted by Chuck S

The sort for contests have always been hard coded for many years since the functionality was introduced so this is not something new.

I also wonder if your issue is caused by you having a cookie with a sort set to random.

Try clearing all cookies for your site in your browser and view the page.

It's not the cookie. I tried it with two other browsers. Same random result. How can I fix this? We have contest sponsors who don't want to have to wade through hundreds of images to see which ones have the highest votes. Neither do I.

Chuck S · November 28th, 2010, 06:59 PM

Maybe try changing the line with the 6 to a 4 in showgallery.php. I have the code showing below to search for.

Code:

Content visible to verified customers only.

jdougher · November 30th, 2010, 04:33 PM

Quote:

Originally Posted by Chuck S

Maybe try changing the line with the 6 to a 4 in showgallery.php. I have the code showing below to search for.

Code:

Content visible to verified customers only.

That didn't work. Any other suggestions?

Chuck S · November 30th, 2010, 06:04 PM

I really cant say without information about your site as that should work.

I would suggest though you try 7.03 first as there was alot of different bug fixes.

jdougher · December 1st, 2010, 02:02 PM

Quote:

Originally Posted by Chuck S

I really cant say without information about your site as that should work.

I would suggest though you try 7.03 first as there was alot of different bug fixes.

Updated to 7.03. Changed the 6 to 4 as you suggested. Did not work. Here's the contest:

Current Photography Contest: Autumn! - Free online photo gallery at PhotoCamel.com

jdougher · December 1st, 2010, 02:09 PM

Also the tricks in this thread no longer work:

Sorting does not work in contests

Seems to be an age-old bug that is not fixed.

Chuck S · December 1st, 2010, 04:13 PM

anything in that thread is most definately in the software.

I will recheck it out and see if I can see anything out of place.

jdougher · December 1st, 2010, 05:39 PM

Quote:

Originally Posted by Chuck S

anything in that thread is most definately in the software.

I will recheck it out and see if I can see anything out of place.

Thanks. This is kind of urgent. We're getting ready to set up another contest.

Chuck S · December 1st, 2010, 09:14 PM

when I have a response I will let you know.

jdougher · December 5th, 2010, 03:52 PM

Quote:

Originally Posted by Chuck S

when I have a response I will let you know.

Anything yet?

Chuck S · December 5th, 2010, 09:39 PM

Well it is sorting by rating from what I see. The issue is multifold because there is not sort for votes.

Find this code in showgallery.php

Code:

Content visible to verified customers only.

change that to this

Code:

Content visible to verified customers only.

then find this

Code:

Content visible to verified customers only.

change to this

Code:

Content visible to verified customers only.

jdougher · December 6th, 2010, 05:49 AM

Why would a "sort by rating" option even be enabled for a category marked in Admin as "contest"? What you want is a sort by voted. The "rating type" in Admin is set to Contest.

I thought you said earlier that for contests, sort order was predetermined.

Chuck S · December 6th, 2010, 07:26 AM

As said the sort has always been ORDER BY disporder,rating DESC which is how Michael had designed the contest and how it is suppose to operate so in theory the code is working how it is suppose to.

If I remember correctly when the contest option was added there was no votes field. That came later on in the contest option.

what is posted should make them sort by vote when the contest ends.

jdougher · January 22nd, 2011, 10:30 AM

Quote:

Originally Posted by Chuck S

Well it is sorting by rating from what I see. The issue is multifold because there is not sort for votes.

Find this code in showgallery.php

Code:

Content visible to verified customers only.

change that to this

Code:

Content visible to verified customers only.

then find this

Code:

Content visible to verified customers only.

change to this

Code:

Content visible to verified customers only.

Just getting back to this thread. The fix above *does* fix photopost so that contests that are over are sorted by vote. Thanks.

Why this isn't in the software to begin with I have no idea. I consider this a bug.