BBCode for Video Thumb Wrong?

MarlinNut · March 28th, 2009, 12:05 PM

I'm running Photopost Pro 6.2 and vBulletin 3.8.1, and running some video tests.

When I upload a video and the optional thumbnail, the BBCode for the Linked Thumbnail is incorrect. It references the correct location (the "thumbs" directory), but the wrong file - "video.mpg", for example, rather than "video.jpg". As a result, when I use that BBCode in the forum, it correctly links to the video but I get a broken image for the thumb. The gallery page, however, displays the correct thumb.

Probably an easy fix, but a bug?

Chuck S · March 28th, 2009, 02:56 PM

You can try replacing the code in the bottom of showphoto.php for the showcode to this

Code:

Content visible to verified customers only.

MarlinNut · March 29th, 2009, 11:59 AM

Replaced the code as requested, but got the following when I tried to view anything using showphoto.php:

Parse error: syntax error, unexpected '}' in /home/content/m/a/r/marlinnut/html/pictures/showphoto.php on line 1684

Line 1684 corresponds to the closing bracket in the first nested "if" statement, so I added opening brackets in the 4th line (for the first "$showthumb" statement) and its corresponding statement in the second nested "if".

The good news is that got me past the parse error, but not to a functional solution. Using this code, the BBCode for a linked video thumb references a "mm-video.gif", which isn't among the items in the images folder, so it gives a broken image.

Making things even stranger, after the code change, the BBCode for a standard image no longer includes the thumbnail image in the statement - just a pair of opening and closing IMG tags - if you use the BBCode in a forum post, for example, they appear as text, linked back to the gallery image.

At this point, I can't tell if the issue is the code, the location of my added brackets, or some combination of the two.

I think we need a redo ...

Chuck S · March 29th, 2009, 03:48 PM

try reapplying the code

MarlinNut · March 29th, 2009, 04:12 PM

The good news is that, using the new code, I don't get the parse error.

The bad news is I still have the same issues - the BBCode for a linked video thumb still calls out for the mythical "mm-video.gif" that doesn't exist, and the linked thumb for an image is still blank - just the URL tags.

For what it's worth, you seem to have the same problem I'm trying to fix ... check the linked thumbnail code in the test video below.

test video - PhotoPost Photo Gallery

Software ... it's a process ...

Chuck S · March 29th, 2009, 04:15 PM

Code:

Content visible to verified customers only.

There is no call to mm-video.gif it is video.gif

Code:

Content visible to verified customers only.

It correctly links $mmthumb

pistebasher · March 29th, 2009, 04:26 PM

Thanks for that Chuck, that's been annoying me for ages.

Chuck S · March 29th, 2009, 04:53 PM

Not a problem

yeah if no one speaks up I dont know its an issue to correct.

MarlinNut · March 29th, 2009, 04:53 PM

>There is no call to mm-video.gif it is video.gif

Perhaps - but that's what it's returning:

[url=http://www.marlinnut.com/pictures/showphoto.php?photo=5][code]Content visible to verified customers only.[/code][/url]

The gallery is live, albeit in test mode, if you'd like to peek.

http://www.marlinnut.com/pictures/

Chuck S · March 29th, 2009, 04:57 PM

try making sure this block of code is exactly as posted here

Code:

Content visible to verified customers only.

MarlinNut · March 29th, 2009, 05:17 PM

Interesting - there were _two_ differences - the famous "mm-video.gif" was in my version of the code ("mm-ms.gif" in yours) and the image for the Real Media was different ("mm-real.gif" in mine). Enough to make you think I've got some old code floating around.

That solved the broken video image, although I noticed that even if you have a custom thumbnail for a video, you still get the generic one?

My other problem - which was created by our first code change - remains: the blank URL for linked picture thumbnails.

Chuck S · March 29th, 2009, 07:38 PM

The blank url?

Oh, Janet! - SCMO Pictures

I dont see any issue there

MarlinNut · March 29th, 2009, 08:04 PM

It's not the videos - it's the pictures. For example,

[url=http://www.marlinnut.com/pictures/showphoto.php?photo=4][code]Content visible to verified customers only.[/code][/url]

is what displays here: Just Another Crappy Sunset - SCMO Pictures

I reverted back to the original version of showphoto.php - complete with the video link problem - and the BBCode for the picture thumb is fine.

Chuck S · March 29th, 2009, 08:30 PM

try reapplying the edit in post 2

MarlinNut · March 29th, 2009, 09:50 PM

Went back and pulled a fresh copy of showphoto.php, applied the edits from Post 2 and Post 10, and it seems to all be working. Guess there's a lot to be said for starting fresh sometimes - hack away at something long enough, and you'll find a way to corrupt it.

Thanks for all the help, and for showing how "Customer Support" is supposed to work!

Chuck S · March 30th, 2009, 08:31 AM

Have a good one glad to help.

pistebasher · March 30th, 2009, 08:31 AM

Hmm - looks like I spoke too soon. The fix worked fine for multimedia files but then it seems to have stopped the still pics thumbnail links - I just get the

Code:

Content visible to verified customers only.

tags with no pic link as noted above (with fresh download of showphoto.php and both codes applied as above).

Chuck S · March 30th, 2009, 08:32 AM

Follow post 14 as this was discussed the last couple posts

pistebasher · March 30th, 2009, 09:13 AM

I had applied the two code sections to a fresh showphoto.php as noted in post 14, but no linked thumbnail image appears.

The original file has

Code:

Content visible to verified customers only.

whereas your amended version in post 2 has an extra pair of { } around the showbbthumb lines. Is that correct before I go any further?

Chuck S · March 30th, 2009, 09:21 AM

BBCode for Video Thumb Wrong?

That post should work.