file size limit

Simons · January 29th, 2009, 05:43 AM

Not sure if this is a bug, but on the usergroups there seems to be a problem with file size limits.

Lets say the files size limit for a usergroup is 200kb, when uploading a photo, it will not allow them to upload a file bigger than that, but if they upload a file under 200kb, then edit the photo after, they can change the file for one that exceeds 200kb.

So on editphoto.php it does not check the file size

Has anyone else noticed this?

EDIT: Just installed the original files and I have the same problem

Chuck S · January 29th, 2009, 10:30 AM

Quite possible that the developer never considered that option. If you allow a user to edit things they can bypass upload restrictions sure. I will pass it along. My suggestion would be to turn off edit permissions.

Simons · January 29th, 2009, 10:43 AM

Thanks for your reply chuck.

The developer has considered the dimensions limit in editphoto, that works fine.
Your suggestion makes sense to block the loophole, but Edit photo is an important feature for members and myself, turning this off would cause members to rebel as they no longer have control over their photos.

So if you can give me an example of the code I need to implement it would help.

Thanks
Simon

Chuck S · January 29th, 2009, 10:56 AM

There is no short code thing for me to post which is why I would need to pass to the developer and get his ideas on how he coded it and why.

The whole editphoto script needs to be redone.

Simons · January 29th, 2009, 11:14 AM

Thanks Chuck,

I've edited the script so that only admin can change the photo in photoedit, this still gives members control over other aspects of their photo while we wait, but it will mean increased support for myself, so I hope a solution can be provided quickly.

Thanks Again.

Simon

Chuck S · January 29th, 2009, 11:19 AM

Have a good one.

Simons · January 29th, 2009, 07:19 PM

It's no good chuck, I've had to open it up again after several complaints from members about them not being able to edit the photo and replace it.

Members get feedback on their photos and then edit and upload a new version of that photo by way of editphoto.php, so members need it.

This does leave the file size limit open to abuse, as the files size limit does not stop them from exceeding the limit, as several of my members have already found out.

Chuck S · January 29th, 2009, 07:40 PM

When I have an answer I will respond but something like this is not going to have a fast response.

The developer I can tell you probally never considered this as most webmasters who restrict things like this would also restrict the ability to edit so this is something he has never considered when designing things.

Once we can do some testing and get an edit script that might include those restrictions I will post something.

Simons · February 5th, 2009, 11:08 AM

Any feedback on this Chuck?

Chuck S · February 5th, 2009, 12:15 PM

None from Michael but try adding this in bold in editphoto.php

Code:

Content visible to verified customers only.

Simons · February 5th, 2009, 01:35 PM

Chuck, your a star, it works and a big thanks for sorting this for me.

Chuck S · February 5th, 2009, 02:14 PM

Not a problem glad to assist just had to take some time to actually work through it.

Simons · February 5th, 2009, 08:42 PM

Much appreciated Chuck, it was causing me a major headache.

Chuck S · February 5th, 2009, 08:50 PM

Not a problem let us know if there is anything else we can assist with.