Highest Rated Bug?

helkoryo · January 18th, 2009, 05:13 PM

Hi Guys

I seem to be experiencing a small problem with my highest rated panel. It functions correctly until a user adds a comment to an image without a rating. Then the image seems to drop out from the highest rated list.

My users are finding this disappointing as many of their images are still rated as 10, however are not in the panel.

Would really appreciate your help

Cheers

Helen

Chuck S · January 19th, 2009, 08:45 AM

Actually there is no bug there at all that I can see. If someone places a comment on a photo and does not rate giving it essentially a 0 rating should it not be averaged? That is how all those things are done its all averages.

The issue I see it is instead the calc_rating function in pp-inc.php has this line and only recalculates ratings based on if they are no 0 ratings so essentially thats where the bug is. You say have a photo and it has 2 10 ratings and 3 people who commented and gave it a 0 rating. Your still showing the photo rated as 10 but to me looking at the math the real rating is 2. Thats why it no longer shows in your highest rated block because its average is no longer than high.

Code:

Content visible to verified customers only.

helkoryo · January 19th, 2009, 03:22 PM

HI Chuck

Many thanks for getting back to me so soon and I agree with your maths there, I think the problem is some of my members don't like using the rating system and just choose leave comments (yip thier problem I agree) this them makes the average score unfair as the image has infact scored 10s and in fact some have scored many 10s. In addition my users tend to reply to comments and the responce shows under the image again this is recorded as a comment and no rating and again it knocks the image off the highest rated pal.

Was that a line of code you quoted me earlier to add that will resolve this for me?

Many thanks for all your help once again

kind regards Helen

Chuck S · January 19th, 2009, 04:08 PM

In the pp-inc.php file for that query just remove this from the query to recalculate ratings based on my math

Code:

Content visible to verified customers only.

skidpics · January 19th, 2009, 06:09 PM

Quote:

Originally Posted by Chuck S

In the pp-inc.php file for that query just remove this from the query to recalculate ratings based on my math

Code:

Content visible to verified customers only.

can you reclarify what this does by removing it?

Chuck S · January 19th, 2009, 07:17 PM

It makes the photo rating recalculate and include ratings which are 0 so a photo rating is calculated correctly. My post above explains exactly the issue.

skidpics · January 19th, 2009, 10:20 PM

Quote:

Originally Posted by Chuck S

It makes the photo rating recalculate and include ratings which are 0 so a photo rating is calculated correctly. My post above explains exactly the issue.

I think I was reading into it too much..

Chuck S · January 20th, 2009, 08:48 AM

Maybe so my friend it is just a minor calculation error.