Captcha Not Working

[skidpics]

I just discover that the captcha code does not work

When a user inputs just a comment, without captcha, the comment can be submitted WITHOUT the captcha code

can someone verify on their latest install of PP 6.2

l_b3222a56b17677523de2a9aaa0fbb2fa - Image hosting, free photo sharing & video sharing at Piqueshare

[Chuck S]

Yes a comment can be added without captcha

I will need to talk with Michael it may be related to him moving that code block when you reported the thing about rating an image and not being able to do it

[skidpics]

Originally Posted by Chuck S

Yes a comment can be added without captcha

I will need to talk with Michael it may be related to him moving that code block when you reported the thing about rating an image and not being able to do it

thanks for checking into it.

only way I knew was with spam comments all of the sudden

[Michael P]

Okay, I think I know the problem here; line 286 in comments.php should read:

Content visible to verified customers only.

Now, do we want to require CAPTCHA for ratings, too? If so, I think we have to remove the strlen portion as well.

[skidpics]

Originally Posted by Michael P

Okay, I think I know the problem here; line 286 in comments.php should read:

Content visible to verified customers only.

Now, do we want to require CAPTCHA for ratings, too? If so, I think we have to remove the strlen portion as well.

No, no captcha for ratings, that would defeat the purpose of quick rate

[skidpics]

code works.. thanks!

got one more problem now though, not captcha related, so feel free to split topic.

On the comment, when I click the Bold Italics, etc.. the page does nto apply the bbcode but rather, jumps to the top of the page..

the style buttons are pointing to this link: http://piqueshare.com/gallery/showphoto.php?photo=1669#

or whatever pic I am viewing

[skidpics]

Now, do we want to require CAPTCHA for ratings, too? If so, I think we have to remove the strlen portion as well.

Maybe in a future release, this issue should be optional??

[skidpics]

Michael,

Will this issue be updated in the version download?

[skidpics]

Originally Posted by Michael P

Okay, I think I know the problem here; line 286 in comments.php should read:

Content visible to verified customers only.

Now, do we want to require CAPTCHA for ratings, too? If so, I think we have to remove the strlen portion as well.

this seems to work, but if you click a rating within the comment field, it will still let the comment through,without the captcha. if there is NO rating selected, it needs to captcha to go through..

[Chuck S]

The way I read that line of code is simply that if you have captcha on and the user is a guest and the message is not empty meaning its more than a rating then CAPTCHA is required.

[skidpics]

Originally Posted by Chuck S

The way I read that line of code is simply that if you have captcha on and the user is a guest and the message is not empty meaning its more than a rating then CAPTCHA is required.

correct, but the code basically does: If Captcha is selected, and the message is NOT empty, go ahead and process the message. instead of captcha required.

[Chuck S]

Does captcha show on the page your on? Its a little early and coffee is not ready Looking at the block all that determines is whether we check the captcha code against the database or not and pass the comment on fail you.

So obviously I dont have the whole picture here from what your posting. The code is NOT going to do what your saying it does not that section of code unless of course you dont have any catpcha on the page.

Content visible to verified customers only.

[skidpics]

code is the same, except for the change on 268 that replaced:

if ( isset($_POST['comid']) && $Globals['usecaptcha'] == "yes" && $User['userid'] < 1 && strlen($message) > 0 )

to:

if ( $Globals['usecaptcha'] == "yes" && $User['userid'] < 1 && strlen($message) > 0 )

Perhaps you misunderstood my post the first time.

Captcha IS working, however, IF a rating is selected, And a message is entered, the captcha is bypassed... with the change that Micheal noted in the previous post

[Chuck S]

And thats with the removal of that one part of code

What is strange though is that section of code still requires that captcha be checked regardless of a rating or not if there is a message

[skidpics]

Originally Posted by Chuck S

And thats with the removal of that one part of code

What is strange though is that section of code still requires that captcha be checked regardless of a rating or not if there is a message

I checked the code again. looks like I was missing a {

appears to be working now.

rating only, it is passed on. Rating with comment, captcha required.

thanks for you help there Chuck, with the dup code, that helped!

[Chuck S]

LOL Not a problem knew you had to be missing something

If clauses are pretty straight forward unless you mess up their logic and that login was sound which is why I was asking you if captcha was even showing on your page.

[skidpics]

Yea - Captcha was showing, but just working right..

Enjoy the coffee there. I am off to work..

thanks!

[Chuck S]

I will be off to work soon as well but coffee is always a must in the morning for me.