pp 6.0 recent photos limit

[Astaran]

Got a report that the showphoto page loads "forever" if you're coming from recent photos.

Params are like this:
showphoto.php/photo/158248/cat/all/limit/last14

I think there's a bug while creating the correct query to grab the photos.

Content visible to verified customers only.

As there's a cat=all in the param list, the elseif for the limit won't be executed at all. Although that would be the right one, at least in my opinion. I flipped the OR to an AND, but I'm not sure if this will cause problems elsewhere. So maybe you can have a look at it.

Another fix would probably be to remove the cat=all param from the recent photo links.

[Chuck S]

Well the simply thing to do would be to place a LIMIT variable on that one specific query if it causes you issue. The way the arrays are formatted it should only process the number of results we need to get the number of results we need. I will ask Michael if he has any other ideas but a LIMIT variable in the query would help.

[Astaran]

Hi Chuck,

applying a LIMIT is certainly a got idea. I did not suggest it yet, because I haven't looked at the surounding code yet. Once I have, I'll let you know of the result. Not limiting the query results into performance problems. Problem is, with the current implementation, you need to get all for the paging and you have to check each photo if it's private or not. Using the "view all photos" link on a big site will bring the server down easily. On a busy site, the "14 days" can also be a real problem.

The bug I posted here is a little bit different, I think. The "limit=last14" means that only photos from the last 14 days should be displayed. So what's certainly missing is the WHERE condition "date < 14 days ago". As you can see, that's constructed in the second elseif (see code snippet above). But that elseif is not executed, because of cat=all.

[Chuck S]

True and yes limits would still help as even 14 days could be alot of results on a busy site.

[Astaran]

Would be great if Michael could have a look at it. Hopefully he can think of a way to optimize it. The showgallery script is working similar, so same problem there. Just not as bad as in showphoto.

[Chuck S]

Well I think he added alot of code which do make alot of speed improvements on large servers but there is always room for improvement for sure.