Comments notification

[Astaran]

People are not notified of a new comment if the comment is made by the owner of the image. I don't think that's intentional. In my opinion, it would make more sense if all "subscribers" are notified - apart from the user submitting the comment.

Line if comments.php is:

if ( $Globals['usenotify'] == "yes" && $theuser != $User['userid'] && $message )


$theuser is the userid of the comments owner.

[Chuck S]

It is intentional to not email the person who is making the comment is there a problem with Michael doing that

[Astaran]

As I tried to explain above, the current code is not doing that. I changed the code like this:

//BUGFIX notify everyone but the user who's submitting the comment
//if ( $Globals['usenotify'] == "yes" && $theuser != $User['userid'] && $message )
if ( $Globals['usenotify'] == "yes" && $message )
{
//BUGFIX - see comment above - added second condition
$resultc = ppmysql_query("SELECT id,userid FROM {$Globals['pp_db_prefix']}notify WHERE photo=$photo AND userid={$User['userid']}", $link);

[Chuck S]

$theuser != $User['userid']

So what your trying to say is that notification does not work if you post a coment on a photo you uploaded

[Astaran]

Yes, because the condition you quoted equals to false.

[Chuck S]

yeah I think the code is an old condition not to send notifications when someone comments on their own photo

[Astaran]

Had a typo in my code. It should be:
$resultc = ppmysql_query("SELECT id,userid FROM {$Globals['pp_db_prefix']}notify WHERE photo=$photo AND userid!={$User['userid']}", $link);

[Chuck S]

THAT WOULD BE INCORRECT IN EVERY WAY!!

Why would you be changing the query as that would introduce a big big bug. Remember the only potential bug and very minor potential if you ask me here is we dont send out an email to subscribers if the user who posted the photo comments on the photo which is merely an old feature. This discussion could go either way here. There is no need to redo any query

Remember you want emails to go out to subscribers why would you INTENTIONALLY code in a bug by limiting the query to just email you and not the subscribers to the photo?

The correct code should be this

Content visible to verified customers only.

[Astaran]

No reason to shout at me, Chuck.
Would you mind to tell me what the big bug is? You have seen my corrected query, right?

I changed the query, because I don't want to send out a notification mail to the user who is submitting the content. The easiest way for me to do that was to exclude his userid in the sql query.

AFAIK your code will send out an email to every person that has activated the notification for that photo and will not exclude the poster.

[Chuck S]

actually I missed the != in your query cause you did not put spacing in there so I thought you where only sending emails to yourself LOL

By the way thats not shouting I dont play those games with emails I am far too old to know what means what in this young world. I know LOL thats about it and I learnt that from my daughter