thumbnail litter

[HHMagz]

I've found that if someone tries to upload an image that is smaller than the minimum set in admin panel then the thumbnail is created but the larger image is not and the user is given an error. Ok so far but the thumbnail is left as a zombie out in the thumbs directory and doesn't show up in the users gallery. I wouldn't expect the image to show up but the upload should clean up after itself if it gets an error.

Is there any automated way to clean up these zombie files?

[Chuck S]

If a file is tried to upload under the minimum settings it should give error saying it is too small

You have some examples here

[HHMagz]

Originally Posted by Chuck S

If a file is tried to upload under the minimum settings it should give error saying it is too small

You have some examples here

As I stated the user does get an error saying the file is too small but the thumbnail for that image is created in the data directory anyway. The larger file is not loaded into the data directory so then you end up with a bunch of thumbnail images that don't correspond to a larger image anywhere. You only see these thumbnails if you go into the directory and have a look. They aren't visible to the user or admin through the product interface.

[Chuck S]

So you have no example to provide okay well I will need to do testing

[HHMagz]

It's pretty easy to verify just try and upload a file that's too small then go look for the filename.

[Chuck S]

HMM how about in image-inc.php make this change in bold and test

Content visible to verified customers only.

[HHMagz]

Will do - it will be this evening before I get to it though.

[HHMagz]

Chuck I think something like this needs to happen. When the diewell is hit that doesn't write a record to the db then the product code doesn't display the image. When it dies then there is a file left in the upload directory, a file left in the thumb directory, and a file left in $filepath.

This code cleans up the problem in the case I tested - the only thing I'm not sure about is how the paths might be affected by trying to upload images into albums or other cat dirs. Can you shed any light on that?

// Too small?
if ( ($Globals['minwidth'] > 0 && $imagewidth < $Globals['minwidth']) || ($Globals['minheight'] > 0 && $imageheight < $Globals['minheight']) )
{
// @unlink($realname); commented out by GCS
// remove the large file
@unlink($filepath);

// remove the thumbnail
$thumbpath = "{$Globals['datafull']}$thecat/thumbs/$realname";
@unlink($thumbpath);

// remove the file from the uploads directory
$upimgname = "{$Globals['PP_PATH']}/uploads/$upuserid/$realname";
@unlink($upimgname);

diewell( "Your graphic $realname is too small!<br /><br />Images must be at least {$Globals['minwidth']}x{$Globals['minheight']}" );

}

[Chuck S]

The edit I noted is correct

[Chuck S]

what version of software you using? The lines I noted above is the edit needed

[HHMagz]

Well yes what you wrote will remove the file from one of the 3 places that it exists.

[HHMagz]

Version 5.62

[Chuck S]

And what places do you think it does not get removed from?

[HHMagz]

After modifying the code to unlink($filepath) only, the image still remains in the ($thecat)/thumbs directory and it remains in the /uploads/(userid) directory.

[Chuck S]

Your code should work

[HHMagz]

It has based some more testing I've done.