5.62 Copies and deleting

[Astaran]

Several glitches with copied images (copy image to another category):

1. Upload a new image to your gallery (cat 500)
2. while processing the upload, copy it to another category. Example: "MyCategory"
3. delete the images from your album

result: No thumbnail for the copy available in "MyCategory".
expected result: thumbnail must still be available -> don't delete thumbnail if a copy exists

1. create a new album "MyAlbum"
2. upload image to your usergallery (cat 500)
3. while processing the upload copy it to your new album "MyAlbum"
4. delete image from your usergallery

result: thumbnail of the copy is still visible, but showgallery.php shows 2 photos for the new album (it contains only one!)

expected result: album does contain only 1 image, so display that on showgallery.php


1. upload image to your usergallery (cat 500)
2. while processing the upload copy it to "MyAlbum" (still containing the 1 image from the instructions above).

result: showgallery.php is still showing 2 images for that album, but that's the correct value now.

3. delete image from your usergallery (cat 500)

result: thumbnail is gone, showgallery.php now shows 3 images for that album

expected result: show thumbnail, show correct image count (2).

[Chuck S]

1. Upload a new image to your gallery (cat 500)
2. while processing the upload, copy it to another category. Example: "MyCategory"
3. delete the images from your album

result: No thumbnail for the copy available in "MyCategory".
expected result: thumbnail must still be available -> don't delete thumbnail if a copy exists

I suppose you mean delete one image like in the members gallery did that and the one in my corals category thumbnail appeared fine no issue. If there is some twist you are not telling me let me know here but using the steps defined it works fine. I see this block of code in editphoto and adm-photo which moves the image to the next cat if you delete the original

Content visible to verified customers only.

[Chuck S]

1. create a new album "MyAlbum"
2. upload image to your usergallery (cat 500)
3. while processing the upload copy it to your new album "MyAlbum"
4. delete image from your usergallery

result: thumbnail of the copy is still visible, but showgallery.php shows 2 photos for the new album (it contains only one!)

expected result: album does contain only 1 image, so display that on showgallery.php

Given the result of this test I did not upload another image since my category count is correct there was no need to do the 3rd test

http://www.reeftalk.com/gallery/show...y.php/cat/3085

Same function is issued and we call upgradecategories in the delete function of both files and my album shows 1 photo

Given this test shows the correct count there is no need to do the 3rd test

[Astaran]

Originally Posted by Chuck S

http://www.reeftalk.com/gallery/show...y.php/cat/3085

Same function is issued and we call upgradecategories in the delete function of both files and my album shows 1 photo

Given this test shows the correct count there is no need to do the 3rd test

Have a look at: http://www.reeftalk.com/gallery/show...user/1/cat/500
It's showing 2 photos there, but it's only one in there.

EDIT: Thumbnail is also missing

[Astaran]

Originally Posted by Chuck S

I suppose you mean delete one image like in the members gallery did that and the one in my corals category thumbnail appeared fine no issue. If there is some twist you are not telling me let me know here but using the steps defined it works fine. I see this block of code in editphoto and adm-photo which moves the image to the next cat if you delete the original

<snip>

I'll try it again and post more detailed instructions if it's reproducible.

[Chuck S]

Not a problem buddy

[Astaran]

I hope to get feedback until tomorrow evening. But at least the use cases 2 and 3 should be reproducible on your installation, aren't they?

[Chuck S]

Nope none of these are reproduceable and I clearly showed you a link showing the count is correct.

[Astaran]

Please have a look at 5.62 Copies and deleting

[Michael P]

For the first one, I need to know how you are deleting the photo. In adm-photo.php at lines 305 we do look for copies and move an image to a copy if the original is deleted; but maybe this isnt the code being executed depending on how you are deleting the original.

As for counts, it may just be an issue of updating a cache; but I need to know where you are deleting from so we can trace the code properly.

[Astaran]

I'm also waiting for feedback regarding the first one (this has been reported by our support staff).

2,3 are using editphoto.php. That's also my guess for the first one, but I'm not sure.

[Chuck S]

The copy code is the same throughout editphoto or adm-photo on copying images.

Now in reference to what Michael states good point since I dont use the cache. I show this in both adm-photo and editphoto

Content visible to verified customers only.

Now it seems to be the correct function would be to REVERSE these two things so upgradecategories is performed BEFORE we refresh the cache and this should eleviate your issue.

[Michael P]

I made that change above and am testing here on photopost.com (with that change) and #1 works as expected by coping the image to the copy location.

[Astaran]

Thanks, I'll test this.
Regarding #2 and #3:
I checked the "photos" field in the categories table. After the upload it's value is "1" (correct). After deleting the original image the other category (containing only the copy) is showing "2".

So upgradecategories() must somehow count incorrectly.

[Chuck S]

The only issue here is your using the category cache. I posted that the lines above in my post need to be switched around so upgradecategories is called first

I think you will find if you turn off the category cache the count is correct and in this case the change I noted will correct the issue

[Astaran]

Chuck, I made that changes.

First test:
category cache enabled, above changes applied, using editphoto to delete image

result: as described above. "photos" field in categories table has a value of "2".

Second test:
category cache disabled, changes added, using editphoto to delete image

result: as described above. "photos" field in categories table has a value of "2".

If you want to have a look:
http://fotogalerie.herr-der-ringe-fi...lery.php/cat/2

I'm speaking of the subcategory called "test".

[Chuck S]

We have to try and replicate that both Michael and I thus far have correct category counts. I will test further

[Astaran]

Your "reef pics" album is showing the same effect. Although your fix wasn't in place when you did that test:
http://www.reeftalk.com/gallery/show...user/1/cat/500

Let me know if you need more detailed instructions or a test account.

[Astaran]

Ok, here are more detailed instructions. It turns out that report #1 and report #2 are basically the same issue. Both testers used albums and no categories.

1. upload image, choose user's gallery
2. select a private album as optional category
3. check your usergallery. image is there.
4. check your album, image is there and showing as the thumbnail of your album
5. use editphoto to delete the image from your user's gallery
6. open your user's gallery -> album thumbnail is gone. Photo count has been increment by one.

If that will be fixed, report #3 is probably also fixed as this is using the same functions.

[Chuck S]

Try this test out in editphoto.php code changes in bold

// removed