5.6 hard coded language strings

Astaran · November 23rd, 2006, 08:00 PM

There are a couple of places where texts are hardcoded in english instead of using language strings:

upload page - Uploading in progress
editing a user album: YES/NO for displaying album intro

I may have missed some, but these are the most obvious.

Michael P · November 23rd, 2006, 08:22 PM

Thank you, I will fix these in the build (and the others you reported).

Astaran · November 23rd, 2006, 08:28 PM

Michael, I also fixed a couple of php warnings (mainly some missing isset() calls) in pp-inc.php. If you're interested in these, I'd send you my pp-inc.php file. Just tell me where I should send it to. The file is a bit modified, but it should be easy for you to make a diff.

Michael P · November 23rd, 2006, 08:33 PM

What version of PHP are you running? Odd that you'd be seeing warnings.

I'll send you a PM.

Astaran · November 23rd, 2006, 08:46 PM

PHP 4.4.4 on our production system and PHP 5.1 on your staging server. But they shouldn't be php version related.
Most of them are in construct_ppurl. $_REQUEST['somevar'] is directly used there without a checking if it's defined.
And some other small things.

Michael P · November 24th, 2006, 08:43 AM

Well, what I am not sure about is why you are seeing notices when we turn them off explicitly in pp-inc.php.