inc_features.php vbmembergroupsids bug or "feature"?

oneOeight · March 14th, 2006, 06:41 AM

When I tried to integrate the featured photos into our vB forum home page, I just got the empty featured photos box and wondered why.
It turned out to be a problem with the view permissions and the vB membergroupids. If one of the groups has no view permissions the box isn't rendered correctly.

Chuck S · March 14th, 2006, 08:30 AM

If they dont have view permission then they dont see photos so I do not see anything wrong with that as that is correct.

oneOeight · March 14th, 2006, 08:39 AM

ok, let me explain me a little more:
my main user group has view permission (=admin), and I'm member of two more groups which haven't, resulting in no view at all...
from my point of view this is erradic behaviour in the membergroupids check logic leading to unexpected results (=incomplete rendered featured photos box, even unregistered users see it rendered completly but with black pictures).
since I only tried checking it with my logged in user, I first thought the integration does not work, till I figured out what the problem was...

Chuck S · March 14th, 2006, 08:43 AM

I think you might need to post a picture of what your trying to say.

If you belong to multiple usergroups the best scenerio should come into play. Are you saying when your an admin and say a secondary group with no access you can not see the block?

oneOeight · March 14th, 2006, 08:52 AM

I would post one if I would see some attachment option in the advanced reply....

Let me put it up on the webserver
http://www.poisonfree.com/featured.png

Chuck S · March 14th, 2006, 09:07 AM

Okay well you might want to look at the announcement at the top of the thread to become a verified member so you can obtain support and see everything.

As far as this issue if I am following you here on what your saying this is what I did. I am admin I added myself to a secondary usergroup that does not have viewing permission for the gallery. The viewing permissions do what I say they do. I am shown the photos since as admin I can see it. As long as one of the groups I belong to have viewing permissions I am good

http://www.reeftalk.com/forums/index.php?

The only way your going to see what you have posted is if NO GROUPS have viewing permission.

oneOeight · March 14th, 2006, 09:29 AM

my colleague has the license registered on his email, and I can't change my profile to his email since it's in use already.

the admin group has view permissions, the other two don't, and still I see that effect. I checked the values in phpMyAdmin to see if they are in the DB.
I wonder if the php code is buggy with php 5.1.2?
if I comment the memberid line out, I see it...

Chuck S · March 14th, 2006, 10:42 AM

I have shown that it works as it is suppose to in the vb forum homepage by placing myself in a secondary group that does not have access and I can still view. I do not think PHP 5.1.2 would play a part here.

Code:

Content visible to verified customers only.

Basically looking at the coding it goes through a loop and checks every membergroupid. If one comes back with view permission it is set to 1 which means they can view.

You might want to post a link here so we can see your page.

oneOeight · March 14th, 2006, 12:00 PM

the link to the page wouldn't help, it would show just the same thing as the png.

edit: need to rethink $ViewPerm array thing

oneOeight · March 14th, 2006, 01:34 PM

ok, here some more code analysis:
my usergroups are 6,5
ugonoview is 1,3,4,5,7,8,26,16,17,18,21,24,27 for cat 500

the foreach loop with the in_array is here nv(x) = $noview

nv(1)=0 nv(3)=0 nv(4)=0 nv(5)=1 nv(7)=1 nv(8)=1 nv(26)=1 nv(16)=1 nv(17)=1 nv(18)=1 nv(21)=1 nv(24)=1 nv(27)=1

which results in:
$ViewPerm[500] = 1

as you see the $noview gets set to 1 with the "5", the "7" is not in the usergroup list, but doesn't set the $noview to 0.

so this code sets the noview to 1 if one of the usergroups is on the noview list.

Chuck S · March 14th, 2006, 02:51 PM

I can not comment on your scripting of how you came up with it but in ours 1 means you can view it. $noview=0 means you can not view.

if ( $ViewPerm[$pcat] == 1 ) continue;

This stops the printing of photos if $ViewPerm = 0

Therefore given your example you prove it works. Now also just for reference this features script does not pull any photos in cat 500 so you need to look at your noview permissions on your categories not members gallery

You have unregistered people set to NOT VIEW PHOTOS RIGHT?

I can see em.

oneOeight · March 14th, 2006, 04:06 PM

Quote:

Originally Posted by Chuck S

I can not comment on your scripting of how you came up with it but in ours 1 means you can view it. $noview=0 means you can not view.

I just added some printf to print the key and $noview in the foreach loop.
are you really sure about $noview=0 means "you can not view"?
as the foreach loop checks if an entry from ugonoview (the list with the groups who can't view, right?) is in the user group list.
if that's true it sets the $noview to 1, which then keeps the $ViewPerm at 1.
so why is it set to 1 by an entry in the ugonoview list?
as how I understand it, that's the list which tells what group aren't allowed to view. or has our DB simply data in that list from an old photopost version, which in the meantime has reversed the meaning of that list?

Quote:

Originally Posted by Chuck S

if ( $ViewPerm[$pcat] == 1 ) continue;

This stops the printing of photos if $ViewPerm = 0

actually it doesn't, it stops printing if $ViewPerm == 1, since the continue statement (skip rest of loop) is executed if == 1 is true.
it would stop printing for 0 if the statement would be == 0 or != 1.

Quote:

Originally Posted by Chuck S

You have unregistered people set to NOT VIEW PHOTOS RIGHT?

unregisterd just can see the preview but not the large photos.

Chuck S · March 14th, 2006, 05:29 PM

Yes 0 is view 1 is not.

I have tested this back forth and sideways. I added myself to 3 NOVIEW GROUPS and groupid 6 was the only view group and I could view. The minute I took away the only view group I could not view.

flint · March 16th, 2006, 07:35 AM

Quote:

Originally Posted by Chuck S

Okay well you might want to look at the announcement at the top of the thread to become a verified member so you can obtain support and see everything.

unfortunately I can´t find a way to link more than one email account to our licence (like on vb.com), so this is to confirm that one0eight is in charge of system administration for our site.

I´ll send him my login credentials for the time being, so he can access the proper forums and features, but I´d apprechiate it if you could bump him to "verified customer", too - so he gets subscription notifications to his email address.

thanks!

flint · March 19th, 2006, 05:49 AM

Quote:

Originally Posted by Chuck S

Yes 0 is view 1 is not.

I have tested this back forth and sideways. I added myself to 3 NOVIEW GROUPS and groupid 6 was the only view group and I could view. The minute I took away the only view group I could not view.

here it doesn't work, take a look at the attachment, the view permissions are set for the admin group.
it only works if I set view permissions for the additional groups also or remove them...
with the current setting (displayed in the screenshot) $featured will just be empty.

Code:

Content visible to verified customers only.

Chuck S · March 19th, 2006, 11:11 AM

I am using the base files in the distribution and taken away view permission on a secondary group and admin can view fine.

You can send me ftp and admin login and I will take a look at what your doing cause in my testing as stated I see absolutely no issue.