"Delete All User Photos" doesnt remove comments

mtha · November 22nd, 2005, 08:01 PM

When admin "Delete All Photo" of some member, the comments that tie with the deleted photo need also be deleted.

... this could work:

adm_cat.php
LOOK FOR:

Code:

Content visible to verified customers only.

REPLACE WITH

Code:

Content visible to verified customers only.

Chuck S · November 22nd, 2005, 09:40 PM

Actually its not that complicated to check a photo list

Code:

Content visible to verified customers only.

mtha · November 23rd, 2005, 04:16 AM

Quote:

Originally Posted by Chuck S

Actually its not that complicated to check a photo list

Code:

Content visible to verified customers only.

the above code will delete all comments belong to the same user (uid)

This might not work when

1. there're comments from other members to the deleting picture, that need to be deleted

2. There're comment from the same user, to other pictures, that not need to be deleted (not checked "delete comments" option)

Chuck S · November 23rd, 2005, 08:23 AM

Removed

mtha · November 23rd, 2005, 02:07 PM

I'm still not convinced yet!

isnt that make the queries running many times?

says at some point, you need to delete somebody's images, and he has 500 images, 500 queries will be executed, isnt it? it's gonna hurt your server badly.

btw, the $delcomments value is for "Check to delete all comments by this user", which is another issue where you want to delete all member's comments (in not-deleted photos).
Wherether or not this field is checked, the comments belong to the deleted photos still need to be deleted.

Chuck S · November 23rd, 2005, 02:20 PM

Ah I see what your talking about

We would have to actually do a variation of post 1 and my post 2 to achieve the desired action.

My post is basically what the code is suppose to do delete the users comments just like there pictures

You brought up a bug no one has ever noticed though in what happens to the orphaned comments of the deleted photos so a variation of both codes is called for

mtha · November 23rd, 2005, 03:17 PM

Quote:

Originally Posted by Chuck S

My post is basically what the code is suppose to do delete the users comments just like there pictures

"Functioning and Optimization" though

my dual xeon servers are running high on load, so I care more on optimization

Hope you do too

Quote:

You brought up a bug no one has ever noticed though in what happens to the orphaned comments of the deleted photos

hard to notice it, when people have alot of member/pictures, and they rarely delete all pictures. I am just testing functions on my localhost to "make you guys busier" making a good product

Chuck S · November 23rd, 2005, 04:21 PM

LOL

well I think you misunderstand what I am saying. I removed the other code I suggested. however post 2 as stated you still need to run the 1 query to remove all the user's comments which is 1 query

then a query such as yours would be 1 query so I am saying to achieve both it would be 2 queries not 500

iloco · November 23rd, 2005, 10:23 PM

Not wanting to hijack this thread but will the fix be in a future update or is it in one the files now that can do it.

I get confused reading this one.

Chuck S · November 23rd, 2005, 10:47 PM

There should be a fix provided soon just looking at the best possible solution right now

mtha · November 24th, 2005, 01:45 AM

Quote:

Originally Posted by Chuck S

LOL

well I think you misunderstand what I am saying. I removed the other code I suggested. however post 2 as stated you still need to run the 1 query to remove all the user's comments which is 1 query

then a query such as yours would be 1 query so I am saying to achieve both it would be 2 queries not 500

the second query is already present in the original code:

Code:

Content visible to verified customers only.

You only need to delete all the user's comments when "delecomments" checkbox is checked.