VB Enhanced using wrong style(NOT A BUG)

benFF · October 30th, 2005, 02:31 AM

Only just realised this, but the style code is wrong in both this and classifieds for the table header value.

It seems to be using the VB "tcat" value instead of the "thead" value.

It's more noticable in classifieds as you can see the header and section block are the same colour...

Chuck S · October 30th, 2005, 08:30 AM

tcat is the correct category header color and that is what we use for our category table headers.

http://www.photopost.com/classifieds/

How is anything wrong in this page?

benFF · October 30th, 2005, 09:51 AM

sorry maybe i described it wrong.

If you go to the homepage of the forums, the category headers (tcat) are a different colour to the table headers (thead) - on this forum the column description columns are darker.

This isn't carried across onto the classifieds though, as both the category headers and the column description headers are the same colour.

Chuck S · October 30th, 2005, 10:07 AM

You may choose to edit your templates any way you wish or for that matter as I pointed out change the menubar class to thead in vb3.php

We have always used the tcat variable for our menubar css selection.

I assume your talking about that one line on the one page index.php the category table header.

This is the class that match's most all css stylesheets in vbulletin.

benFF · October 31st, 2005, 06:37 AM

I appreciate that, but for full vb integration this is not correct. THEAD is always used for table headers, with TCAT used to break up the individual categories, as seen in your own forum - by using TCAT for both, this creates a large block of the same colour, which just doesn't look right.

Chuck S · October 31st, 2005, 06:50 AM

Well the simple answer is we do not use thead variable and it is only that one single categories strip that we are talking about in the entire program.

You can do this in vb3.php add in bold for vb3

Code:

Content visible to verified customers only.

then your categories.tmpl would be this

Code:

Content visible to verified customers only.

Michael P · October 31st, 2005, 07:02 AM

In the majority of cases it's a style preference, I've tried both over time and we've had people argue both side about which variable goes there. We put in one and people want the other - there is no clear answer that fits everyone's layout.

We went with the variable that caused the least issues with our members, but made it so that it could be changed.

benFF · October 31st, 2005, 07:13 AM

Thanks chuck, that worked, but of course there's a load more template edits for each of the pages that list items...

But Michael I'm not sure I agree with you

If vB styles it in that way, then surely if a user wants to use the vB integration, then your software should also style it in that way?

Michael P · October 31st, 2005, 08:18 AM

I'm just relaying the history of our integration over the past year or so and what our users have asked for in their integrations.

benFF · October 31st, 2005, 08:37 AM

Fair enuf - though how about a cheeky comprimise.

Set a new value in all the templates like Chuck showed, but default the $Style['thead'] variable to be equal to tcat (so everything will appear like it does now).

People like me though can then easily change that one line in our vb3.php file (to thead) and we can be happy too

?

Michael P · October 31st, 2005, 08:45 AM

I will consider it, sure.