"Allow members to rate photos?" bug(FIXED)

[Johnny Doomo]

If you allow members to rate photos and an unregistered user clicks a rating radio button on showphoto it gives the error:

Sorry, you don't have permission to post/edit.
If you tried to edit, you might not be the post's author or editing may
be disabled for your usergroup

[Chuck S]

Well which of these three factors is no on your install

if ( ($CatPerms['ugpost'][$thiscat] == 1 && $CatPerms['ugvote'][$thiscat] == 1) || $User['comments'] == 0 ) {
diewell( $Globals['pp_lang']['nopostedit'] );
}

The first $CatPerms is the cateogry post permissions (in this case the checkboxes); the second is the voting category permissions and the third is the Usergroup comments setting for that user.

Usergroup must have category posting and voting priviledges and overall commenting priviledges in edit usergroups.

How do you have yours setup?

[Johnny Doomo]

THEN SHOULDN'T YOU HIDE THE RATING RADIO BUTTONS FROM USERGROUPS THAT DON'T EVEN HAVE POSTING PRIVILEGES?

I feel like all the bugs I report are shot down, because they aren't "bugs" they are just things that should be coded into the system that AREN'T. You hide the register button once people register. You show a logout button if the user is logged in. If a usergroup doesn't have permission to upload images, you don't show them the link to upload images and them fill out the fields only to hit the submit button and it say "Oh sorry you don't have permission to upload photos.SORRY!"

It's just using everybodies bandwidth to show code that people can't use. If they don't have permission to use it, it shouldn't show it to them don't you think?

My unregistered "usergroup" (although in my mind unregistered is the absence of a usergroup) can't post comments because you get spam bots that post viagra spam, but I want them to rate photos. Perhaps the two systems need to be seperated. Adding a comment for rating isn't very user friendly IMO and I would bet most Photopost users opt for the feature to hide posts that contain nothing but a rating... like me.

[Chuck S]

They do not appear for user's that do not have commenting priviledge etc and it works fine

Note this below and it is proper if you allow ratings and voting and its not a contest the quickrate does not appear

if ( $Globals['allowrate'] == "yes" && $CatPerms['ugvote'][$dbcat] == 0 && $ratingtype != 1 ) {

Then in comments.php I already posted if voting or posting priviledges are not set and overall commenting is disabled then you dont have permission

if ( ($CatPerms['ugpost'][$thiscat] == 1 && $CatPerms['ugvote'][$thiscat] == 1) || $User['comments'] == 0 ) {
diewell( $Globals['pp_lang']['nopostedit'] );
}

Your issue is very simple your just not setting things correctly as far as permissions are concerned and your creating your own issue. You are contradicting yourself with permissions.

[Johnny Doomo]

1. Click your members link button to your members galleries.

2. Click a usersname.

3. Click a thumbnail.

4. Dispite being unregistered the system still shows the rating radio buttons under the medium sized image.

What do you mean my permissions?

My galleries are allowed for urnegistered users to upload images, but not comment. In my members gallery I can clearly see that it's showing the radio button code, but when you click on it it says:

"Sorry, you don't have permission to post/edit.

If you tried to edit, you might not be the post's author or editing may
be disabled for your usergroup."

I don't understand the code you posted above so I don't know what exactly it means, but does it have something to do with me allowing unregistered users to upload, but not comment? Did you guys tie those two things together or something?

I have my members gallery so that unregistered users cannot upload to it specifically as I wanted them to use another cat. So I created another cat that allowed them to upload. So all unregistered uploads go there. Then I disallowed unregistered users to upoad or have it available in the dropdown menu to upload to the members galleries.

[Chuck S]

Removed

[Johnny Doomo]

Nope that doesn't work. I looked a little more into the problem. Maybe this will help with giving me a fix or telling me what I did wrong.

I have two cats. 1 is the original members gallery where I don't let unregistered users post.

The second is a category just for unregistered users to post and where members can't post.

When I logout I don't see the "Quick Rate" in the unregistered cat, but when I go and *view* (as unregistereds can view, but not upload) the photos in the members gallery they have the "Quick Rate" showing.

Any ideas on what could be causing this problem? All my category and usergroup permissions seem to be set correctly, but if need be I could copy and paste them here.

[Chuck S]

I would suggest NO CHANGES to the code

Use a default file and simple set in edit categories for the categories WHICH groups can and can not vote

[Johnny Doomo]

Well I set it so no unregistered users can vote, but it still shows the quick vote in users albums. Can you check on your end /unmodified Photopost if this is a bug? Basically, unregistered aren't allowed to vote and I set it for that in the members gallery, and it appears to work as far as members galleries, but when you view an image in a users album, the quick rate radio buttons appear under the photo again.

Can you see if this is just my install? I don't think I modified anything that should cause this, but if you could double check for me on an unmodded Photopost I would appreciate.

Thanks for any specifics you can provide. If not, I will start messing around with restoring files that revolve around those pages, but thought checking on your end would be a quick, last resort before I take all the time to do that.

Thank you.

[Michael P]

I think there is some confusion here, so just to clarify, voting and rating are two different things.

Voting is for the contest mode only.
Rating is couple with comments.

I think that what might have happened is that in adding the voting code, we didn't explicitly look at how it could be or is being used to control ratings. We do check for voting permissions and if they have none set the rating to 0; but what Johnny outlines above needs to be looked at closer to make sure we are consistant in the use of that permission.

If a usergroup doesn't have "vote" permissions in a category, they shouldn't be able to rate either and we need to account for that.

[Michael P]

In showphoto.php around line 572 add the code in bold

Content visible to verified customers only.

[Johnny Doomo]

It appears to work.

Thank you.

On the last line of the code you posted, I had && $CatPerms['ugvote'][$dbcat] == 0 before && $ratingtype != 1. Not sure if that's a problem or not? Maybe I just have a different version that you? (5.2) Should I leave it in there?

[Chuck S]

No you change the $CatPerms['ugvote'][$dbcat] to $rateperms

[Johnny Doomo]

Thanks for clarifying that.

[skidpics]

okay - on another part of this issue is then, how can you allow quick rating to work without having to enter the captcha code for comments?

Those 2 should be seperated also, as I would love rating and comments to work for unregistered users, but they cannot rate because they have no idea nor the time to enter a captcha code for this - which is why it is called 'quick rate'..

If captcha is turned on, which is needed for spam bots, then apparently, the quick rate should be turned off for users who require the captcha in the beginning, which are the unregistered users. correct?

[Chuck S]

quickrate is shown to users not guests and works fine from what I am seeing. please open a new thread should you have any issue if I am not following as a 3 year old thread might confuse the issue.

[skidpics]

oops - will do - didn't notice the date.

[Chuck S]

Not a problem