Many XHTML Invalid codes

Alien Master · October 1st, 2005, 08:53 PM

Hey,

While putting one of my sites through the xhtml validator, I came up with quite a few (around 30ish) xhtml invalid codes... This was on the gallery index, I didn't even run it on all the other gallery pages.

Is this occurring just if you're using vb integration? Or is it pretty invalid on standalone as well? I noticed all of the bugs listed were extremely easy to fix (such as adding / to the end of img src calls, etc.)

I'd love to see this validate in an upcoming release!

(Btw, this occurs right on your own integrated gallery right here as well. 29+ errors)

Michael P · October 1st, 2005, 09:17 PM

We usually run validation on the pages, but I'll admit I haven't run them in a bit. I know when we did 5.0 we validated all the pages; but I haven't run them since.

Obviously we can't change issues with your vB headers/footers; but if it's in the PP code we can clean it up.

Pretty much all of the index ones can be fixed by removing the </span> on the end of the lines with lpostlink on it. (line 123, 216)

Alien Master · October 1st, 2005, 11:02 PM

Hey.

Thanks for checking this out again in the future, it's very appreciated! Yeah, I checked that it wasn't anything to do with my own code before posting.

Chuck S · October 2nd, 2005, 12:25 AM

Actually I show our programs 100% XHTML valid except one condition which was a recent addition. This is when you turn off the last comment/review and last photo/product columns

http://validator.w3.org/check?uri=ht...pe=Inline&ss=1

http://validator.w3.org/check?uri=ht...pe=Inline&ss=1

Now with that respect you can see we are 100% valid

The only issue where we are not 100% valid I show would be with Vbulletin since we use there code parser to parse smiley's etc it seems they are leaving off the closing tag when they parse the smilies so I can't comment futher on this

<img src="http://www.reeftalk.com/forums/images/smilies/wink.gif" alt="" title="

Now here are two new categories templates for photopost to try out which should fix any errors I see with those two columns turned off

If you see anything else let us know

Alien Master · October 2nd, 2005, 12:53 AM

The smilie thing just seems odd to me, since I get 100% validation with vBulletin's forum home index (including those very smilies). Hmm.

Alien Master · October 2nd, 2005, 12:56 AM

The .zip included above is appearing corrupt to me.

Alien Master · October 2nd, 2005, 01:00 AM

I checked out what you had gotten to validate, and it just doesn't physically look attractive to me on that page leaving all that data out so I guess I'll deal for now until another workaround presents itself...

Alien Master · October 2nd, 2005, 01:05 AM

If you wrap your pics with film strips, you'll get invalid img xhtml also, for example.. Gotta put a few more options on to get all that invalid xhtml.

Alien Master · October 2nd, 2005, 01:16 AM

I did some editing in /templates/vb3enhanced/thumbnail-filmstrips.tmpl and fixed all missing end slashes in img src's, and added any missing alt tags.

Also removed the "height" tag from the first table code.

Now I am down to ONE SINGLE error here:
http://www.wtf.com/gallery

Maybe that has to do with that reported bug of the second occurance of the stylesheet showing up in the source code. If you look at the description of the error on the validator site, it's simply an 'already defined' error. Once that's fixed, my index should 100% validate WITH all the code I have turned on! Woo!

Alien Master · October 2nd, 2005, 01:20 AM

More xhtml: If you have 'must be registered to view full photo' option turned on, there is invalid xhtml with the 'must be registered' error message it brings up when trying to view a photo.

Alien Master · October 2nd, 2005, 03:03 AM

Okay, page now validated after some more work.

Two things:

1) In languages/english.php - Get rid of the occurance of <p> in the code, and change them with <br />'s to resolve the 'must be registered to view photo' invalid xhtml issues in my last post.

2) In /header-inc.php - Find:

Code:

Content visible to verified customers only.

...and remove that code completely. At least if you're running vb3.5, it will still render completely as the stylesheet is still called without issue.

Chuck S · October 2nd, 2005, 11:20 AM

well the issue with vbulletin smilies which is what I was referring to is on them though it would seem

We call there markup script to render the markup.

Yes agree on the other issues thanks for the heads up on the filmstrips thing although personally I think they are ugly and dont use em.

I went through before and did tons of clean up on image tags and missing alt tags etc no suprise there are some left

Alien Master · October 3rd, 2005, 12:44 AM

Great! Happy to be somewhat helpful at least!

Keep up the great work!

Chuck S · October 3rd, 2005, 12:50 AM

A helping hand is always appreciated