vB3 + PP5.13 - Apostrophe error

Rids · July 24th, 2005, 12:37 AM

When using the enhanced vB3 editor in conjunction with Photopost, when a member types two or more apostrophes in any comment the result will be an unrecoverable error. I tried this on the dev site and its the same there but due to debug only showing details to admins the "unrecoverable error" was all I got. However, when I tried it on my site I got the following:

Quote:

We're sorry, but the system experienced an unrecoverable error. Please try again later.

Script: comments

Query: INSERT INTO comments (id,username,userid,date,rating,comment,photo,cat, approved,ipaddress) values(NULL,'Rids','1',1122177692,0,'one two's three four's five',12937,512,'1','###.###.###.###')

Result: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 's three four's five',12937,512,'1','###.###.###.###')' at line 1

Database handle: Resource id #30

Chuck S · July 24th, 2005, 09:00 AM

So this is interesting. So a single comma is alright

That makes no sense at all

Chuck S · July 24th, 2005, 09:03 AM

Okay I just tested this on my vb3 site and works perfectly so now HMM let me see what we can think of.

http://www.reeftalk.com/gallery/showphoto.php?photo=771

Rids · July 24th, 2005, 09:21 AM

Commas are ok I think, its just apostrophes as in test's

ps. I just saw the comment on your site and we are talking about the same things

Rids · July 24th, 2005, 09:26 AM

It does happen on both my site and the dev site though so what's different there?

Chuck S · July 24th, 2005, 09:35 AM

Yes we are talking the same thing as I just took your comment and basically typed the same thing

HMM you got me there thats what we need to find out.

Have you made sure you have downloaded the build and all the files are updated?

You have a link to your php info for me to see?

Rids · July 24th, 2005, 09:57 AM

I followed Michael's instructions for the last update and the one before, I think I changed all php files except the configs.

Here's my phpinfo file: http://terranuts.com/phpinfo.php

Chuck S · July 24th, 2005, 10:08 PM

I'll do some testing to see if I can replicate

Frost · July 25th, 2005, 04:18 PM

Ahem... do we not remember that vB stripslashes GPC, so if you use GPC and vB functions, you need to...

In comments.php find:

Code:

Content visible to verified customers only.

And replace with:

Code:

Content visible to verified customers only.

Further, as $checkdup comes from the comments tables, it should not have extra slashes, so to compare...

In comments.php find:

Code:

Content visible to verified customers only.

And replace with:

Code:

Content visible to verified customers only.

And, as $message is addslashed by typecast or by the change above, you want to not addslash twice...

In comments.php find:

Code:

Content visible to verified customers only.

And replace with:

Code:

Content visible to verified customers only.

Chuck S · July 25th, 2005, 04:29 PM

I use VB3

Frost · July 25th, 2005, 04:32 PM

Quote:

Originally Posted by omegatron

I use VB3

So then you can look at the exec_gpc_stripslashes function in vB's init.php file, right?

Chuck S · July 25th, 2005, 04:49 PM

LOL what I was saying is I dont get this error with globals on or off

Our typecast function should add or strip slashes as needed

Frost · July 25th, 2005, 05:03 PM

Rids problem is when s/he uses "the enhanced vB3 editor in conjunction with Photopost."

Code:

Content visible to verified customers only.

As such, the thing in red is stripslashed, so add the thing in blue, and also do the other changes that I previously posted.

If you are determined to reproduce this bug before committing the changes, then set VB3_ENHANCEDINT and VB3_COMMWYSIWYG to on.

BTW, your typecast call comes before $message is (re)set in the code shown in this post, so typecast doesn't do squat in this case.

Chuck S · July 25th, 2005, 05:10 PM

Frost I use all 3 vb3 settings to ON and can not reproduce this as I have said.

I know what your saying but I like to try duplicating issues.

Rids · August 2nd, 2005, 11:30 AM

Any luck with this yet? I noticed that the problem is still there, albeit slightly different, with vB3.5 as when I tried posting on the dev gallery the result was an empty post. I tried posting with the apostrophes first and the result was " <p> </p> " got posted and when I tried without the post was empty.

Chuck S · August 2nd, 2005, 11:48 AM

You can try Frost's suggestion although I am unable to reproduce slash's on my system with magic quotes on or off

vb 3.5 is not supported yet.