5.13 - Users with the same IP not counted(NOT A BUG)
Not really a bug in the sense it prevents the program from working, but the "ip_online" table uses MysQL "UPDATE"s based on the primary key "ipaddr" (IP address) in function update_whoonline (vb3.php in my case)
This as the side effect to "hide" different users surfing with the same IP (intranet, universities, or... me testing my website with 2 browsers).
There should be a real "unique key" not based on the sole IP.
You can do this this way :
1) DROP the primary key based on "ipaddr".
2) ALTER TABLE pp_iponline ADD PRIMARY KEY (userid,ipaddr)
I also think this piece of code
Should actually be part of vb3.php's procedure "update_whoonline" as it's only used once. The "600" should be a control panel option imho, as this "session timeout" can be changed in Vbulletin .
Finally, ipaddr is defined as a varchar(75), not sure why (might be a reason for that), but an IP cannot be bigger than XXX.YYY.ZZZ.WWW (15 chars). Okay it's a detail :)
Just a couple of suggestions.
This is not a bug and the code is fine in pp-inc.php as whether we run it there or in the function it does not matter.
If you call update_whosoonline the code in that function or in pp-inc.php does the same and in fact the reason it is in pp-inc.php so we are not placing the code in 15 different integration files which would be lengthy ;)
|All times are GMT -5. The time now is 11:38 AM.|
Powered by vBulletin® Version 3.8.1
Copyright ©2000 - 2013, Jelsoft Enterprises Ltd.
Search Engine Friendly URLs by vBSEO 3.2.0