5.13 still breaks table widths in vbulletin enhanced quick reply template(NOT A BUG)

[somerfeld]

http://www.photopost.com/members/for...d.php?t=112225

same error i posted about above except with 5.13

here is a screen shot of 5.13 with the table break

I do not know what varible vbulletin uses to define it's table but i know they are in the style area

[somerfeld]

also here http://www.photopost.com/members/for...d.php?t=111818

[Chuck S]

Hello

Michael noted in that thread its in the vb templates as a fixed number as well and not a configurable number.

In quickcom.tmpl is this and you can change it to what suits you if your using small tables most likely change it to 60

<textarea name="message" cols="80" rows="5"></textarea>

[somerfeld]

no it is not fixed in the vbulletin,. everything width can be changed through the styles. Also that was not what mike saying.. he was asking..

Well, if you look at the vB code - the width is fixed in the templates; how did you handle the vb templates?

and I'm saying through the style options where you can change the width varibles with in vbulletin

Mike needs to use one of the varbiles in the style options,..

In fact I just went ahead and found the one he needs to use


In style varible options under Sizes and Dimensions there is a varible called:

Message Area Width (pixels)
(This value allows you to specify the width in pixels of the text box used for all message posting in vBulletin)

Mike needs to use that varible in the pp vb templates

hope that helps

the image attached you can see the option on the bottom

[somerfeld]

i looked in the quick refrence varibles and i think the actuall vaible is $vbphrase[form_width]

[somerfeld]

i will try it soon and let you know if it works

[Chuck S]

ok thanks

[somerfeld]

<div class="controlbar">
<textarea name="message" id="qr_message" class="bginput" style="width:{$vbphrase[form_width]}; height:100px" cols="60" rows="5" tabindex="1"></textarea>
</div>

worked perfectly!

attached shows..

can you fix this for the following versions?

[Chuck S]

Well your code shows me that the columns is a fixed width as Michael is talking about. See the issue is not with the table width yet the number of columns as I stated above .

Vb has the columns hard coded to 60 cols so the style width has nothing to do with it.

See ours has an 80 column thing which is hardcoded just like VB

So the proper thing would maybe be just set our column width to 60 the same as VB

[somerfeld]

I dont know if I understood that, but you got my fix to put in future versions correct?

[somerfeld]

I believe style="width:{$vbphrase[form_width]}; superceds the colums

[somerfeld]

not a bug,.. ?? a table break because you do not use the form width varible is a bug

how is this not?

are you not going to include this after I fixed the error and showed you why and what varible it is?

[Chuck S]

You totally misunderstand what I am saying.

The issue has nothing to do with table width or adding variables. It is as I said all along and Michael has said in the other thread you linked

VB uses a FIXED WIDTH column of 60.

We use a FIXED WIDTH column of 80

I simply stated the easiest thing for us to consider is reducing the columns and no the fixed width will not superceed a column setting as thats what is breaking your already fixed set width is that column setting of 80.

Try very simply putting back into place the non edited files and doing the edit I stated above by replacing in quickcom.tmpl to 60 column width from 80 and you will see problem on small fixed width sites solved.

I cant say when and if this is included as I am not the developer

[Chuck S]

To answer on why its not considered a bug!!

Michael has coded the template to use 80 columns. Vb chooses to use 60. That is the intended use of the columns and works for most setups. Any user has the ability to edit a template to correct a look. Making a very simple template edit to accomidate your widths does not constitute a bug.

Same thing if a user has there medium width set to 600 and the pictures break the table cell cause they use a 700 width frame or choose to display 5 150 pixel thumbsnails is that considered a bug. Nope! they need to set there medium size to a smaller size or reduce thumbnail size depending on there width.

There are many things that can cause a table cell to break out of frame when one uses a small fixed table width and thats why users have the ability to edit there templates to accomidate such things. Vb does not even set an option for the columns in there code and its hard coded.

As such all I can say is we shall consider reducing our hardoded columns to match there hardcoded columns

[somerfeld]

ok i will try 60,

but to keep in with the idea of photoposts vb "enhanced" templates why would you not use the vbulletin varible..

I will post back soon

[Michael P]

If its a better way of using the vb side to define the width, I'm all for it - let me try it out on some sites.

[Chuck S]

I already know 60 works

Basically as I had said thats not the issue. Issue is this no matter what small fixed with whether 700-750 etc what is breaking things is the hardcoded column of 80. Vbulletin is you look at there templates uses a hard coded column of 60 like Michael already stated in the previous thread. Only a few users have had this issue as not many use small table width's anymore however as I previously stated we shall consider in a future version changing the quickcom.tmpl of ours in vbenhanced to use a hardcoded column of 60 as that would be the easiest and appropriate response based off how vb does it.

[somerfeld]

fyi I have a monitor on my laptop that is 16:9 ratio and it makes sites that are 100% in width horrible so i have percise viewing size on my site

anyhoo thanks for your time hope to see it in future versions

[Chuck S]

His code will work.

all the edit is is to replace the hardcoded 600px with this {$vbphrase[form_width]} in quickcom.tmpl